Repository navigation
Commit 918b93f
Suppress warnings from macOS 27 logging macros
Suppress `-Wignored-attributes` triggered when compiling macOS-specific
logging and tracing code in `debug.cpp`.
In the macOS 27 SDK introduced with Xcode 27, Apple has applied an
`OS_LOG_UNINITIALIZED` macro inside their logging and signposting
headers (`os/log.h`, `os/signpost.h`, `os/trace_base.h`) which expands
to include `__attribute__((stack_protector_ignore))`.
Because of this, stack protection checks are skipped on local formatting
buffers generated by logging macros such as `os_log_with_type` and
`os_signpost_event_emit`. However, in Flutter (and likely other ANGLE
users), we compile the engine with `-fstack-protector-all`, which causes
the build to error out complaining that the `stack_protector_ignore`
attribute is being ignored:
error: 'stack_protector_ignore' attribute ignored due to '-fstack-protector-all' option [-Werror,-Wignored-attributes]
This wraps these usages in ignore pragmas to avoid disabling it across
the board.
Bug: b/523963866
Change-Id: Iee87ccddb6dd469a230d7e39a957bb441c41e4a2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/7930232
Reviewed-by: Geoff Lang <[email protected]>
Reviewed-by: Charlie Lao <[email protected]>
Auto-Submit: Chris Bracken <[email protected]>
Commit-Queue: Geoff Lang <[email protected]>1 parent 65ee1a4 commit 918b93f
1 file changed
Lines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| 29 | + | |
| 30 | + | |
29 | 31 | | |
| 32 | + | |
30 | 33 | | |
31 | 34 | | |
32 | 35 | | |
| |||
293 | 296 | | |
294 | 297 | | |
295 | 298 | | |
| 299 | + | |
| 300 | + | |
296 | 301 | | |
297 | 302 | | |
| 303 | + | |
298 | 304 | | |
299 | 305 | | |
300 | 306 | | |
| |||
0 commit comments