Import and build graphics_detector #910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacnak
requested review from
Databean,
adelva1984,
jemoreira,
rmuthiah and
ser-io
as code owners
jmacnak
force-pushed
the
main
branch
3 times, most recently
from
cd03218 to
98a49dc
Compare
Databean
approved these changes
Mar 11, 2025
jmacnak
force-pushed
the
main
branch
13 times, most recently
from
904f66f to
8950f99
Compare
Member
Author
|
PTAL!
|
ser-io
approved these changes
Mar 12, 2025
This was originally in the Cuttlefish project but was then moved to gfxstream project in order to simplify building with glibc as a prebuilt for aarch64 support. This can be moved back to Cuttlefish given that everything will be built with host toolchain instead of Android's host toolchain. Bug: b/402435591 Bug: b/402435147 Bug: b/402436140 Test: bazel build tools/graphics_detector:all
jmacnak
added a commit
to jmacnak/android-cuttlefish
that referenced
this pull request
Dec 5, 2025
Equivalent ag/34111853 google#910 added the graphics detector to the github package. Then google#1177 added symlinks to not break the internal build prior to ag/34111853. After ag/34111853, internal build started to use the general binary. However, this was missing from the github package which made ag/35919528 start to reference the old file names. Bug: b/466394895
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 9, 2025
Equivalent ag/34111853 #910 added the graphics detector to the github package. Then #1177 added symlinks to not break the internal build prior to ag/34111853. After ag/34111853, internal build started to use the general binary. However, this was missing from the github package which made ag/35919528 start to reference the old file names. Bug: b/466394895
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally in the Cuttlefish project but was then moved to gfxstream project in order to simplify building with glibc as a prebuilt for aarch64 support. This can be moved back to Cuttlefish given that everything will be built with host toolchain instead of Android's host toolchain.
Bug: b/402435591
Bug: b/402435147
Bug: b/402436140
Test: bazel build tools/graphics_detector:all