Support building podman image on image-builder.sh #1870
Conversation
As this image no longer contains cvd binary under /root/cvd_home/bin, this change removes related code on container/guest/run_services.sh
As mesa-utils or cuttlefish-base depends on libvulkan1, it doesn't need to install explicitly.
As one container instance based on this image is for creating one Cuttlefish instance group, it doesn't need to create a lot of TAP interfaces.
GoogleCuttlefishTesterBot
removed
the
kokoro:force-run
Why do we want that? Does podmam build has any advantages over docker build? The container image (either from docker build and podmam build) is compatible with both runtime. |
ikicha
left a comment
ikicha
left a comment
There was a problem hiding this comment.
We may want to separate a PR for clean-up. But i think either is okay
We may want to switch perhaps, because of integration with E2E testing. As But I don't think it's a must thing, as both buildkit for docker and buildah for podman satisfies OCI. It wasn't a strong motivation to drive this PR. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
3 participants
Context: b/466411126
Finally all preconditions are validated to launch Cuttlefish instances on podman instance, including GPU acceleration. So there's no blockers anymore to use podman. For the better maintenance, we wish to maintain only one container image in the end. However it still has some existing use cases prior to replace docker into podman, such as Cloud Orchestrator. Thus, I suggest to make both docker and podman available by single container image.
The purpose of this PR is to define a way to build podman image as we build docker image. After once we can build podman image via same steps, it would be able to switch current deployment pipeline based on
docker buildintopodman build.However, the podman image defined here won't start separated init process for container. This means this image won't work with
systemd-journal-gatewayd. I can make podman image possible to support it, but we need to keep maintenance for 2 container images as docker can't follow the same approach. With this PR, I believe #1832 is getting to be required again, though not a blocker of this PR.