Optionally set defaults file when minting images. #1864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ser-io
requested changes
Dec 3, 2025
3405691582
force-pushed
the
baseimage_defaults
branch
from
22c93e9 to
62adee6
Compare
ser-io
requested changes
Dec 3, 2025
3405691582
force-pushed
the
baseimage_defaults
branch
from
62adee6 to
bedf585
Compare
ser-io
approved these changes
Dec 3, 2025
3405691582
force-pushed
the
baseimage_defaults
branch
2 times, most recently
from
1176acf to
b573775
Compare
ser-io
approved these changes
Dec 3, 2025
3405691582
force-pushed
the
baseimage_defaults
branch
from
b573775 to
5324cae
Compare
ser-io
approved these changes
Dec 3, 2025
3405691582
force-pushed
the
baseimage_defaults
branch
from
5324cae to
a829528
Compare
ser-io
approved these changes
Dec 3, 2025
3405691582
force-pushed
the
baseimage_defaults
branch
from
a829528 to
2cb5968
Compare
3405691582
force-pushed
the
baseimage_defaults
branch
from
2cb5968 to
6fef7dd
Compare
We want to ensure that static defaults are set when images run within particular environments, e.g., a particular GCE project. This occurs when there exists a file in `/etc/defaults/cuttlefish-integration` and contains `static_defaults_when=<condition>` (see google#1859). We thus need to ensure that the `cuttlefish-integration` file is set appropriately; we just do this by uploading the file when minting the image.
3405691582
force-pushed
the
baseimage_defaults
branch
from
6fef7dd to
9d5e5b3
Compare
GoogleCuttlefishTesterBot
removed
the
kokoro:force-run
GoogleCuttlefishTesterBot
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to ensure that static defaults are set when images run within particular environments, e.g., a particular GCE project. This occurs when there exists a file in
/etc/defaults/cuttlefish-integrationand containsstatic_defaults_when=<condition>(see #1859). We thus need to ensure that thecuttlefish-integrationfile is set appropriately; we just do this by a flag set appropriately when minting the image.