Use Result in SplitRamdiskModules
#1850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`SplitRamdiskModules` called many functions that returned `Result`s, and is only called within a `CF_EXPECT` invocation. This means it can forward errors out to its caller as a `Result`, rather than use `CHECK`s or conditionals on the `Result`s it calls. Tested with ``` $ bazel run //cuttlefish/package:cvd -- fetch --default_build=git_main/aosp_cf_x86_64_only_phone-trunk_staging-userdebug --target_directory=$HOME/dl_kernel --kernel_build=aosp_kernel-common-android-mainline/kernel_virt_x86_64 $ bazel run //cuttlefish/package:cvd -- create --host_path=$HOME/dl_kernel --product_path=$HOME/dl_kernel --host_substitutions=bin/assemble_cvd,bin/run_cvd ``` Bug: b/464082938
Databean
added a commit
to Databean/android-cuttlefish
that referenced
this pull request
Nov 27, 2025
While writing google#1850 I ran into an issue that the compiler didn't check return type mismatches between the same function, leading to segfaults at runtime. Including the header makes the functions explicitly conflict. Bug: b/464088042
rmuthiah
approved these changes
Nov 27, 2025
Member
Author
|
Thanks for reviewing! |
Databean
added a commit
to Databean/android-cuttlefish
that referenced
this pull request
Dec 1, 2025
While writing google#1850 I ran into an issue that the compiler didn't check return type mismatches between the same function, leading to segfaults at runtime. Including the header makes the functions explicitly conflict. Bug: b/464088042
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 9, 2025
While writing #1850 I ran into an issue that the compiler didn't check return type mismatches between the same function, leading to segfaults at runtime. Including the header makes the functions explicitly conflict. Bug: b/464088042
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SplitRamdiskModulescalled many functions that returnedResults, and is only called within aCF_EXPECTinvocation. This means it can forward errors out to its caller as aResult, rather than useCHECKs or conditionals on theResults it calls.Tested with
Bug: b/464082938