Skip to content

Conversation

@Databean
Copy link
Member

#1762 added automatic fetch trace logging for each individual file extracted from a .zip file. Many of these operations are very fast, especially for otatools.zip and take many lines of logs. These should be condensed since they don't contribute much to the overall time and make the trace harder to read.

Sample new output:

Performance stats:
PreFetch actions:
 started: 2025-11-25 15:52:13, duration: 1 s
 - GetBuilds: 1 s
Host Package:
 started: 2025-11-25 15:52:14, duration: 3 m 13 s
 - Download: 3 m 6 s, 851 MiB
 - Extract: 6 s
 - 2 operations omitted with a combined duration of 12 ms.
Default:
 started: 2025-11-25 15:52:14, duration: 7 m 33 s
 - Downloaded 'misc_info.txt': 1 s, 9000 B
 - Downloaded 'aosp_cf_x86_64_only_phone-img-14496483.zip': 7 m 23 s, 1135 MiB
 - Extracted 'super.img' from 'aosp_cf_x86_64_only_phone-img-14496483.zip': 7 s, 1339 MiB
 - Desparsed [/super.img]: 933 ms, 8192 MiB
 - 22 operations omitted with a combined duration of 549 ms.
Kernel:
 started: 2025-11-25 15:59:47, duration: 8 ms
 - 4 operations omitted with a combined duration of 8 ms.
OTA Tools:
 started: 2025-11-25 15:59:47, duration: 1 m 54 s
 - Downloaded 'otatools.zip': 1 m 51 s, 486 MiB
 - 14653 operations omitted with a combined duration of 3 s.

Bug: b/463765667

google#1762 added
automatic fetch trace logging for each individual file extracted from a
`.zip` file. Many of these operations are very fast, especially for
`otatools.zip` and take many lines of logs. These should be condensed
since they don't contribute much to the overall time and make the trace
harder to read.

Sample new output:
```
Performance stats:
PreFetch actions:
 started: 2025-11-25 15:52:13, duration: 1 s
 - GetBuilds: 1 s
Host Package:
 started: 2025-11-25 15:52:14, duration: 3 m 13 s
 - Download: 3 m 6 s, 851 MiB
 - Extract: 6 s
 - 2 operations omitted with a combined duration of 12 ms.
Default:
 started: 2025-11-25 15:52:14, duration: 7 m 33 s
 - Downloaded 'misc_info.txt': 1 s, 9000 B
 - Downloaded 'aosp_cf_x86_64_only_phone-img-14496483.zip': 7 m 23 s, 1135 MiB
 - Extracted 'super.img' from 'aosp_cf_x86_64_only_phone-img-14496483.zip': 7 s, 1339 MiB
 - Desparsed [/super.img]: 933 ms, 8192 MiB
 - 22 operations omitted with a combined duration of 549 ms.
Kernel:
 started: 2025-11-25 15:59:47, duration: 8 ms
 - 4 operations omitted with a combined duration of 8 ms.
OTA Tools:
 started: 2025-11-25 15:59:47, duration: 1 m 54 s
 - Downloaded 'otatools.zip': 1 m 51 s, 486 MiB
 - 14653 operations omitted with a combined duration of 3 s.
```

Bug: b/463765667
@Databean Databean requested a review from jemoreira November 26, 2025 00:07
@Databean Databean enabled auto-merge November 26, 2025 01:22
@Databean
Copy link
Member Author

Thanks for reviewing!

@Databean Databean added this pull request to the merge queue Nov 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 26, 2025
@Databean Databean added this pull request to the merge queue Nov 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 26, 2025
@Databean Databean added this pull request to the merge queue Nov 26, 2025
Merged via the queue into google:main with commit a3f4d67 Nov 26, 2025
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants