Pin cxx dependency in netsim to fix build #1824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jemoreira
approved these changes
Nov 21, 2025
As of version 1.0.89, cxx started versioning their generated symbols to detect version mismatches between the version of cxx used for rust and c++ code in the same project. Netsim was automatically using the latest cxx, while bazel was pinned at 1.0.68. The bazel registry only goes up to 1.0.88, so pin both projects there. See https://www.github.com/dtolnay/cxx/pull/1665 Bug: b/462513519
``` WARNING: For repository 'bazel_skylib', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off WARNING: For repository 'rules_cc', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off WARNING: For repository 'rules_rust', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off ``` Bug: b/462513519
Databean
force-pushed
the
pin_netsim_cxx
branch
from
631cf6c to
7d1f653
Compare
Databean
added
kokoro:force-run
GoogleCuttlefishTesterBot
removed
kokoro:run
Databean
added
kokoro:force-run
GoogleCuttlefishTesterBot
removed
kokoro:run
Databean
added
kokoro:force-run
GoogleCuttlefishTesterBot
removed
kokoro:run
Member
Author
|
Thanks for renewing! |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of version 1.0.89, cxx started versioning their generated symbols to detect version mismatches between the version of cxx used for rust and c++ code in the same project. Netsim was automatically using the latest cxx, while bazel was pinned at 1.0.68. The bazel registry only goes up to 1.0.88, so pin both projects there.
See https://www.github.com/dtolnay/cxx/pull/1665
Bug: b/462513519