Log instead of failing substitutions. #1716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to gracefully handle missing files during substitution attempts, most importantly, when we want to stop vending a particular host binary but existing substitution files may still refer to the binary. Additionally, this is relevant when we want to start vending a particular host binary, the default substitution file is updated, but this substitution file will be visible on installations where that binary is not yet available.
3405691582
added a commit
to 3405691582/android-cuttlefish
that referenced
this pull request
Oct 15, 2025
As discussed elsewhere, this should no longer be needed. Substitution file parsing will need to change to handle the fact that we aren't vending `acloud_translator` any more and existing substitution files may still refer to it. We could address that here, but instead it might be better to do this more generally in google#1716 before this commit.
jemoreira
approved these changes
Oct 15, 2025
3405691582
added a commit
to 3405691582/android-cuttlefish
that referenced
this pull request
Oct 21, 2025
As discussed elsewhere, this should no longer be needed. Substitution file parsing will need to change to handle the fact that we aren't vending `acloud_translator` any more and existing substitution files may still refer to it. We could address that here, but instead it might be better to do this more generally in google#1716 before this commit.
3405691582
added a commit
to 3405691582/android-cuttlefish
that referenced
this pull request
Oct 21, 2025
As discussed elsewhere, this should no longer be needed. Substitution file parsing will need to change to handle the fact that we aren't vending `acloud_translator` any more and existing substitution files may still refer to it. We could address that here, but instead it might be better to do this more generally in google#1716 before this commit.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 22, 2025
As discussed elsewhere, this should no longer be needed. Substitution file parsing will need to change to handle the fact that we aren't vending `acloud_translator` any more and existing substitution files may still refer to it. We could address that here, but instead it might be better to do this more generally in #1716 before this commit.
3405691582
added a commit
to 3405691582/android-cuttlefish
that referenced
this pull request
Dec 8, 2025
We previously updated part of the substitution logic to not treat missing files as an error in google#1716, but that change only updates the marker file-based substitutions. To bring this logic to flag-based substitution, we make the newer logic common to both branches, which necessitated moving some of the logic around.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 10, 2025
We previously updated part of the substitution logic to not treat missing files as an error in #1716, but that change only updates the marker file-based substitutions. To bring this logic to flag-based substitution, we make the newer logic common to both branches, which necessitated moving some of the logic around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to gracefully handle missing files during substitution attempts, most importantly, when we want to stop vending a particular host binary but existing substitution files may still refer to the binary.
Additionally, this is relevant when we want to start vending a particular host binary, the default substitution file is updated, but this substitution file will be visible on installations where that binary is not yet available.