Creates graphics symlinks using debian links file #1177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacnak
force-pushed
the
graphics-links-v2
branch
2 times, most recently
from
991a08f to
90dc52c
Compare
Databean
reviewed
May 20, 2025
* Adds symlinks for the software renering libs
* Additional create graphics symlinks using debian links file.
The bazel symlink creation is useful for local dev but does
not work for the actual packaging step and the package ended
up with full copies.
Bug: b/403290370
Bug: b/410874401
Bug: b/410644750
TEST:
```
$ tools/buildutils/build_packages.sh
$ sudo apt install ./cuttlefish-base_*.deb ./cuttlefish-user_*.deb
```
and then checking links:
```
$ ls -al /usr/lib/cuttlefish-common/bin/aarch64-linux-gnu/gfxstream_graphics_detector
lrwxrwxrwx 1 root root 20 May 16 17:57 /usr/lib/cuttlefish-common/bin/aarch64-linux-gnu/gfxstream_graphics_detector -> ../graphics_detector
$ ls -al /usr/lib/cuttlefish-common/bin/x86_64-linux-gnu/gfxstream_graphics_detector
lrwxrwxrwx 1 root root 20 May 16 17:57 /usr/lib/cuttlefish-common/bin/x86_64-linux-gnu/gfxstream_graphics_detector -> ../graphics_detector
$ ls -al /usr/lib/cuttlefish-common/lib64/vulkan*
lrwxrwxrwx 1 root root 24 May 16 17:57 vulkan.lvp.so -> ../bin/libvk_lavapipe.so
lrwxrwxrwx 1 root root 27 May 16 17:57 vulkan.pastel.so -> ../bin/libvk_swiftshader.so
```
and then using local Android repo with an additional
```
symlinks: {
target: "/usr/lib/cuttlefish-common/bin/graphics_detector"
link_name: "bin/x86_64-linux-gnu/gfxstream_graphics_detector"
}
```
and `cvd start` successfully detects GPU support and confirming the debian
substitution worked:
```
$ ls -al out/host/linux-x86/bin/x86_64-linux-gnu/gfxstream_graphics_detector
lrwxrwxrwx 1 natsu primarygroup 75 May 19 10:44 out/host/linux-x86/bin/x86_64-linux-gnu/gfxstream_graphics_detector -> /usr/lib/cuttlefish-common/bin/x86_64-linux-gnu/gfxstream_graphics_detector
```
jmacnak
force-pushed
the
graphics-links-v2
branch
from
90dc52c to
1a8dbe6
Compare
Databean
approved these changes
May 28, 2025
jmacnak
added a commit
to jmacnak/android-cuttlefish
that referenced
this pull request
Dec 5, 2025
Equivalent ag/34111853 google#910 added the graphics detector to the github package. Then google#1177 added symlinks to not break the internal build prior to ag/34111853. After ag/34111853, internal build started to use the general binary. However, this was missing from the github package which made ag/35919528 start to reference the old file names. Bug: b/466394895
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 9, 2025
Equivalent ag/34111853 #910 added the graphics detector to the github package. Then #1177 added symlinks to not break the internal build prior to ag/34111853. After ag/34111853, internal build started to use the general binary. However, this was missing from the github package which made ag/35919528 start to reference the old file names. Bug: b/466394895
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds symlinks for the software renering libs
Additional create graphics symlinks using debian links file.
The bazel symlink creation is useful for local dev but does
not work for the actual packaging step and the package ended
up with full copies.
Bug: b/403290370
Bug: b/410874401
Bug: b/410644750
TEST:
and then checking links:
and then using local Android repo with an additional
and
cvd startsuccessfully detects GPU support and confirming the debian substitution worked: