Enable Adreno GPU counters #1138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmuetschard
approved these changes
Jun 30, 2022
Member
pmuetschard
left a comment
pmuetschard
left a comment
There was a problem hiding this comment.
I think this is the right place.
core/os/android/adb/device.go
Outdated
Comment on lines
426
to
448
| lsResult, err := b.Shell(fmt.Sprintf("ls %s", counterFilePath)).Call(ctx) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| // If the file does not exist | ||
| if lsResult != counterFilePath { | ||
| return nil | ||
| } | ||
|
|
||
| fileContent, err := b.Shell(fmt.Sprintf("cat %s", counterFilePath)).Call(ctx) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| // Early exit if the file has already been edited. | ||
| if fileContent != "0" { | ||
| return nil | ||
| } | ||
|
|
||
| _, err = b.Shell(fmt.Sprintf("echo 1 > %s", counterFilePath)).Call(ctx) | ||
| return err | ||
| } |
Member
There was a problem hiding this comment.
I'd just do this to keep it short, it's a work-around after all:
b.Shell(fmt.Sprintf("[ -w %s ] && echo 1 > %s", counterFilePath, counterFilePath))
rosasco-wk
pushed a commit
to rosasco-wk/agi
that referenced
this pull request
Sep 3, 2022
Added extra adb shell commands to enable Adreno's GPU counters if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would like input/feedback on where this code should be called