Repository navigation
fix(sessions): use PostgreSQL JSON instead of JSONB for DynamicJSON - #7857
Closed
ninglinLiu wants to merge 14 commits into
Closed
ninglinLiu wants to merge 14 commits into
ninglinLiu wants to merge 14 commits into
Conversation
JSONB reorders object keys, coerces large floats to ints, turns -0.0 into 0.0, and rejects NUL in strings, so DatabaseSessionService round- trips differ from SQLite. Use the json column type so PostgreSQL keeps values like the TEXT path does. Fixes google#7854
copybara-service Bot
pushed a commit
that referenced
this pull request
Nov 3, 2026
Merge #7857 DynamicJSON now creates PostgreSQL columns as `json` instead of `jsonb`, so state and event values keep key order, floats such as `-0.0` and `1e23`, and NUL characters, as on SQLite. Only newly created tables change; existing `jsonb` tables are not altered and still read and write; the PostgreSQL sample README shows how to convert them. Queries outside ADK that use jsonb-only operators or GIN indexes will not work on new tables. Part of #7854 PiperOrigin-RevId: 1013154584
Collaborator
|
Thank you @ninglinLiu for your contribution! 🎉 Your changes have been successfully imported and merged via Copybara in commit d487c53. Closing this PR as the changes are now in the main branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DynamicJSONusedpostgresql.JSONBfor PostgreSQL. JSONB reorders object keys, coerces large floats (e.g.1e23) to ints, turns-0.0into0.0, and rejects NUL (\x00) in strings — soDatabaseSessionServiceround-trips differ from SQLite, which storesjson.dumpstext.Switch the dialect type to
postgresql.JSON, which preserves input the same way the issue reports.Note for existing deployments: tables already created with JSONB keep that storage until altered (e.g.
ALTER ... TYPE json). New creates getjson.Test plan
test_schemas_sharedexpectations forpostgresql.JSONtests/unittests/sessions/test_schemas_shared.py— 19 passedFixes #7854