Skip to content

unnecessary excessive DB calls? #764

Closed
Closed

Description

@mohammad-passage

** Please make sure you read the contribution guide and file the issues in the rigth place. **
Contribution guide.

Describe the bug
We ran an ADK agent over 3500 objects and that took our database down.
Looking at queries it seems this query is causing it:

UPDATE app_states SET state=$1::JSONB, update_time=now() WHERE app_states.app_name = $2

I don't ever see a case that we actually want state for apps yet this is causing huge load on the DB. Also I don't have any state with prefix app: so I was not expecting this DB all at all.

To Reproduce
N/A

Expected behavior
N/A
Screenshots
Image

Desktop (please complete the following information):
N/A
Additional context
N//a

Activity

  1. seanzhou1023 commented on May 19, 2025

    @seanzhou1023
    Collaborator

    @mohammad-passage thanks for reporting the issue. Are you able to provide some agent codes and sample user queries that we can reproduce ?

  2. added
    services[Component] This issue is related to runtime services, e.g. sessions, memory, artifacts, etc
    on May 19, 2025
  3. added theissue type on May 19, 2025
  4. mohammad-passage commented on May 19, 2025

    @mohammad-passage
    Author

    Our code has no app: state so I guess any random agent has same issue that creates an empty app state and suffers from hot key update at scale.

  5. added this to the FixIt Week milestone on May 28, 2025
  6. DeanChensj commented on May 28, 2025

    @DeanChensj
    Collaborator

    Thanks for raising this issue. It will be fixed when d83ee1a is included in next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

services[Component] This issue is related to runtime services, e.g. sessions, memory, artifacts, etc

Type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions