Repository navigation
Commit e95b1ad
authored
fix: gate workflow tool node confirmation resume on the caller principal (3/5)
_ToolNode._apply_confirmation_resume (ce132b9) stored ctx.resume_inputs on
ctx.tool_confirmation with no principal check, and apply_confirmation_gate is a
no-op for tools whose check_require_confirmation is False yet read
tool_confirmation themselves, ExecuteBashTool included. With strict mode on, an
unauthenticated caller could resume a paused tool node with confirmed=True and
the tool ran. The answer is now rewritten to confirmed=False before it is
stored, so every reader sees the refusal.1 parent 51775f4 commit e95b1ad
1 file changed
Lines changed: 13 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| 29 | + | |
29 | 30 | | |
30 | 31 | | |
31 | 32 | | |
| |||
258 | 259 | | |
259 | 260 | | |
260 | 261 | | |
261 | | - | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
262 | 268 | | |
263 | 269 | | |
264 | | - | |
265 | | - | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
266 | 276 | | |
267 | 277 | | |
268 | 278 | | |
| |||
0 commit comments