Repository navigation
Commit b981250
fix: stop list_sessions(user_id="") from listing every user in Firestore
Merge #7663
`FirestoreSessionService.list_sessions(user_id="")` used to fall through
to the all-users `collection_group` query and return every user's
sessions in the app. It now returns no sessions: Firestore rejects an
empty document ID, so no session can be stored under `""`.
Fixes #7662
PiperOrigin-RevId: 10060240201 parent 6c20444 commit b981250
2 files changed
Lines changed: 38 additions & 2 deletions
File tree
- src/google/adk/integrations/firestore
- tests/unittests/integrations/firestore
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
368 | 368 | | |
369 | 369 | | |
370 | 370 | | |
371 | | - | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
372 | 375 | | |
373 | 376 | | |
374 | 377 | | |
| |||
392 | 395 | | |
393 | 396 | | |
394 | 397 | | |
395 | | - | |
| 398 | + | |
396 | 399 | | |
397 | 400 | | |
398 | 401 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
961 | 961 | | |
962 | 962 | | |
963 | 963 | | |
| 964 | + | |
| 965 | + | |
| 966 | + | |
| 967 | + | |
| 968 | + | |
| 969 | + | |
| 970 | + | |
| 971 | + | |
| 972 | + | |
| 973 | + | |
| 974 | + | |
| 975 | + | |
| 976 | + | |
| 977 | + | |
| 978 | + | |
| 979 | + | |
| 980 | + | |
| 981 | + | |
| 982 | + | |
| 983 | + | |
| 984 | + | |
| 985 | + | |
| 986 | + | |
| 987 | + | |
| 988 | + | |
| 989 | + | |
| 990 | + | |
| 991 | + | |
| 992 | + | |
| 993 | + | |
| 994 | + | |
| 995 | + | |
| 996 | + | |
964 | 997 | | |
965 | 998 | | |
966 | 999 | | |
| |||
0 commit comments