Repository navigation
Commit ac990df
fix(sessions): check
Previously, `SqliteSessionService.list_sessions` used `if user_id:` instead of `if user_id is not None:`. Because `bool("")` is `False`, passing an empty string `user_id=""` fell through to the unfiltered `WHERE app_name=?` query and returned sessions and user state across all users in the database.
Check `if user_id is not None:` so `user_id=""` only queries sessions belonging to `""`, matching `InMemorySessionService`, `DatabaseSessionService`, and `RedisSessionService`, and add a shared contract test covering `user_id=""`.
Merge #7171
PiperOrigin-RevId: 995906908user_id is not None instead of truthiness in SqliteSessionService.list_sessions
1 parent cb9b8f7 commit ac990df
3 files changed
Lines changed: 28 additions & 5 deletions
File tree
- src/google/adk/sessions
- tests/unittests/sessions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
358 | 358 | | |
359 | 359 | | |
360 | 360 | | |
361 | | - | |
| 361 | + | |
362 | 362 | | |
363 | 363 | | |
364 | 364 | | |
| |||
376 | 376 | | |
377 | 377 | | |
378 | 378 | | |
379 | | - | |
| 379 | + | |
380 | 380 | | |
381 | 381 | | |
382 | 382 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
137 | 137 | | |
138 | 138 | | |
139 | 139 | | |
140 | | - | |
141 | | - | |
142 | | - | |
143 | 140 | | |
144 | 141 | | |
145 | 142 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
711 | 711 | | |
712 | 712 | | |
713 | 713 | | |
| 714 | + | |
| 715 | + | |
| 716 | + | |
| 717 | + | |
| 718 | + | |
| 719 | + | |
| 720 | + | |
| 721 | + | |
| 722 | + | |
| 723 | + | |
| 724 | + | |
| 725 | + | |
| 726 | + | |
| 727 | + | |
| 728 | + | |
| 729 | + | |
| 730 | + | |
| 731 | + | |
| 732 | + | |
| 733 | + | |
| 734 | + | |
| 735 | + | |
| 736 | + | |
| 737 | + | |
| 738 | + | |
| 739 | + | |
714 | 740 | | |
715 | 741 | | |
716 | 742 | | |
| |||
0 commit comments