Repository navigation
fix(openaimodel): refuse non-function Tool fields genai adds - #1983
Merged
Merged
Conversation
EnsureFunctionToolOnly used a fixed denylist that missed FileSearch, ParallelAISearch, MCPServers and ExaAISearch, so those tools were dropped silently when FunctionDeclarations was also set. Invert the check with rejectUnsupportedFields so only FunctionDeclarations is accepted. Fixes google#1982
Contributor
Author
|
CI is green on this one. Ready for review/merge when you have a chance — thanks. |
Contributor
|
Hi @mangeshraut712 Thanks for the fix! The allowlist-based validation addresses the issue by preventing unsupported tool fields from being silently dropped. The changes look good to me. @baptmont Could you please take a look at these changes? |
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EnsureFunctionToolOnlyrefused non-function tools via a fixed denylist of eightgenai.Toolfields. genai v1.75.0 also hasFileSearch,ParallelAISearch,MCPServers, andExaAISearch. When one of those was set besideFunctionDeclarations, the converters sent the functions and dropped the other tool with no error.Invert the check with
rejectUnsupportedFieldsso onlyFunctionDeclarationsis accepted. New genai fields are refused the same way.Fixes #1982
Test plan
go test ./model/openaimodel/internal/shared/ -count=1