fix(sequentialagent): recurse task_completed injection and rebind Agent in Run and RunLive by somuai · Pull Request #1510 · google/adk-go

somuai · 2026-09-05T03:13:40Z

Fixes #1491

Problem

For a nested sequential agent pipeline like seq(llmA, seq(llmB)):

SequentialAgent.RunLive previously only inspected immediate sub-agents of ctx.Agent() when injecting task_completed and the exit instruction suffix. Because the inner sequential agent is not an llminternal.Agent, its nested LLM sub-agents were never injected, leaving llmB with no mechanism to signal completion during a live run.
When dispatching to sub-agents in RunLive and Run, the existing ctx was passed without rebinding Agent. Consequently, when the inner sequential agent executed, calling ctx.Agent().SubAgents() read the outer pipeline's sub-agents rather than its own, causing duplicate execution of outer agents or recursive loops.

Solution

Recursive injection: injectSubAgents recurses into subAgent.SubAgents() so all nested LLM agents receive the task_completed tool and instruction suffix prior to live session execution.
Context rebinding: Added subInvocationContext wrapping InvocationContext to override Agent() with the specific subAgent being invoked during both Run and RunLive.
Regression tests:
- Added TestSequentialAgent_RunLive_NestedSequentialInjection verifying that nested LLM agents receive task_completed tool injection.
- Added TestSequentialAgent_RunLive_NestedSequentialOrchestration verifying event propagation and live request routing through nested sequential pipelines.

Verification

go test -v -race ./agent/workflowagents/sequentialagent/... passed cleanly with zero data races.
gofmt and go vet passed with 0 warnings.

…nt in Run and RunLive Fixes google#1491 For a nested sequential agent like seq(llmA, seq(llmB)), RunLive previously only inspected the immediate sub-agents of ctx.Agent() without recursing into nested sub-agents, leaving the inner LLM agent without the task_completed tool or instruction suffix needed to signal completion. Additionally, invoking the sub-agent's Run and RunLive passed ctx directly without rebinding Agent, causing nested sequential agents to read the outer agent's sub-agent list instead of their own. - Recurse into sub-agents during task_completed injection when subAgent has sub-agents. - Introduce subInvocationContext to rebind Agent to subAgent during sub-agent Run and RunLive invocations. - Add regression unit tests TestSequentialAgent_RunLive_NestedSequentialInjection and TestSequentialAgent_RunLive_NestedSequentialOrchestration verifying injection and event routing for nested pipelines. Signed-off-by: SOUMYAJIT GHOSH <[email protected]>

wojtas000 · 2026-09-10T09:39:05Z

Summary for the review I just submitted — the body did not come through with it.

Changes requested. The nested-RunLive diagnosis is right and the fix does resolve #1491 — I reproduced both symptoms on the base commit and confirmed this head clears them. Two of the three hunks over-reach, though, and each is a behavior change against main on the 2.x line.

Breaking changes: 2 (both behavioral, both in the inline comments) — injection now permanently rewrites the tools and system instruction of LLM agents nested under a non-live composite, and Run now zeroes Path()/RunID()/SubScheduler() for every sub-agent.

I A/B'd both against 49224b6f762988234bc8933ed344eb4d3979b44e:

	base	this PR
`seq(loop(llmB))` `RunLive` (fails: loop has no `RunLive`) — is `llmB` mutated?	no	yes, tool added + instruction 12→235 bytes, persists
sub-agent `Path()`/`RunID()` under `seq.Run()`	`root/seq@1` / `run-7`	empty / empty

Applying just the two inline suggestions clears both, keeps every test in this PR green, and still passes the nested repro from #1491.

…nner gating, and test hardening - Revert Run to pass ctx directly to sub-agents, preserving commonContext fields (Path, RunID, SubScheduler) without zeroing. - Gate task_completed injection recursion in RunLive on liveRunner interface with a visited set to avoid mutating sub-agents under non-live composites. - Rebind agent in RunLive using ctx.WithICDelta rather than subInvocationContext, eliminating subInvocationContext entirely. - Add WithICDelta to mockInvocationContext in tests. - Change non-fatal assertion to t.Fatalf on author check and guard channel receives with select on ctx.Done(). - Add TestSequentialAgent_RunLive_NonLiveCompositeNotMutated verifying non-live composite children are not mutated. Signed-off-by: Soumyajit Ghosh <[email protected]>

somuai · 2026-09-10T14:30:03Z

Thank you @wojtas000 for the thorough and high-signal review!

All review feedback items have been addressed in commit 93780b8:

Gated injection on live-capable runners with cycle protection: Defined liveRunner interface and gated recursion with else if _, live := subAgent.(liveRunner); live && len(subAgent.SubAgents()) > 0. Added a visited set to defend against cyclic sub-agent graphs. Non-live composite agents like loops will no longer have their nested agents mutated.
Reverted Run to pass ctx directly: Restored subAgent.Run(ctx) in Run, preserving the fast-path in agent.Promote so that Path(), RunID(), and SubScheduler() retain their context values without zeroing.
Rebound RunLive via WithICDelta: Used ctx.WithICDelta(&agent.InvocationContextDelta{Agent: &subAgent}) directly on the invocation context, eliminating subInvocationContext entirely.
Updated mockInvocationContext: Implemented WithICDelta on mockInvocationContext in tests to support clean delta propagation.
Hardened tests:
- Swapped non-fatal assertions on sub-agent authors to t.Fatalf.
- Added else { t.Fatalf(...) } guards on llminternal.Agent type assertions so tests cannot pass silently.
- Wrapped channel receives in select with ctx.Done() timeouts to prevent test hangs.
- Added TestSequentialAgent_RunLive_NonLiveCompositeNotMutated to verify that nested sub-agents under non-live composites remain untouched.

All package unit tests and the full repository test suite (go test ./...) pass cleanly.

wojtas000

LGTM. Thanks for the quick and complete turnaround on this.

I re-checked the two breaking changes on this head: seq(loop(llmB)) now leaves llmB untouched, and a sub-agent under seq.Run() keeps its Path() and RunID(). NonLiveCompositeNotMutated fails against the previous head and passes here, so it pins the gate rather than just describing it. The new tests also fail on base in 0.086s now, instead of running into the package timeout.

One aside, nothing to change: the select guards you added use t.Context(), which only cancels at test cleanup, so they cannot fire while a receive is actually stuck. The t.Fatalf above each one is what prevents the hang — which is why the base run fails fast.

…nt in Run and RunLive (google#1510) * fix(sequentialagent): recurse task_completed injection and rebind Agent in Run and RunLive Fixes google#1491 For a nested sequential agent like seq(llmA, seq(llmB)), RunLive previously only inspected the immediate sub-agents of ctx.Agent() without recursing into nested sub-agents, leaving the inner LLM agent without the task_completed tool or instruction suffix needed to signal completion. Additionally, invoking the sub-agent's Run and RunLive passed ctx directly without rebinding Agent, causing nested sequential agents to read the outer agent's sub-agent list instead of their own. - Recurse into sub-agents during task_completed injection when subAgent has sub-agents. - Introduce subInvocationContext to rebind Agent to subAgent during sub-agent Run and RunLive invocations. - Add regression unit tests TestSequentialAgent_RunLive_NestedSequentialInjection and TestSequentialAgent_RunLive_NestedSequentialOrchestration verifying injection and event routing for nested pipelines. Signed-off-by: SOUMYAJIT GHOSH <[email protected]> * fix(sequentialagent): address review feedback on Run context, live runner gating, and test hardening - Revert Run to pass ctx directly to sub-agents, preserving commonContext fields (Path, RunID, SubScheduler) without zeroing. - Gate task_completed injection recursion in RunLive on liveRunner interface with a visited set to avoid mutating sub-agents under non-live composites. - Rebind agent in RunLive using ctx.WithICDelta rather than subInvocationContext, eliminating subInvocationContext entirely. - Add WithICDelta to mockInvocationContext in tests. - Change non-fatal assertion to t.Fatalf on author check and guard channel receives with select on ctx.Done(). - Add TestSequentialAgent_RunLive_NonLiveCompositeNotMutated verifying non-live composite children are not mutated. Signed-off-by: Soumyajit Ghosh <[email protected]> --------- Signed-off-by: SOUMYAJIT GHOSH <[email protected]> Signed-off-by: Soumyajit Ghosh <[email protected]> Co-authored-by: SOUMYAJIT GHOSH <[email protected]> Co-authored-by: Jan Wojtas <[email protected]>

…nt in Run and RunLive (#1510) (#1691) (cherry picked from commit 6476af6)

karolpiotrowicz mentioned this pull request Sep 6, 2026

fix(sequentialagent): make RunLive's task_completed injection race-free #1442

Closed

wojtas000 self-assigned this Sep 7, 2026

somuai and others added 2 commits September 8, 2026 09:10

Merge branch 'main' into fix-nested-sequential-agent-runlive

17fb032

Merge branch 'main' into fix-nested-sequential-agent-runlive

d04f397

wojtas000 self-requested a review September 10, 2026 09:37

wojtas000 requested changes Sep 10, 2026

View reviewed changes

Merge branch 'main' into fix-nested-sequential-agent-runlive

f61d179

wojtas000 approved these changes Sep 13, 2026

View reviewed changes

wojtas000 merged commit 6476af6 into google:main Sep 13, 2026
14 checks passed

wolo-lab mentioned this pull request Oct 1, 2026

fix(sequentialagent): backport recursive task_completed injection (#1510) #1691

Merged

wolo-lab added a commit that referenced this pull request Oct 2, 2026

fix(sequentialagent): recurse task_completed injection and rebind Age…

b21e040

…nt in Run and RunLive (#1510) (#1691) (cherry picked from commit 6476af6)

wolo-lab mentioned this pull request Oct 13, 2026

fix(workflowagents): backport loop and sequential agent fixes (#1722, #1684, #1780) #1838

Merged

Navigation Menu

Repository navigation

fix(sequentialagent): recurse task_completed injection and rebind Agent in Run and RunLive - #1510

fix(sequentialagent): recurse task_completed injection and rebind Agent in Run and RunLive#1510
wojtas000 merged 5 commits into
google:mainfrom
somuai:fix-nested-sequential-agent-runlive

somuai commented Sep 5, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wojtas000 commented Sep 10, 2026 •

edited

Loading

Uh oh!

somuai commented Sep 10, 2026

Uh oh!

wojtas000 left a comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

somuai commented Sep 5, 2026

Problem

Solution

Verification

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wojtas000 commented Sep 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

somuai commented Sep 10, 2026

Uh oh!

wojtas000 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

wojtas000 commented Sep 10, 2026 •

edited

Loading