[Permissions] Support calling rememberPermissionState in a Compose preview#1803
Conversation
eygraber
force-pushed
the
permission-in-previews
branch
from
f54f01e to
a3c24c2
Compare
| permissions: List<String>, | ||
| onPermissionsResult: (Map<String, Boolean>) -> Unit = {} | ||
| onPermissionsResult: (Map<String, Boolean>) -> Unit = {}, | ||
| permissionStatuses: Map<String, PermissionStatus> = emptyMap() |
There was a problem hiding this comment.
If this would prevent a release because of the API change I can move it to a separate PR. Not sure what the policy is with default params, but metalavaGenerateSignatureRelease seems to treat it as an API change (also see next commit where I address this with JvmOverloads).
There was a problem hiding this comment.
Yeah, default params don't fix binary compat unfortunately. Just add a new function and then make this one call your new one and then it is fine
There was a problem hiding this comment.
Does the JvmOverloads work for that, or does there have to be an actual new function in source?
There was a problem hiding this comment.
Good question, I'm not 100% sure actually but on Compose we always do it with a new function in source so I assume there is a reason
There was a problem hiding this comment.
Ok I'll push that shortly.
eygraber
force-pushed
the
permission-in-previews
branch
from
a3c24c2 to
fadb0fa
Compare
eygraber
force-pushed
the
permission-in-previews
branch
from
fadb0fa to
2d05d95
Compare
bentrengrove
left a comment
bentrengrove
left a comment
There was a problem hiding this comment.
Thank you for this!
2 participants
Spinning this out while the fate of #1793 hangs in the balance 😅