Upgrade to Kotlin 2.0.20 and move to build-logic for Gradle#1802
Merged
bentrengrove merged 7 commits intomainfrom Dec 10, 2024
Merged
Upgrade to Kotlin 2.0.20 and move to build-logic for Gradle#1802bentrengrove merged 7 commits intomainfrom
bentrengrove merged 7 commits intomainfrom
Conversation
bentrengrove
force-pushed
the
ben/buildlogic
branch
from
1752b31 to
6891537
Compare
bentrengrove
changed the title
mlykotom
approved these changes
Dec 9, 2024
Collaborator
mlykotom
left a comment
mlykotom
left a comment
There was a problem hiding this comment.
LGTM, but I think would be better if someone else also takes a look
build-logic/convention/src/main/kotlin/AndroidLibraryConventionPlugin.kt
Outdated
Show resolved
Hide resolved
build-logic/convention/src/main/kotlin/com/google/accompanist/KotlinAndroid.kt
Show resolved
Hide resolved
build-logic/convention/src/main/kotlin/AndroidLibraryConventionPlugin.kt
Show resolved
Hide resolved
alexvanyo
reviewed
Dec 9, 2024
build-logic/convention/src/main/kotlin/AndroidLibraryPublishedConventionPlugin.kt
Show resolved
Hide resolved
build-logic/convention/src/main/kotlin/com/google/accompanist/AndroidCompose.kt
Outdated
Show resolved
Hide resolved
build-logic/convention/src/main/kotlin/com/google/accompanist/KotlinAndroid.kt
Outdated
Show resolved
Hide resolved
build-logic/convention/src/main/kotlin/com/google/accompanist/KotlinAndroid.kt
Outdated
Show resolved
Hide resolved
build-logic/convention/src/main/kotlin/com/google/accompanist/KotlinAndroid.kt
Outdated
Show resolved
Hide resolved
Comment on lines
+86
to
+87
| sourceCompatibility = JavaVersion.VERSION_17 | ||
| targetCompatibility = JavaVersion.VERSION_17 |
Collaborator
There was a problem hiding this comment.
If I understand correctly, this will require consuming projects to build with at least JDK 17, since permissions-lint is consumed at Gradle build time.
That SGTM, given that AGP has required that level for a while now.
Collaborator
Author
There was a problem hiding this comment.
Yeah that's how I understand it as well but I wasn't 100% sure if it was right. Changing it to 1.8 though fails to build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I decided to clean up the Gradle files for Accompanist while upgrading to Kotlin 2.0