Conversation
| lintMinCompose = "30.0.0" | ||
|
|
||
| ktlint = "0.45.2" | ||
| kotlin = "1.9.0" |
There was a problem hiding this comment.
Not blocking - is bumping Kotlin and the compiler require from accompanist? Just wondering if the transitive Kotlin bump here is worth it (or if that bump would be transitive anyway from base Compose)
There was a problem hiding this comment.
We always just release with the latest compiler to make sure we stay up to date with fixes there. I haven't heard an issue yet with an incompatible change
There was a problem hiding this comment.
Not blocking - is bumping Kotlin and the compiler require from accompanist? Just wondering if the transitive Kotlin bump here is worth it (or if that bump would be transitive anyway from base Compose)
| @Composable | ||
| fun NavDrawerExample(activity: Activity) { | ||
| val icons = listOf( | ||
| Icons.Default.List, |
There was a problem hiding this comment.
Nit: Was this removed? Or was this one of the AutoMirrored icons?
There was a problem hiding this comment.
It was automirrored but the label looks weird in the sample because of splitting at the first .. It seemed easier to just remove it rather than fix that
3 participants
Fixes #1714