[Permissions-Lint] Migrate gradle file to Kotlin DSL#1631
Merged
bentrengrove merged 2 commits intogoogle:mainfrom Oct 10, 2023
Merged
[Permissions-Lint] Migrate gradle file to Kotlin DSL#1631bentrengrove merged 2 commits intogoogle:mainfrom
bentrengrove merged 2 commits intogoogle:mainfrom
Conversation
oas004
commented
May 18, 2023
oas004
commented
May 18, 2023
| * not currently support dependencies, so instead we need to bundle any dependencies with the | ||
| * lint jar manually. (b/182319899) | ||
| */ | ||
| val bundleInside: Configuration = configurations.create("bundleInside") |
Contributor
Author
There was a problem hiding this comment.
Had to rename this for the dependency function to work
oas004
commented
May 18, 2023
| // The stdlib is already bundled with lint, so no need to include it manually | ||
| // in the lint.jar if any dependencies here depend on it | ||
| .filter { !it.name.contains("kotlin-stdlib") } | ||
| .map { file -> |
Contributor
Author
There was a problem hiding this comment.
I this this should do the same as the collect function did in groovy here 🤔
This comment was marked as outdated.
This comment was marked as outdated.
oas004
force-pushed
the
feature/permission-lint-kts
branch
2 times, most recently
from
6a4550d to
7b061de
Compare
oas004
force-pushed
the
feature/permission-lint-kts
branch
from
7b061de to
5670636
Compare
Contributor
Author
|
Rebased this with main now, sorry for not attending this PR, but now that Manuel is leaving google (https://twitter.com/manuelvicnt/status/1706651911569420512?t=pkAyynIoguUSvnmjkPlgNg&s=19) is it possible that someone else might give this a review? :) |
bentrengrove
approved these changes
Oct 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up #1578 and relating to #1579
Migrating the
:permissions-lintmodule to Kotlin DSL.I have split up the PR into two commits. The first one prepares the file to be migrated by using steps described in these docs. The second one is where I actually convert the file to .kts file and updates the rest of the file to be compatible with Kotlin DSL.