Repository navigation
Commit d8d8ba5
committed
Ship the release dmg and zip with their notarization stapled (issue gitx#650)
Neither artifact on the releases page carries a stapled ticket, which is
what lets Gatekeeper answer out of the download rather than asking Apple
at first launch. The dmg and the zip were sealed one step before the
stapler ran, and the app it stapled only ever reached a second zip that
nothing uploads.
* Separate exporting the signed app from packaging it, so the two can
sit either side of notarization
* Package the dmg and zip once the app has been stapled, so the ticket
is inside what ships
* Say where the split comes from, since a dmg made ahead of the stapler
carries no ticket whatever is done to the app afterwards
The signing steps only run where the certificate secret exists, so this
cannot be confirmed until it runs on master. The packaging half was
measured locally through the real recipe, on an unrelated stapled
application renamed to GitX.app.1 parent 583def9 commit d8d8ba5
2 files changed
Lines changed: 21 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
188 | 188 | | |
189 | 189 | | |
190 | 190 | | |
191 | | - | |
192 | | - | |
| 191 | + | |
| 192 | + | |
193 | 193 | | |
194 | 194 | | |
195 | 195 | | |
| |||
234 | 234 | | |
235 | 235 | | |
236 | 236 | | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
237 | 247 | | |
238 | 248 | | |
239 | 249 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
| 80 | + | |
80 | 81 | | |
81 | 82 | | |
82 | 83 | | |
| |||
201 | 202 | | |
202 | 203 | | |
203 | 204 | | |
204 | | - | |
| 205 | + | |
205 | 206 | | |
206 | 207 | | |
207 | 208 | | |
208 | 209 | | |
209 | 210 | | |
210 | 211 | | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
211 | 218 | | |
212 | 219 | | |
213 | 220 | | |
| |||
220 | 227 | | |
221 | 228 | | |
222 | 229 | | |
| 230 | + | |
223 | 231 | | |
224 | 232 | | |
225 | 233 | | |
| |||
0 commit comments