Repository navigation
Commit 14b3edd
authored
feat(datetime): support date_bin literal origins for range locality (apache#27135)
## Which issue does this PR close?
Closes apache#26913.
## Rationale for this change
An explicit origin currently prevents `date_bin` from reusing range
partitioning for aggregation, even when its buckets align with every
range split.
## What changes are included in this PR?
Admit non-null literal origins while retaining timezone-less nanosecond
timestamps and positive fixed-duration, month-free strides. A fixed
origin shifts the buckets without changing their nondecreasing behavior.
The existing boundary proof still rejects crossing buckets and
evaluation errors.
## What is the testing strategy for this PR?
SQLLogicTests check plans and results for explicit epoch,
shifted-aligned, and crossing origins. Unit tests cover rejected
arguments, ascending/descending splits, and fail-closed boundary errors.
## Are there any user-facing changes?
More aligned `date_bin` aggregations can avoid a hash shuffle. No
function-result or public API changes.
---
Note: This PR was developed with AI assistance. All changes have been
reviewed, and I take full responsibility for this contribution.1 parent 3b0d0c8 commit 14b3edd
3 files changed
Lines changed: 257 additions & 33 deletions
File tree
- datafusion
- functions/src/datetime
- physical-expr/src
- sqllogictest/test_files
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
281 | 281 | | |
282 | 282 | | |
283 | 283 | | |
284 | | - | |
| 284 | + | |
285 | 285 | | |
286 | 286 | | |
287 | 287 | | |
| |||
291 | 291 | | |
292 | 292 | | |
293 | 293 | | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
294 | 306 | | |
295 | 307 | | |
296 | 308 | | |
| |||
1013 | 1025 | | |
1014 | 1026 | | |
1015 | 1027 | | |
| 1028 | + | |
1016 | 1029 | | |
1017 | 1030 | | |
1018 | 1031 | | |
| |||
1089 | 1102 | | |
1090 | 1103 | | |
1091 | 1104 | | |
1092 | | - | |
| 1105 | + | |
| 1106 | + | |
| 1107 | + | |
| 1108 | + | |
| 1109 | + | |
| 1110 | + | |
| 1111 | + | |
| 1112 | + | |
| 1113 | + | |
| 1114 | + | |
| 1115 | + | |
| 1116 | + | |
| 1117 | + | |
1093 | 1118 | | |
1094 | 1119 | | |
1095 | 1120 | | |
| |||
1101 | 1126 | | |
1102 | 1127 | | |
1103 | 1128 | | |
| 1129 | + | |
1104 | 1130 | | |
1105 | 1131 | | |
1106 | 1132 | | |
| |||
1113 | 1139 | | |
1114 | 1140 | | |
1115 | 1141 | | |
1116 | | - | |
| 1142 | + | |
| 1143 | + | |
| 1144 | + | |
| 1145 | + | |
| 1146 | + | |
| 1147 | + | |
| 1148 | + | |
| 1149 | + | |
1117 | 1150 | | |
1118 | 1151 | | |
1119 | 1152 | | |
| |||
1131 | 1164 | | |
1132 | 1165 | | |
1133 | 1166 | | |
| 1167 | + | |
| 1168 | + | |
| 1169 | + | |
| 1170 | + | |
| 1171 | + | |
| 1172 | + | |
| 1173 | + | |
| 1174 | + | |
| 1175 | + | |
1134 | 1176 | | |
1135 | 1177 | | |
1136 | 1178 | | |
1137 | | - | |
| 1179 | + | |
1138 | 1180 | | |
1139 | 1181 | | |
1140 | | - | |
| 1182 | + | |
1141 | 1183 | | |
1142 | | - | |
1143 | | - | |
1144 | | - | |
1145 | | - | |
1146 | | - | |
1147 | | - | |
| 1184 | + | |
| 1185 | + | |
1148 | 1186 | | |
1149 | 1187 | | |
1150 | 1188 | | |
| 1189 | + | |
| 1190 | + | |
| 1191 | + | |
| 1192 | + | |
| 1193 | + | |
| 1194 | + | |
| 1195 | + | |
| 1196 | + | |
| 1197 | + | |
| 1198 | + | |
| 1199 | + | |
| 1200 | + | |
| 1201 | + | |
| 1202 | + | |
| 1203 | + | |
| 1204 | + | |
| 1205 | + | |
| 1206 | + | |
| 1207 | + | |
| 1208 | + | |
| 1209 | + | |
| 1210 | + | |
| 1211 | + | |
| 1212 | + | |
| 1213 | + | |
| 1214 | + | |
1151 | 1215 | | |
1152 | 1216 | | |
1153 | 1217 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1383 | 1383 | | |
1384 | 1384 | | |
1385 | 1385 | | |
1386 | | - | |
1387 | | - | |
| 1386 | + | |
| 1387 | + | |
1388 | 1388 | | |
1389 | 1389 | | |
1390 | 1390 | | |
| 1391 | + | |
1391 | 1392 | | |
| 1393 | + | |
| 1394 | + | |
| 1395 | + | |
| 1396 | + | |
| 1397 | + | |
| 1398 | + | |
| 1399 | + | |
| 1400 | + | |
| 1401 | + | |
| 1402 | + | |
| 1403 | + | |
| 1404 | + | |
| 1405 | + | |
| 1406 | + | |
1392 | 1407 | | |
1393 | 1408 | | |
1394 | 1409 | | |
1395 | | - | |
1396 | | - | |
1397 | | - | |
1398 | | - | |
1399 | | - | |
1400 | | - | |
1401 | | - | |
1402 | | - | |
| 1410 | + | |
1403 | 1411 | | |
1404 | 1412 | | |
1405 | 1413 | | |
| |||
1417 | 1425 | | |
1418 | 1426 | | |
1419 | 1427 | | |
1420 | | - | |
| 1428 | + | |
1421 | 1429 | | |
1422 | 1430 | | |
1423 | 1431 | | |
| |||
1471 | 1479 | | |
1472 | 1480 | | |
1473 | 1481 | | |
1474 | | - | |
| 1482 | + | |
1475 | 1483 | | |
1476 | 1484 | | |
1477 | 1485 | | |
| |||
1494 | 1502 | | |
1495 | 1503 | | |
1496 | 1504 | | |
| 1505 | + | |
| 1506 | + | |
| 1507 | + | |
| 1508 | + | |
| 1509 | + | |
| 1510 | + | |
| 1511 | + | |
| 1512 | + | |
| 1513 | + | |
| 1514 | + | |
| 1515 | + | |
| 1516 | + | |
| 1517 | + | |
| 1518 | + | |
| 1519 | + | |
| 1520 | + | |
| 1521 | + | |
| 1522 | + | |
| 1523 | + | |
| 1524 | + | |
| 1525 | + | |
| 1526 | + | |
| 1527 | + | |
| 1528 | + | |
| 1529 | + | |
| 1530 | + | |
| 1531 | + | |
| 1532 | + | |
| 1533 | + | |
| 1534 | + | |
| 1535 | + | |
| 1536 | + | |
| 1537 | + | |
| 1538 | + | |
| 1539 | + | |
| 1540 | + | |
| 1541 | + | |
| 1542 | + | |
| 1543 | + | |
| 1544 | + | |
| 1545 | + | |
| 1546 | + | |
| 1547 | + | |
| 1548 | + | |
| 1549 | + | |
| 1550 | + | |
| 1551 | + | |
| 1552 | + | |
| 1553 | + | |
| 1554 | + | |
| 1555 | + | |
| 1556 | + | |
| 1557 | + | |
| 1558 | + | |
| 1559 | + | |
| 1560 | + | |
| 1561 | + | |
| 1562 | + | |
| 1563 | + | |
| 1564 | + | |
| 1565 | + | |
| 1566 | + | |
| 1567 | + | |
| 1568 | + | |
| 1569 | + | |
| 1570 | + | |
| 1571 | + | |
| 1572 | + | |
| 1573 | + | |
| 1574 | + | |
| 1575 | + | |
| 1576 | + | |
| 1577 | + | |
| 1578 | + | |
| 1579 | + | |
| 1580 | + | |
| 1581 | + | |
| 1582 | + | |
| 1583 | + | |
| 1584 | + | |
| 1585 | + | |
| 1586 | + | |
| 1587 | + | |
| 1588 | + | |
| 1589 | + | |
| 1590 | + | |
| 1591 | + | |
| 1592 | + | |
| 1593 | + | |
| 1594 | + | |
| 1595 | + | |
| 1596 | + | |
| 1597 | + | |
| 1598 | + | |
| 1599 | + | |
| 1600 | + | |
1497 | 1601 | | |
1498 | 1602 | | |
1499 | 1603 | | |
| |||
0 commit comments