Configurable key shortcuts #328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
tulir
requested changes
Mar 6, 2022
Member
tulir
left a comment
tulir
left a comment
There was a problem hiding this comment.
By default no shortcuts are mapped.
That doesn't sound very usable. The defaults need to be enabled by default. New shortcuts that are added later should probably also get enabled automatically for existing users, rather than users having to manually update their keybindings file.
The most sensible solution is probably loading the sample config as a base, then loading the user's config on top of that as overrides. The embed package may be useful to compile the sample file into the binary.
prataffel
added a commit
to prataffel/gomuks
that referenced
this pull request
May 28, 2022
This drops the hard-coded shortkeys in favor of the keybindings.yaml file introduced in gomuks#328
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default no shortcuts are mapped.
Previous mappings included as sample (except
qno longer closes modal)Consider as alternative to #325