Add generic notify_xdg.go #312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notification sound playback no longer depends on PulseAudio, so it should run on any Unix-like operating system with libnotify and vorbis-tools.
tulir
approved these changes
Sep 20, 2021
Member
tulir
left a comment
tulir
left a comment
There was a problem hiding this comment.
Looks sensible, but ogg123 doesn't seem to be preinstalled everywhere paplay is, so I'll make it use either depending on which is available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notification sound playback no longer depends on PulseAudio, so it
should run on any Unix operating system with libnotify and
vorbis-tools.
I don't completely understand platform-dependent compilation ingolang, but it works for me.