Skip to content

Implement selection vector partitioning mode for HashAggregate - #3

Closed
goldmedal wants to merge 27 commits into
feat/selection-vector-partitionfrom
feat/zero-copy-hash-agg
Closed

goldmedal wants to merge 27 commits into
feat/selection-vector-partitionfrom
feat/zero-copy-hash-agg

Conversation

@goldmedal

Copy link
Copy Markdown
Owner

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@goldmedal
goldmedal force-pushed the feat/selection-vector-partition branch from b28bf32 to c6b33da Compare March 30, 2025 11:35
Some(Ok(batch)) => {
let timer = elapsed_compute.timer();

let batch = self.filter_by_selection_vector(batch)?;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So instead of this - it should compute the indices and only do work for group_aggregate_batch (I think there need to be some more changes there).

@goldmedal
goldmedal force-pushed the feat/selection-vector-partition branch from c6b33da to d10ec22 Compare April 13, 2025 15:08
@goldmedal goldmedal closed this Apr 20, 2025
goldmedal added a commit that referenced this pull request Jul 18, 2025
* add default_null_ordering config

* add test for different config

* Update datafusion/sql/src/planner.rs

Co-authored-by: Copilot <[email protected]>

* update doc

* fix sqllogictest

---------

Co-authored-by: Copilot <[email protected]>
goldmedal added a commit that referenced this pull request Jul 29, 2025
* add default_null_ordering config

* add test for different config

* Update datafusion/sql/src/planner.rs

Co-authored-by: Copilot <[email protected]>

* update doc

* fix sqllogictest

---------

Co-authored-by: Copilot <[email protected]>
goldmedal added a commit that referenced this pull request Aug 19, 2025
… default null ordering (apache#16963)

* Allow to set up the default null ordering (#3)

* add default_null_ordering config

* add test for different config

* Update datafusion/sql/src/planner.rs

Co-authored-by: Copilot <[email protected]>

* update doc

* fix sqllogictest

---------

Co-authored-by: Copilot <[email protected]>

* rename config and fix test

* update doc

* fix default

* fix doc

* fix sqllogictests

* address comments

---------

Co-authored-by: Copilot <[email protected]>
goldmedal added a commit that referenced this pull request Aug 21, 2025
… default null ordering (apache#16963)

* Allow to set up the default null ordering (#3)

* add default_null_ordering config

* add test for different config

* Update datafusion/sql/src/planner.rs

Co-authored-by: Copilot <[email protected]>

* update doc

* fix sqllogictest

---------

Co-authored-by: Copilot <[email protected]>

* rename config and fix test

* update doc

* fix default

* fix doc

* fix sqllogictests

* address comments

---------

Co-authored-by: Copilot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants