Skip to content

Commit 7384f29

Browse files
authored
Re-ordered plug-in result to be included _after_ chat-history (microsoft#182)
### Motivation and Context <!-- Thank you for your contribution to the copilot-chat repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Customer reported stale plug-in results. Re-ordering prompt to include plug-in results last may impact prioritizing this data for certain cases. (Isolated testing indicates that the model can respond to priority hints via ordering, but other factors may influence model behavior as well...such as chat history or memory presenting stronger semantic context.) ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> Move planner results to after chat-history: ``` [SOURCE START] This is the result of invoking the functions listed after "PLUGINS USED:" to retrieve additional information outside of the data you were trained on. You can use this data to help answer the user's query. PLUGINS USED: ListPluginPlugin.GetList. RESULT: { "content": "eba26d18-b4bb-46d4-b6b6-cbf60d4312e8\n12ed4781-5b22-48a0-b4e9-a351e546e7ff\n90605eb2-51ce-4058-8ae0-dfbe5ed455f7\nf51d2923-f97a-41b8-97d4-991b9f46e260", "contentType": "text/plain" } [SOURCE END] ``` ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [Contribution Guidelines](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
1 parent 56a0356 commit 7384f29

1 file changed

Lines changed: 11 additions & 2 deletions

File tree

‎webapi/Skills/ChatSkills/ChatSkill.cs‎

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -383,10 +383,13 @@ private async Task<ChatMessage> GetChatResponseAsync(string chatId, string userI
383383
var documentMemories = tasks[1];
384384

385385
// Fill in the chat history if there is any token budget left
386-
var chatContextComponents = new List<string>() { chatMemories, documentMemories, planResult };
386+
var chatContextComponents = new List<string>() { chatMemories, documentMemories };
387387
var chatContextText = string.Join("\n\n", chatContextComponents.Where(c => !string.IsNullOrEmpty(c)));
388-
var chatHistoryTokenLimit = remainingToken - TokenUtilities.TokenCount(chatContextText);
388+
var chatHistoryTokenLimit = remainingToken - TokenUtilities.TokenCount(chatContextText) - TokenUtilities.TokenCount(planResult);
389+
389390
string chatHistory = string.Empty;
391+
392+
// Append the chat history, if allowed.
390393
if (chatHistoryTokenLimit > 0)
391394
{
392395
await this.UpdateBotResponseStatusOnClient(chatId, "Extracting chat history");
@@ -395,6 +398,12 @@ private async Task<ChatMessage> GetChatResponseAsync(string chatId, string userI
395398
chatContextText = $"{chatContextText}\n{chatHistory}";
396399
}
397400

401+
// Append the plan result last, if exists, to imply precedence.
402+
if (!string.IsNullOrWhiteSpace(planResult))
403+
{
404+
chatContextText = $"{chatContextText}\n{planResult}";
405+
}
406+
398407
// Set variables needed in prompt
399408
chatContext.Variables.Set("audience", audience);
400409
chatContext.Variables.Set("userIntent", userIntent);

0 commit comments

Comments
 (0)