-
Notifications
You must be signed in to change notification settings - Fork 123
Comparing changes
Open a pull request
base repository: golang/time
base: 5d9ef58
head repository: golang/time
compare: 0c50ed8
- 6 commits
- 4 files changed
- 6 contributors
Commits on Oct 1, 2024
-
x/time/rate: correctly handle 0 limits
Decrementing the burst in the reserveN method will frequently lead to us setting the burst to 0 which makes the limiter mostly unusable. This code was originally added in https://go.dev/cl/323429 to fix #39984 but the implementation introduced a different bug. To avoid regressing to the behaviour described in #39984, pre-fill the limiter to the burst value in the constructor. Fixes #68541 Change-Id: Iab3b85d548a44fcb2d058336e5bbf11b19ea67b1 Reviewed-on: https://go-review.googlesource.com/c/time/+/600876 Reviewed-by: Sameer Ajmani <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Michael Knyszek <[email protected]> Auto-Submit: Sameer Ajmani <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 772484e - Browse repository at this point
Copy the full SHA 772484eView commit details
Commits on Nov 2, 2024
-
README: don't recommend go get
These days people will just import the packages and the go tool will do the right thing. We don't need to explain it. Add a pointer to the git repo, though. For golang/go#62645 Change-Id: I87fbf5d50e75120052f56ed6d4ac9977056cde9f Reviewed-on: https://go-review.googlesource.com/c/time/+/624235 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> Commit-Queue: Ian Lance Taylor <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3846194 - Browse repository at this point
Copy the full SHA 3846194View commit details
Commits on Jan 3, 2025
-
rate: make function comment match function name
Change-Id: I603ca855eac736e90d2ba2bb7ce61981a4a91918 Reviewed-on: https://go-review.googlesource.com/c/time/+/638776 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1ce61fe - Browse repository at this point
Copy the full SHA 1ce61feView commit details
Commits on Jan 8, 2025
-
rate: prevent overflows when calculating durationFromTokens
Currently, there is a conversion from float64 to int64 when returning the duration needed to accumulate the required number of tokens. When limiters are set with low limits, i.e. 1e-10, the duration needed is greater than math.MaxInt64. As per the language specifications, in these scenarios the outcome is implementation determined. This results in overflows on `amd64`, resulting in no wait, effectively jamming the limiter open. Here we add a check for this scenario, returning InfDuration if the desired duration is greater than math.MaxInt64. Fixes golang/go#71154 Change-Id: I775aab80fcc8563a59aa399844a64ef70b9eb76a Reviewed-on: https://go-review.googlesource.com/c/time/+/641336 Reviewed-by: Dmitri Shuralyov <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2c6c5a2 - Browse repository at this point
Copy the full SHA 2c6c5a2View commit details
Commits on Feb 6, 2025
-
rate: simplify function advance only returns new Tokens to caller
Change the advance method to stop returning the newT result, because it is always the same as the t argument. Change-Id: Ib04017715d9f38f4ef6b908cb3d3b09af01b50b7 GitHub-Last-Rev: 1bc7316 GitHub-Pull-Request: #24 Reviewed-on: https://go-review.googlesource.com/c/time/+/645995 Reviewed-by: Ian Lance Taylor <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Cherry Mui <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 66520f6 - Browse repository at this point
Copy the full SHA 66520f6View commit details
Commits on Feb 14, 2025
-
all: upgrade go directive to at least 1.23.0 [generated]
By now Go 1.24.0 has been released, and Go 1.22 is no longer supported per the Go Release Policy (https://go.dev/doc/devel/release#policy). For golang/go#69095. [git-generate] (cd . && go get [email protected] && go mod tidy && go fix ./... && go mod edit -toolchain=none) Change-Id: Iaeb32276091bcf93b9f9ccde96e2705fe6367860 Reviewed-on: https://go-review.googlesource.com/c/time/+/649718 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Cherry Mui <[email protected]> Auto-Submit: Gopher Robot <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0c50ed8 - Browse repository at this point
Copy the full SHA 0c50ed8View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 5d9ef58...0c50ed8