Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/text
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.9.0
Choose a base ref
...
head repository: golang/text
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.13.0
Choose a head ref
  • 10 commits
  • 48 files changed
  • 7 contributors

Commits on Jun 8, 2023

  1. internal/export/idna: fix infinite loop in Go pre-1.10

    lookupString returns 0 for incomplete UTF-8 sequences, so to
    prevent infinite loops we must specifically check for that case.
    However, CL 73730 which fixed this issue in 2017 was lost in the
    shuffle that allowed multiple Unicode versions in x/text (CL 83235),
    and the fix was never applied to idna9.0.0.go.
    
    This CL fixes that oversight.
    
    Updates golang/go#22184
    
    Change-Id: I3a6ab08b157f4017560020ff259d1afbe49a9e71
    Reviewed-on: https://go-review.googlesource.com/c/text/+/361494
    Reviewed-by: Damien Neil <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Run-TryBot: Ian Lance Taylor <[email protected]>
    Reviewed-by: David Chase <[email protected]>
    Reviewed-by: Marcel van Lohuizen <[email protected]>
    TimothyGu authored and neild committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    efb744f View commit details
    Browse the repository at this point in the history
  2. go.mod: delete repeated "indirect"

    It got added by 'go mod tidy' in CL 471399
    because the '; ' separator was missing.
    
    For golang/go#48523.
    For golang/go#58737.
    
    Change-Id: I63642a4f49beb9679f9c5bbb4e2aa8ed0cc73c9e
    Reviewed-on: https://go-review.googlesource.com/c/text/+/501835
    TryBot-Result: Gopher Robot <[email protected]>
    Auto-Submit: Dmitri Shuralyov <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Reviewed-by: Ian Lance Taylor <[email protected]>
    Run-TryBot: Dmitri Shuralyov <[email protected]>
    dmitshur authored and gopherbot committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    d61dd50 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2023

  1. internal/export/idna: make more space for mapping index

    This prepares for an upcoming Unicode upgrade.
    
    Beyond Unicode 13 the size of mappings will grow beyond
    what can be represented in the allocated 13 bits. Instread
    of doubling the size of info, we introduce a table of indices
    into the mappings data. This also allows us to remove the
    length byte, reducing the overhead of introducing this new
    table.
    
    This change allows for about a 5x growth of the number
    of mappings, which should suffice for the foreseeable
    future.
    
    Change-Id: Id475dc2473145a1f36bd83b983fa4aa170df6206
    Reviewed-on: https://go-review.googlesource.com/c/text/+/501515
    Run-TryBot: Ian Lance Taylor <[email protected]>
    Reviewed-by: David Chase <[email protected]>
    Reviewed-by: Ian Lance Taylor <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    mpvl authored and rsc committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    3a7a255 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. all: prepare for Unicode 15.0.0

    internal/gen has never been updated for Go 1.17's //go:build tags.
    Do that, and add the entry for Unicode 15.0.0.
    
    Unicode 15.0.0 will change 9fff to be a CJK ideograph, which will
    break the unicode/runenames example test.
    Delete that part of the example.
    
    For golang/go#55079.
    
    Change-Id: I12b0c6d031d6d6e1970c8fe6eb5453fa64c9f365
    Reviewed-on: https://go-review.googlesource.com/c/text/+/503035
    Run-TryBot: Russ Cox <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: David Chase <[email protected]>
    Auto-Submit: Russ Cox <[email protected]>
    rsc authored and gopherbot committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    e3c038a View commit details
    Browse the repository at this point in the history
  2. all: regenerate for Unicode 15.0.0

    go generate ./...
    
    This CL only contains the changes made by go generate ./...
    
    For golang/go#55079.
    
    Change-Id: I840205f9046e6ccaab370b1dc5393aaf02d5fcb2
    Reviewed-on: https://go-review.googlesource.com/c/text/+/503036
    Run-TryBot: Russ Cox <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: David Chase <[email protected]>
    Auto-Submit: Russ Cox <[email protected]>
    rsc authored and gopherbot committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    2df65d7 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2023

  1. encoding/japanese, language: shorten very long sub-test names

    Some of the generated sub-test names end up being excessively long,
    which doesn't mix well with them being stored as test IDs that track
    test runs over time. Replacing test case names with numbers harms
    their readability, so start by trimming a few that end up being 500+
    bytes in length.
    
    Change-Id: Id3b22105efc08eb1bb51436aa257682d357d662c
    Reviewed-on: https://go-review.googlesource.com/c/text/+/506416
    TryBot-Result: Gopher Robot <[email protected]>
    Run-TryBot: Dmitri Shuralyov <[email protected]>
    Auto-Submit: Dmitri Shuralyov <[email protected]>
    Reviewed-by: Heschi Kreinick <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    dmitshur authored and gopherbot committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    e503480 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. all: remove repetitive words

    Change-Id: I496265fcad6dee919eff6fc1fbcf9121ae61730f
    Reviewed-on: https://go-review.googlesource.com/c/text/+/509855
    Reviewed-by: Ian Lance Taylor <[email protected]>
    Run-TryBot: Ian Lance Taylor <[email protected]>
    Reviewed-by: Heschi Kreinick <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Auto-Submit: Ian Lance Taylor <[email protected]>
    cuishuang authored and gopherbot committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    ab07ad1 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. cmd/gotext: fix misbehaviors

    The existing implementation has misbehaviors described in golang/go#56842:
    
    - `gotext extract` ignores `lang` flag
    - `gotext generate` ignores `out` flag
    - Misbehavior of `gotext generate` when no flag specified
    
    This commit fixes these bugs:
    
    - Update `Command.UsageLine` for `cmdGenerate`
    - Fix flag misbehaviors by encapsuling flag definition statements into individual `Command.Init()` functions of commands
    - Fix `gotext generate` misbehavior by executing `pipeline.State.Merge()` before `pipeline.State.Generate()`
    
    Fixes golang/go#56842
    
    Change-Id: Id5e324b573b2b389bec22181482a97445230d0cc
    Reviewed-on: https://go-review.googlesource.com/c/text/+/452115
    Auto-Submit: Dmitri Shuralyov <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Heschi Kreinick <[email protected]>
    Reviewed-by: Marcel van Lohuizen <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Run-TryBot: Dmitri Shuralyov <[email protected]>
    ilharp authored and gopherbot committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    f3e69ed View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. cmd/gotext: actually use -dir flag

    gotext has the read -dir flag but is not used.
    The dir parameter should be passed to pipeline.Config
    
    Fixes golang/go#61507
    
    Change-Id: I242a768964fe56c4c7877de9dc487777c6815dae
    Reviewed-on: https://go-review.googlesource.com/c/text/+/512015
    Auto-Submit: Ian Lance Taylor <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Heschi Kreinick <[email protected]>
    Run-TryBot: Ian Lance Taylor <[email protected]>
    Reviewed-by: Ian Lance Taylor <[email protected]>
    Run-TryBot: Ian Lance Taylor <[email protected]>
    miilord authored and gopherbot committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    fb697c0 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. unicode/norm: fix function name on comment

    Change-Id: I1d7daf1101c289f99367db2b23105e99d7e19b65
    Reviewed-on: https://go-review.googlesource.com/c/text/+/523255
    Run-TryBot: shuang cui <[email protected]>
    Reviewed-by: Ian Lance Taylor <[email protected]>
    Run-TryBot: Ian Lance Taylor <[email protected]>
    Reviewed-by: Joedian Reid <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Auto-Submit: Ian Lance Taylor <[email protected]>
    cuishuang authored and gopherbot committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    f488e19 View commit details
    Browse the repository at this point in the history
Loading