Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/text
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.18.0
Choose a base ref
...
head repository: golang/text
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.20.0
Choose a head ref
  • 7 commits
  • 33 files changed
  • 5 contributors

Commits on Sep 4, 2024

  1. all: fix printf(var) mistakes detected by latest printf checker

    The CodeWriter.WriteComment method is odd. It calls fmt.Sprintf
    on its arguments so the caller doesn't need to, but isn't named
    something like WriteCommentf as I'd expect. I tried renaming it,
    but it became a bigger change than I wanted. Leaving that for a
    future CL - this one just fixes clear mistakes to fix the build.
    
    For golang/go#69267.
    
    Change-Id: Ifba42d4512696194fbf21d6c8d3da76440b1ce9e
    Reviewed-on: https://go-review.googlesource.com/c/text/+/610676
    Reviewed-by: Tim King <[email protected]>
    Reviewed-by: Ian Lance Taylor <[email protected]>
    Auto-Submit: Dmitri Shuralyov <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    dmitshur authored and gopherbot committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    20097e4 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. all: fix some comments

    Change-Id: I6ba7a9de50acfa522d96609abead28d207ab4f81
    Reviewed-on: https://go-review.googlesource.com/c/text/+/611795
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Reviewed-by: Tim King <[email protected]>
    Auto-Submit: Tim King <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    cuishuang authored and gopherbot committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    38a95c2 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. x/text: Correct examples in number/doc

    Playground example: https://go.dev/play/p/9cuRyaNveO8
    
    Change-Id: I2fbc3fec0f3755eb3d11b47edfb2201d66fc622d
    Reviewed-on: https://go-review.googlesource.com/c/text/+/614395
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Auto-Submit: Ian Lance Taylor <[email protected]>
    Reviewed-by: Marcel van Lohuizen <[email protected]>
    Reviewed-by: Ian Lance Taylor <[email protected]>
    Reviewed-by: Carlos Amedee <[email protected]>
    dveeden authored and gopherbot committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    3043346 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. all: normalize subtest names to NFC

    LUCI builders upload test results to ResultDB, which permits printable
    Unicode characters in test names, provided they're written in NFC form.
    
    Change-Id: I0abf67beb52da722af97e6981c308c4b4d801cbb
    Reviewed-on: https://go-review.googlesource.com/c/text/+/621555
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: Michael Pratt <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Auto-Submit: Dmitri Shuralyov <[email protected]>
    dmitshur authored and gopherbot committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    a457f47 View commit details
    Browse the repository at this point in the history
  2. internal/texttest: remove Run and Bench helpers

    Versions of Go whose testing package doesn't yet support subtests and
    sub-benchmarks are no longer supported. Drop an intermediate layer of
    compatibility from the ./internal/texttest package.
    
    The initial version of this change was git-generate'd with the script:
    
    rm internal/testtext/go1_{6,7}.go
    gofmt -r 'testtext.Run(t, n, f) -> t.Run(n, f)' -w .
    gofmt -r 'testtext.Bench(b, n, f) -> b.Run(n, f)' -w .
    goimports -w .
    
    Unfortunately it seems gofmt -r dropped inner comments inside f, and
    also added some spurious blank lines. So it was manually amended not
    to include those changes.
    
    Change-Id: I5bcb553b90ce392aada7896d576194be479f2616
    Reviewed-on: https://go-review.googlesource.com/c/text/+/621575
    Auto-Submit: Dmitri Shuralyov <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: Michael Pratt <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    dmitshur authored and gopherbot committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    fefda1a View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2024

  1. README: don't recommend go get

    These days people will just import the packages and the go tool will
    do the right thing. We don't need to explain it.
    
    Add a pointer to the git repo, though.
    
    For golang/go#62645
    
    Change-Id: I0a1721eb456645c1422580497e3dcc9906a41223
    Reviewed-on: https://go-review.googlesource.com/c/text/+/624296
    Auto-Submit: Ian Lance Taylor <[email protected]>
    Reviewed-by: Ian Lance Taylor <[email protected]>
    Commit-Queue: Ian Lance Taylor <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    ianlancetaylor authored and gopherbot committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    8a0e65e View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. go.mod: update golang.org/x dependencies

    Update golang.org/x dependencies to their latest tagged versions.
    
    Change-Id: I6b939f9a4f016b265d30fbd408f34705f89c0982
    Reviewed-on: https://go-review.googlesource.com/c/text/+/626375
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Reviewed-by: David Chase <[email protected]>
    Auto-Submit: Gopher Robot <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    gopherbot committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    efd25da View commit details
    Browse the repository at this point in the history
Loading