Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/text
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f488e19
Choose a base ref
...
head repository: golang/text
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b2bec85
Choose a head ref
  • 7 commits
  • 142 files changed
  • 7 contributors

Commits on Oct 11, 2023

  1. all: update go directive to 1.18

    Done with:
    
    go get [email protected]
    go mod tidy
    go fix ./...
    
    Using go1.21.3.
    
    Also update code generators to use only the new go:build lines,
    not the old +build ones.
    
    For golang/go#60268.
    
    Change-Id: I832981d939ab0aad5c941555a6a4cd005958a189
    Reviewed-on: https://go-review.googlesource.com/c/text/+/534242
    Reviewed-by: Damien Neil <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Auto-Submit: Dmitri Shuralyov <[email protected]>
    dmitshur authored and gopherbot committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    6c97a16 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. encoding/charmap: update UCM spec file URL prefix

    UCM spec files used by encoding/maketables.go moved from
    source.icu-project.org to github.com, and maketables is failing.
    
    The new repo is at
    https://github.com/unicode-org/icu-data/tree/main/charset/data/ucm.
    
    Changed all UCM mappings to use the "raw endpoint" prefix,
    https://raw.githubusercontent.com/unicode-org/icu-data/main/charset/data/ucm/….
    
    Fixes golang/go#64504.
    
    Change-Id: Ib2ccf948ad79578efc4a0c356bb25325190dc333
    GitHub-Last-Rev: 2a277c7
    GitHub-Pull-Request: #48
    Reviewed-on: https://go-review.googlesource.com/c/text/+/546576
    Reviewed-by: Cherry Mui <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Reviewed-by: Dominik Honnef <[email protected]>
    zacharysyoung authored and dominikh committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    8d533a0 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. x/text: update x/tools for go/ssa range-over-func fix

    CL 584295 added a quick fix to a panic in go/ssa when it
    encounters range-over-func. This CL imports that fix.
    A principled fix will land in CL 555075.
    
    Fixes golang/go#67348
    
    Change-Id: I49dd63d4845d0fc804b6e7d0353584a57aea19fc
    Reviewed-on: https://go-review.googlesource.com/c/text/+/584977
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    adonovan committed May 13, 2024
    Configuration menu
    Copy the full SHA
    a20a3e2 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. message: optimize lookupAndFormat function for better performance

    This commit optimizes the lookupAndFormat function to reduce code redundancy
    and improve performance. Benchmarks show a significant performance increase
    across various Sprintf and Fprint functions.
    
    benchstat old.txt new.txt
    goos: darwin
    goarch: arm64
    pkg: golang.org/x/text/message
                             │   old.txt   │               new.txt               │
                             │   sec/op    │   sec/op     vs base                │
    SprintfPadding-12          333.0n ± 1%   216.0n ± 1%  -35.15% (p=0.000 n=10)
    SprintfEmpty-12            307.3n ± 1%   170.9n ± 1%  -44.38% (p=0.000 n=10)
    SprintfString-12           313.5n ± 1%   178.9n ± 2%  -42.91% (p=0.000 n=10)
    SprintfTruncateString-12   315.6n ± 1%   182.3n ± 2%  -42.23% (p=0.000 n=10)
    SprintfQuoteString-12      320.1n ± 0%   198.6n ± 1%  -37.96% (p=0.000 n=10)
    SprintfInt-12              325.0n ± 1%   203.1n ± 1%  -37.51% (p=0.000 n=10)
    SprintfIntInt-12           340.2n ± 1%   233.2n ± 2%  -31.47% (p=0.000 n=10)
    SprintfPrefixedInt-12      335.2n ± 1%   226.2n ± 1%  -32.54% (p=0.000 n=10)
    SprintfFloat-12            330.1n ± 1%   209.7n ± 1%  -36.48% (p=0.000 n=10)
    SprintfComplex-12          365.1n ± 1%   276.0n ± 2%  -24.41% (p=0.000 n=10)
    SprintfBoolean-12          311.8n ± 0%   178.6n ± 3%  -42.72% (p=0.000 n=10)
    SprintfHexString-12        328.1n ± 1%   204.8n ± 2%  -37.56% (p=0.000 n=10)
    SprintfHexBytes-12         334.0n ± 2%   216.4n ± 1%  -35.20% (p=0.000 n=10)
    SprintfBytes-12            340.8n ± 7%   213.9n ± 1%  -37.25% (p=0.000 n=10)
    SprintfStringer-12         662.5n ± 3%   453.2n ± 1%  -31.59% (p=0.000 n=10)
    SprintfStructure-12        373.8n ± 6%   275.7n ± 1%  -26.23% (p=0.000 n=10)
    ManyArgs-12                485.1n ± 4%   425.4n ± 1%  -12.30% (p=0.000 n=10)
    FprintInt-12               265.8n ± 2%   262.0n ± 1%   -1.41% (p=0.011 n=10)
    FprintfBytes-12            348.4n ± 1%   258.8n ± 1%  -25.70% (p=0.000 n=10)
    FprintIntNoAlloc-12        262.0n ± 2%   261.2n ± 2%        ~ (p=0.565 n=10)
    geomean                    342.4n        233.7n       -31.75%
    
    Change-Id: Id9999469f3fd0ca0290a5cb81f42fff81277b451
    GitHub-Last-Rev: 904d624
    GitHub-Pull-Request: #51
    Reviewed-on: https://go-review.googlesource.com/c/text/+/584095
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Reviewed-by: Marcel van Lohuizen <[email protected]>
    Auto-Submit: Ian Lance Taylor <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: Ian Lance Taylor <[email protected]>
    aimuz authored and gopherbot committed May 14, 2024
    Configuration menu
    Copy the full SHA
    59e1219 View commit details
    Browse the repository at this point in the history
  2. cmd/gotext: fix segfault in extract & rewrite commands

    If extract or rewrite are called with no arguments it results in a
    segmentation fault, since we dereference the out flag that was
    not defined for these commands.
    
    Fixes golang/go#62697
    
    Change-Id: I697943b7c221431d0361bcec74c18183f6e141ea
    GitHub-Last-Rev: 313ddfa
    GitHub-Pull-Request: #46
    Reviewed-on: https://go-review.googlesource.com/c/text/+/529255
    Reviewed-by: Marcel van Lohuizen <[email protected]>
    Auto-Submit: Ian Lance Taylor <[email protected]>
    Reviewed-by: Ian Lance Taylor <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    mauri870 authored and gopherbot committed May 14, 2024
    Configuration menu
    Copy the full SHA
    9c2f3a2 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. LICENSE: update per Google Legal

    Very minor tweaks:
     - Remove (c) pseudosymbol.
     - Remove "All Rights Reserved."
     - Change "Google Inc." (no longer exists) to "Google LLC".
    
    [git-generate]
    echo '
    ,s/\(c\) //
    ,s/ All rights reserved.//
    ,s/Google Inc./Google LLC/
    w
    q
    ' | sam -d LICENSE
    
    Change-Id: I5c4495c11ac39e1361c3d370a7ceda78459cc089
    Reviewed-on: https://go-review.googlesource.com/c/text/+/598587
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: Ian Lance Taylor <[email protected]>
    Auto-Submit: Russ Cox <[email protected]>
    rsc authored and gopherbot committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    ae0cf96 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. go.mod: update golang.org/x dependencies

    Update golang.org/x dependencies to their latest tagged versions.
    
    Change-Id: I136532b352871ee714a4ccba9671a370a8abdd95
    Reviewed-on: https://go-review.googlesource.com/c/text/+/602518
    Auto-Submit: Gopher Robot <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Reviewed-by: David Chase <[email protected]>
    gopherbot committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    b2bec85 View commit details
    Browse the repository at this point in the history
Loading