unix: remove extra trailing newlines in zsyscall_openbsd_*.go#183

Closed

jrick wants to merge 1 commit intogolang:masterfrom

jrick:mksyscall_gofmt

Contributor

jrick commented Dec 20, 2023 •

edited

Loading

These newlines are written by mksyscall.go but should not appear in the final
generated files once the output is passed through gofmt. This is done by
mkall.sh but I had written a custom script just to generate these openbsd
zsyscall files in CL 468095.

Running the mksyscall.go output through gofmt fixes this issue.

Fixes golang/go#64820


          unix: remove extra trailing newlines in zsyscall_openbsd_*.go

514272b

These newlines are written by mksyscall.go but should not appear in the final
generated files once the output is passed through gofmt.  This is done by
mkall.sh but I had written a custom script just to generate these openbsd
zsyscall files in CL 468095.

Running the mksyscall.go output through gofmt fixes this issue.

Fixes golang/go#64820

Contributor

gopherbot commented Dec 20, 2023

This PR (HEAD: 514272b) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/sys/+/551715.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Contributor

gopherbot commented Dec 20, 2023

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Dec 20, 2023

Message from Josh Rickmar:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Dec 20, 2023

Message from Jorropo:

Patch Set 2: Commit-Queue+1 Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Dec 20, 2023

Message from Jorropo:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Dec 20, 2023

Message from Go LUCI:

Patch Set 2:

CV cannot start a Run for [email protected] because the user is neither the CL owner nor a committer.

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Dec 20, 2023

Message from Gopher Robot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Dec 20, 2023

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Dec 20, 2023

Message from Jorropo:

Patch Set 2: Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Dec 20, 2023

Message from Jorropo:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Dec 20, 2023

Message from Go LUCI:

Patch Set 2:

CV cannot start a Run for [email protected] because the user is neither the CL owner nor a committer.

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Dec 20, 2023

Message from Jorropo:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Dec 20, 2023

Message from Josh Rickmar:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Dec 20, 2023

Message from Than McIntosh:

Patch Set 2: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Dec 20, 2023

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2023-12-20T14:58:57Z","revision":"54ecbc5e886843ce3bf2b5429d0c46705924fe0e"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Dec 20, 2023

Message from Josh Rickmar:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Dec 20, 2023

Message from Gopher Robot:

Patch Set 2: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Dec 20, 2023

Message from Than McIntosh:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Dec 20, 2023

Message from Than McIntosh:

Patch Set 2: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Dec 20, 2023

Message from Than McIntosh:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Dec 20, 2023

Message from Go LUCI:

Patch Set 2:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Dec 20, 2023

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Dec 20, 2023

Message from Jorropo:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Dec 20, 2023

Message from Tobias Klauser:

Patch Set 2: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Dec 21, 2023

Message from Carlos Amedee:

Patch Set 2: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/551715.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          unix: remove extra trailing newlines in zsyscall_openbsd_*.go

f0c7190

These newlines are written by mksyscall.go but should not appear in the final
generated files once the output is passed through gofmt.  This is done by
mkall.sh but I had written a custom script just to generate these openbsd
zsyscall files in CL 468095.

Running the mksyscall.go output through gofmt fixes this issue.

Fixes golang/go#64820

Change-Id: I1b1bf55145bd5a5208e091ded24a973f953c479f
GitHub-Last-Rev: 514272b
GitHub-Pull-Request: #183
Reviewed-on: https://go-review.googlesource.com/c/sys/+/551715
Reviewed-by: Tobias Klauser <[email protected]>
Reviewed-by: Carlos Amedee <[email protected]>
Run-TryBot: Jorropo <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Than McIntosh <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>

Contributor

gopherbot commented Dec 21, 2023

This PR is being closed because golang.org/cl/551715 has been merged.

gopherbot closed this

jrick deleted the mksyscall_gofmt branch

December 21, 2023 17:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet