Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/sync
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 036812b
Choose a base ref
...
head repository: golang/sync
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 8fcdb60
Choose a head ref
  • 7 commits
  • 6 files changed
  • 6 contributors

Commits on May 13, 2022

  1. x/sync/errgroup: add TryGo and SetLimit to control concurrency

    This benchmark shows the difference between two implementations.
    Using explicit waiter with mutex (old, before PS3) or channel (new,
    since PS4). There is no significant difference at a measure:
    
    name  old time/op    new time/op    delta
    Go-8     247ns ±10%     245ns ±10%     ~     (p=0.571 n=5+10)
    
    name  old alloc/op   new alloc/op   delta
    Go-8     48.0B ± 0%     40.0B ± 0%  -16.67%  (p=0.000 n=5+10)
    
    name  old allocs/op  new allocs/op  delta
    Go-8      2.00 ± 0%      2.00 ± 0%     ~     (all equal)
    
    Fixes golang/go#27837
    
    Change-Id: I60247f1a2a1cdce2b180f10b409e37de8b82341e
    Reviewed-on: https://go-review.googlesource.com/c/sync/+/405174
    Reviewed-by: Bryan Mills <[email protected]>
    Reviewed-by: Heschi Kreinick <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Run-TryBot: Changkun Ou <[email protected]>
    Auto-Submit: Bryan Mills <[email protected]>
    changkun authored and gopherbot committed May 13, 2022
    Configuration menu
    Copy the full SHA
    0976fa6 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2022

  1. x/sync/errgroup: make note of the default errgroup goroutine limit (u…

    …nlimited)
    
    Change-Id: I1926e6faf821a7adb6c1365d18432abb0f856367
    Reviewed-on: https://go-review.googlesource.com/c/sync/+/409774
    Run-TryBot: Bryan Mills <[email protected]>
    Reviewed-by: Bryan Mills <[email protected]>
    Reviewed-by: Changkun Ou <[email protected]>
    Run-TryBot: Changkun Ou <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    jeanbza committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    0de741c View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2022

  1. A+C: delete AUTHORS and CONTRIBUTORS

    In 2009, Google's open-source lawyers asked us to create the AUTHORS
    file to define "The Go Authors", and the CONTRIBUTORS file was in
    keeping with open source best practices of the time.
    
    Re-reviewing our repos now in 2022, the open-source lawyers are
    comfortable with source control history taking the place of the
    AUTHORS file, and most open source projects no longer maintain
    CONTRIBUTORS files.
    
    To ease maintenance, remove AUTHORS and CONTRIBUTORS from all repos.
    
    For golang/go#53961.
    
    Change-Id: I182181f0c116a7218ad9aba1c7a645fe0190762a
    Reviewed-on: https://go-review.googlesource.com/c/sync/+/418922
    Reviewed-by: David Chase <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Run-TryBot: Russ Cox <[email protected]>
    rsc committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    886fb93 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2022

  1. x/sync/errgroup: clarify docs for Go

    Even thought Go cancels the context in g, if it's not nil, it'll call
    any subsequent function, regardless if a previous call of f returned an error or not.
    
    Fixes golang/go#54045
    
    Change-Id: Ie6059925f45458cf393bf1fc8949ce16be8e6f2a
    Reviewed-on: https://go-review.googlesource.com/c/sync/+/424634
    TryBot-Result: Gopher Robot <[email protected]>
    Auto-Submit: Bryan Mills <[email protected]>
    Run-TryBot: Bryan Mills <[email protected]>
    Reviewed-by: Bryan Mills <[email protected]>
    Reviewed-by: Ian Lance Taylor <[email protected]>
    AndersonQ authored and gopherbot committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    7fc1605 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. syncmap: remove redundant type conversion

    Change-Id: I32c367338e1ea95aaaaa8e891f5dfe4ab6c03913
    GitHub-Last-Rev: a2b25df
    GitHub-Pull-Request: #18
    Reviewed-on: https://go-review.googlesource.com/c/sync/+/429058
    TryBot-Result: Gopher Robot <[email protected]>
    Run-TryBot: Bryan Mills <[email protected]>
    Reviewed-by: Michael Knyszek <[email protected]>
    Auto-Submit: Bryan Mills <[email protected]>
    Reviewed-by: Bryan Mills <[email protected]>
    cuishuang authored and gopherbot committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    f12130a View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2022

  1. singleflight: remove forgotten field

    Port from CL 433315.
    
    Change-Id: Iaf6ab4676dd10a73443c3c9981ffc77233b4631c
    Reviewed-on: https://go-review.googlesource.com/c/sync/+/433555
    Reviewed-by: Bryan Mills <[email protected]>
    Run-TryBot: Cuong Manh Le <[email protected]>
    Auto-Submit: Cuong Manh Le <[email protected]>
    Reviewed-by: Cherry Mui <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    cuonglm authored and gopherbot committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    7f9b162 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2022

  1. singleflight: avoid race between multiple Do calls

    This is port of CL 436437, but without the test. ForgotUnshared has not
    been ported here yet.
    
    Change-Id: Id54d0c41d1a7948bf008e458c44b21670ada81e4
    Reviewed-on: https://go-review.googlesource.com/c/sync/+/436495
    Run-TryBot: Cuong Manh Le <[email protected]>
    Reviewed-by: Bryan Mills <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Auto-Submit: Cuong Manh Le <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    cuonglm authored and gopherbot committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    8fcdb60 View commit details
    Browse the repository at this point in the history
Loading