-
Notifications
You must be signed in to change notification settings - Fork 1k
google/externalaccount: moves externalaccount package out of internal and exports it #690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR (HEAD: 82aa92e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/550835. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/550835. |
|
Message from Chris Smith: Patch Set 2: (13 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/550835. |
|
This PR (HEAD: 0d06665) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/550835. Important tips:
|
|
This PR (HEAD: 85ffd02) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/550835. Important tips:
|
|
Message from Alex Eitzman: Patch Set 5: (13 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/550835. |
|
This PR (HEAD: c1ac924) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/550835. Important tips:
|
|
Message from Leo Siracusa: Patch Set 6: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/550835. |
|
This PR (HEAD: c22d2a1) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/550835. Important tips:
|
|
Message from Alex Eitzman: Patch Set 7: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/550835. |
|
Message from Leo Siracusa: Patch Set 7: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/550835. |
|
This PR (HEAD: 7eef773) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/550835. Important tips:
|
|
Message from Chris Smith: Patch Set 8: (7 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/550835. |
|
This PR (HEAD: e15136c) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/550835. Important tips:
|
|
Message from Alex Eitzman: Patch Set 9: (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/550835. |
|
This PR (HEAD: fc72581) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/550835. Important tips:
|
|
Message from Chris Smith: Patch Set 10: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/550835. |
|
Message from Alex Eitzman: Patch Set 10: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/550835. |
|
Message from Chris Smith: Patch Set 22: (11 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/550835. |
|
This PR (HEAD: 362176f) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/550835. Important tips:
|
|
This PR (HEAD: ac519b2) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/550835. Important tips:
|
|
Message from Alex Eitzman: Patch Set 23: (11 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/550835. |
|
Message from Chris Smith: Patch Set 24: Code-Review+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/550835. |
|
Message from Cody Oss: Patch Set 24: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/550835. |
|
Message from Gopher Robot: Patch Set 24: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/550835. |
|
Message from Cody Oss: Patch Set 24: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/550835. |
|
Message from Gopher Robot: Patch Set 24: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/550835. |
|
Message from Alex Eitzman: Patch Set 25: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/550835. |
|
Message from Alex Eitzman: Patch Set 25: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/550835. |
|
Message from Alex Eitzman: Patch Set 25: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/550835. |
|
Message from Cody Oss: Patch Set 25: Auto-Submit+1 Code-Review+2 Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/550835. |
|
Message from Cody Oss: Patch Set 25: -Auto-Submit -Run-TryBot Please don’t reply on this GitHub thread. Visit golang.org/cl/550835. |
|
Message from Cody Oss: Patch Set 25: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/550835. |
|
Message from Cody Oss: Patch Set 25: -Run-TryBot Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/550835. |
|
Message from Go LUCI: Patch Set 25: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-02-27T20:48:02Z","revision":"481dd9eba5f60ee7d4e4bf0f145bf66855d25611"} Please don’t reply on this GitHub thread. Visit golang.org/cl/550835. |
|
Message from Cody Oss: Patch Set 25: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/550835. |
|
Message from Go LUCI: Patch Set 25: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/550835. |
|
Message from Go LUCI: Patch Set 25: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/550835. |
|
This PR is being closed because golang.org/cl/550835 has been merged. |
… and exports it go/programmable-auth-design for context. Adds support for user defined supplier methods to return subject tokens and AWS security credentials. Change-Id: I7bc41f8c5202ae933fce516632f5049bbeb3d378 GitHub-Last-Rev: ac519b2 GitHub-Pull-Request: #690 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/550835 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Leo Siracusa <[email protected]> Reviewed-by: Chris Smith <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Cody Oss <[email protected]>
* google: add UniverseDomain to CredentialsParams Change-Id: I7925b8341e1f047d0115acd7a01a34679a489ee0 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/552716 Reviewed-by: Cody Oss <[email protected]> Run-TryBot: Cody Oss <[email protected]> Reviewed-by: Viacheslav Rostovtsev <[email protected]> TryBot-Result: Gopher Robot <[email protected]> * google: add Credentials.GetUniverseDomain with GCE MDS support * Deprecate Credentials.UniverseDomain Change-Id: I1cbc842fbfce35540c8dff99fec09e036b9e2cdf Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/554215 TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Cody Oss <[email protected]> Auto-Submit: Cody Oss <[email protected]> Reviewed-by: Cody Oss <[email protected]> Reviewed-by: Viacheslav Rostovtsev <[email protected]> * go.mod: update golang.org/x dependencies Update golang.org/x dependencies to their latest tagged versions. Change-Id: Icf68cb33585a13df206afacdb79832ea76f82346 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/554676 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Than McIntosh <[email protected]> Auto-Submit: Gopher Robot <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> * google/downscope: add DownscopingConfig.UniverseDomain to support TPC Change-Id: I3669352b382414ea640ca176afa4071995fc5ff1 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/557135 Reviewed-by: Cody Oss <[email protected]> TryBot-Bypass: Cody Oss <[email protected]> Auto-Submit: Cody Oss <[email protected]> * google/internal/externalaccount: update serviceAccountImpersonationRE to support universe domain Change-Id: Iafe35c293209bd88997c876341ebde7ac9ecda93 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/557195 TryBot-Bypass: Cody Oss <[email protected]> Reviewed-by: Cody Oss <[email protected]> Auto-Submit: Cody Oss <[email protected]> * go.mod: update golang.org/x dependencies Update golang.org/x dependencies to their latest tagged versions. Change-Id: I8228a126b322fb14250bbb5933199ce45e8584d3 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/562496 Reviewed-by: Than McIntosh <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Auto-Submit: Gopher Robot <[email protected]> * google/externalaccount: moves externalaccount package out of internal and exports it go/programmable-auth-design for context. Adds support for user defined supplier methods to return subject tokens and AWS security credentials. Change-Id: I7bc41f8c5202ae933fce516632f5049bbeb3d378 GitHub-Last-Rev: ac519b2 GitHub-Pull-Request: golang#690 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/550835 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Leo Siracusa <[email protected]> Reviewed-by: Chris Smith <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Cody Oss <[email protected]> * google/externalaccount: add Config.UniverseDomain Change-Id: Ia1caee246da68c01addd06e1367ed1e43645826b Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/568216 Reviewed-by: Alex Eitzman <[email protected]> Reviewed-by: Cody Oss <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> * go.mod: update golang.org/x dependencies Update golang.org/x dependencies to their latest tagged versions. Change-Id: I993c77edbea8426f558ab84c4ba769e0bdf6406d Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/568935 Reviewed-by: Than McIntosh <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Gopher Robot <[email protected]> Reviewed-by: Michael Knyszek <[email protected]> --------- Co-authored-by: Chris Smith <[email protected]> Co-authored-by: Gopher Robot <[email protected]> Co-authored-by: aeitzman <[email protected]>
… and exports it go/programmable-auth-design for context. Adds support for user defined supplier methods to return subject tokens and AWS security credentials. Change-Id: I7bc41f8c5202ae933fce516632f5049bbeb3d378 GitHub-Last-Rev: ac519b2 GitHub-Pull-Request: golang#690 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/550835 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Leo Siracusa <[email protected]> Reviewed-by: Chris Smith <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Cody Oss <[email protected]>
go/programmable-auth-design for context. Adds support for user defined
supplier methods to return subject tokens and AWS security credentials.