Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/net
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.54.0
Choose a base ref
...
head repository: golang/net
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.55.0
Choose a head ref
  • 10 commits
  • 24 files changed
  • 4 contributors

Commits on May 8, 2026

  1. http2: avoid API changes when built with go1.27

    The wrapping implementation accidentally dropped some symbols.
    Preserve them.
    
    Move errors into common locations:
      - ErrNoCachedConn
      - ErrPushLimitReached
      - ErrRecursivePush
      - GoAwayError
    
    Move one constant into a common location:
      - TrailerPrefix
    
    Preserve methods of FrameWriteRequest as no-ops.
    These are not a user-serviceable part and there is no way
    for users to construct FrameWriteRequests.
      - FrameWriteRequest.Consume
      - FrameWriteRequest.DataSize
      - FrameWriteRequest.StreamID
      - FrameWriteRequest.String
    
    Preserve functions which create write schedulers,
    returning a no-op implementation of WriteScheduler:
    - NewPriorityWriteScheduler
    - NewRandomWriteScheduler
    - PriorityWriteSchedulerConfig
    
    For golang/go#78508
    
    Change-Id: I327603137cf69d93bb405d9a95e038886a6a6964
    Reviewed-on: https://go-review.googlesource.com/c/net/+/776180
    LUCI-TryBot-Result: [email protected] <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    neild committed May 8, 2026
    Configuration menu
    Copy the full SHA
    23ee2ef View commit details
    Browse the repository at this point in the history

Commits on May 9, 2026

  1. quic: fix buffer slicing when handling overlapping stream data

    When processing a STREAM frame that overlaps with already received data,
    our slicing calculation is wrong. As a result, upon receiving duplicate
    data, such as when packets are retransmitted, we end up writing the same
    data multiple times rather than deduplicating them. This seems to have
    resulted in spurious FINAL_SIZE_ERROR in our tests.
    
    For golang/go#78737
    
    Change-Id: I0c6d34d7f7f376310dad43983cbdf32b6a6a6964
    Reviewed-on: https://go-review.googlesource.com/c/net/+/776080
    Reviewed-by: Damien Neil <[email protected]>
    LUCI-TryBot-Result: [email protected] <[email protected]>
    Reviewed-by: Nicholas Husin <[email protected]>
    nicholashusin committed May 9, 2026
    Configuration menu
    Copy the full SHA
    ad8140e View commit details
    Browse the repository at this point in the history

Commits on May 15, 2026

  1. quic: establish a "happened-before" relationship between stream write…

    … and read
    
    This ensures that our race detector will not get tripped off in tests
    where we do something like the following:
    
    1. Client writes to a shared variable.
    2. Client sends a request to a server.
    3. Server handler reads the shared variable.
    
    We are technically over-synchronizing right now by always using the
    address of quicSync when calling runtime.RaceAcquire and
    runtime.RaceReleaseMerge. However, that is fine for now since this
    mostly matters just for testing, and creating a mapping of stream ID to
    addressess are rather unclean.
    
    For golang/go#78737
    
    Change-Id: Id65964ad3aa0b2e998e8faf11bfda3c76a6a6964
    Reviewed-on: https://go-review.googlesource.com/c/net/+/777940
    LUCI-TryBot-Result: [email protected] <[email protected]>
    Reviewed-by: Damien Neil <[email protected]>
    Reviewed-by: Nicholas Husin <[email protected]>
    nicholashusin committed May 15, 2026
    Configuration menu
    Copy the full SHA
    210ed3c View commit details
    Browse the repository at this point in the history
  2. quic: fix appendMaxDataFrame erroneously accumulating sentLimit

    sentLimit value should be of the last MAX_DATA sent to the peer.
    However, we are currently incorrectly incrementing its value rather than
    updating it.
    
    Change-Id: Id73ce651158e7c4f031e8a2e5099e9d36a6a6964
    Reviewed-on: https://go-review.googlesource.com/c/net/+/778380
    LUCI-TryBot-Result: [email protected] <[email protected]>
    Reviewed-by: Damien Neil <[email protected]>
    Reviewed-by: Nicholas Husin <[email protected]>
    nicholashusin committed May 15, 2026
    Configuration menu
    Copy the full SHA
    f865199 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2026

  1. html: ignore duplicate attributes during tokenization

    During tokenization ignore attributes with names we've already seen,
    per WHATWG 13.2.5.33. This removes a parser misalignment that could be
    leveraged to confuse sanitizers.
    
    Thanks to ensy for reporting this issue.
    
    Fixes CVE-2026-27136
    
    Change-Id: Ib0a3edb8dbea35c431f74f8b0bbe6229625d7e1f
    Reviewed-on: https://go-review.googlesource.com/c/net/+/781685
    Reviewed-by: Neal Patel <[email protected]>
    Reviewed-by: Nicholas Husin <[email protected]>
    TryBot-Bypass: Roland Shoemaker <[email protected]>
    Auto-Submit: Gopher Robot <[email protected]>
    Reviewed-by: Nicholas Husin <[email protected]>
    rolandshoemaker authored and gopherbot committed May 22, 2026
    Configuration menu
    Copy the full SHA
    a452f3c View commit details
    Browse the repository at this point in the history
  2. html: properly check namespace in "in body" any other end tag

    When processing "any other end tag" in the "in body" insertion mode,
    when searching for a matching start tag, properly check that said tag is
    in the HTML namespace.
    
    Thanks to ensy for reporting this issue.
    
    Fixes CVE-2026-42506
    
    Change-Id: Ia05867b3d8f8df69f7e9410a85d126fe0b092875
    Reviewed-on: https://go-review.googlesource.com/c/net/+/781700
    Auto-Submit: Gopher Robot <[email protected]>
    TryBot-Bypass: Roland Shoemaker <[email protected]>
    Reviewed-by: Nicholas Husin <[email protected]>
    Reviewed-by: Nicholas Husin <[email protected]>
    Reviewed-by: Neal Patel <[email protected]>
    rolandshoemaker authored and gopherbot committed May 22, 2026
    Configuration menu
    Copy the full SHA
    0dc5b7a View commit details
    Browse the repository at this point in the history
  3. html: properly render fostered elements in foreign content

    When we foster elements under another parent, there are complicated
    rules about which namespace may apply. This in particular affects
    childTextNodesAreLiteral, which checks if we should be emitting raw
    text, or escaped text.
    
    In childTextNodesAreLiteral, check if there is an ancestor which has a
    different namespace. If one is found, check if it's an HTML integration
    point. If not, treat the node as if it were in its parents namespace, if
    so, treat it as HTML.
    
    Thanks to Tristan Madani for reporting this issue.
    
    Fixes CVE-2026-42502
    
    Change-Id: I0ae1780dae335e5f719d7f176cefa83670cfea3d
    Reviewed-on: https://go-review.googlesource.com/c/net/+/781701
    Reviewed-by: Neal Patel <[email protected]>
    Reviewed-by: Nicholas Husin <[email protected]>
    TryBot-Bypass: Roland Shoemaker <[email protected]>
    Reviewed-by: Nicholas Husin <[email protected]>
    Auto-Submit: Gopher Robot <[email protected]>
    rolandshoemaker authored and gopherbot committed May 22, 2026
    Configuration menu
    Copy the full SHA
    a8fb2fe View commit details
    Browse the repository at this point in the history
  4. html: improve Noah's Ark clause performance

    Instead of iterating over each element in the stack, and checking each
    attribute against each other attribute in a ~cubic fashion, sort the
    attributes and just use slices.Equal.
    
    Thanks to IPC Labs for reporting this issue.
    
    Fixes CVE-2026-25680
    
    Change-Id: Iec3513ba0b5da4f28f1359d24846401b9ab76ee3
    Reviewed-on: https://go-review.googlesource.com/c/net/+/781702
    TryBot-Bypass: Roland Shoemaker <[email protected]>
    Reviewed-by: Nicholas Husin <[email protected]>
    Reviewed-by: Neal Patel <[email protected]>
    Reviewed-by: Nicholas Husin <[email protected]>
    Auto-Submit: Gopher Robot <[email protected]>
    rolandshoemaker authored and gopherbot committed May 22, 2026
    Configuration menu
    Copy the full SHA
    08be507 View commit details
    Browse the repository at this point in the history
  5. html: escape greater-than symbol in doctype identifiers

    During parsing, we unescape character references. When rendering, we
    re-escape certain characters in certain scenarios in order to avoid
    token content causing unexpected parser behavior.
    
    We appear to have not taken this into account when rendering DOCTYPE
    tokens, allowing ">" in PUBLIC/SYSTEM identifier strings, which trigger
    a abrupt-doctype-system-identifier parse error which immediately emits
    the current DOCTYPE token and then continues parsing in the data state.
    
    This may cause bypass in HTML santizers which use the html package for
    parsing.
    
    Thanks to ensy for reporting this issue.
    
    Fixes CVE-2026-25681
    
    Change-Id: I1d5be92129d17bfbf0917148db2672d57c224a18
    Reviewed-on: https://go-review.googlesource.com/c/net/+/781703
    Reviewed-by: Neal Patel <[email protected]>
    Reviewed-by: Nicholas Husin <[email protected]>
    TryBot-Bypass: Roland Shoemaker <[email protected]>
    Auto-Submit: Gopher Robot <[email protected]>
    Reviewed-by: Nicholas Husin <[email protected]>
    rolandshoemaker authored and gopherbot committed May 22, 2026
    Configuration menu
    Copy the full SHA
    4ece7b6 View commit details
    Browse the repository at this point in the history
  6. go.mod: update golang.org/x dependencies

    Update golang.org/x dependencies to their latest tagged versions.
    
    Change-Id: I1905a384363c0893821050162b74ba3c6faed7ba
    Reviewed-on: https://go-review.googlesource.com/c/net/+/781740
    Auto-Submit: Gopher Robot <[email protected]>
    Reviewed-by: Nicholas Husin <[email protected]>
    TryBot-Bypass: Neal Patel <[email protected]>
    Reviewed-by: Neal Patel <[email protected]>
    Reviewed-by: Nicholas Husin <[email protected]>
    gopherbot committed May 22, 2026
    Configuration menu
    Copy the full SHA
    7770ec4 View commit details
    Browse the repository at this point in the history
Loading