Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/net
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c630100
Choose a base ref
...
head repository: golang/net
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1e63c2f
Choose a head ref
  • 17 commits
  • 17 files changed
  • 5 contributors

Commits on Nov 1, 2022

  1. http2: add a few other common headers to the shared headermap cache

    This change adds additional common CORS headers and two de-facto
    standard and common X- headers to the shared headermap cache to cut down
    on allocations from lower-casing/canonicalization.
    
    Change-Id: I61121925b0b28414ed6ce07190155662b0444f93
    Reviewed-on: https://go-review.googlesource.com/c/net/+/442176
    Auto-Submit: Damien Neil <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Run-TryBot: Damien Neil <[email protected]>
    Reviewed-by: Ian Lance Taylor <[email protected]>
    Reviewed-by: Damien Neil <[email protected]>
    elindsey authored and neild committed Nov 1, 2022
    Configuration menu
    Copy the full SHA
    c877839 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2022

  1. http2: add common header caching to Transport to reduce allocations

    Currently Server builds two process-global maps to cut down allocations
    due to lower-casing and canonicalization of common headers.
    
    Lower-casing/canonicalization has also been a significant source of
    garbage in Transport - this change extends use of the same
    process-global maps to the client.
    
    Change-Id: I2324c9567a61f28d4dd633a2c0618f08ddbf457c
    Reviewed-on: https://go-review.googlesource.com/c/net/+/442175
    Run-TryBot: Damien Neil <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Damien Neil <[email protected]>
    Auto-Submit: Damien Neil <[email protected]>
    Reviewed-by: Bryan Mills <[email protected]>
    elindsey authored and gopherbot committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    a1278a7 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2022

  1. x/net/http2: gzipReader will reset zr to nil after closing body

    The existing implementation does not reset gz.zr. After Close,
    gzipReader closes underlying response body but buffered data can still
    be read.
    
    gzipReader on Close sets the gz.zerr to fs.ErrClosed so next Read after
    Close will return it immediately.
    
    Fixes golang/go#56020
    
    Change-Id: I8a31e4c65656b9abc3023855b8e04342e1e77cbb
    Reviewed-on: https://go-review.googlesource.com/c/net/+/440555
    Reviewed-by: Damien Neil <[email protected]>
    Run-TryBot: Damien Neil <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Than McIntosh <[email protected]>
    nikola-jokic authored and neild committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    7a67682 View commit details
    Browse the repository at this point in the history
  2. http2/h2c: handle errors when reading HTTP/1 request body

    When processing an HTTP/1 Upgrade: h2c request, detect errors reading
    the request body and fail the request rather than passing off the
    partially-read request to the HTTP/2 server.
    
    Correctly handles the case where a MaxBytesHandler has limited the
    size of the initial HTTP/1 request body.
    
    Fixes golang/go#56352
    
    Change-Id: I08d60953cea26961cffbab3094cc1b44236f4e37
    Reviewed-on: https://go-review.googlesource.com/c/net/+/447396
    Reviewed-by: Brad Fitzpatrick <[email protected]>
    Reviewed-by: John Howard <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Run-TryBot: Damien Neil <[email protected]>
    neild committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    702349b View commit details
    Browse the repository at this point in the history
  3. Revert "http2: Send WindowUpdates when remaining bytes are below a th…

    …reshold"
    
    This reverts commit 2e0b12c.
    
    The calculation for when to return flow control doesn't properly take
    data in server read buffers into account, resulting in flow control
    credit being returned too quickly without backpressure.
    
    Fixes golang/go#56315
    For golang/go#28732
    
    Change-Id: I573afd1a37d8a711da47f05f38f4de04183fb941
    Reviewed-on: https://go-review.googlesource.com/c/net/+/448055
    TryBot-Result: Gopher Robot <[email protected]>
    Run-TryBot: Damien Neil <[email protected]>
    Reviewed-by: Roland Shoemaker <[email protected]>
    neild committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    d7f77dc View commit details
    Browse the repository at this point in the history
  4. http2: support Server.ReadTimeout

    Return an error when reading from the request body in a server
    handler after Server.ReadTimeout expires.
    
    Tested by net/http CL 446255.
    
    For golang/go#49837
    
    Change-Id: Idcc3d92209f944bd7fead832525fd563b50bcebc
    Reviewed-on: https://go-review.googlesource.com/c/net/+/446256
    Reviewed-by: Brad Fitzpatrick <[email protected]>
    Reviewed-by: Bryan Mills <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Run-TryBot: Damien Neil <[email protected]>
    neild committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    a870f35 View commit details
    Browse the repository at this point in the history
  5. http2: return os.ErrDeadlineExceeded from timed-out response body writes

    When a server handler writes to a response body after Server.WriteTimeout
    has expired, return an error matching os.ErrDeadlineExceeded rather than
    "http2: stream closed".
    
    Tested by net/http CL 446255.
    
    For golang/go#56478
    
    Change-Id: I94494cc7e7f8f9a01a663de09fd5b73acc8ea4e4
    Reviewed-on: https://go-review.googlesource.com/c/net/+/446257
    Run-TryBot: Damien Neil <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Brad Fitzpatrick <[email protected]>
    Reviewed-by: Bryan Mills <[email protected]>
    neild committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    efda1ce View commit details
    Browse the repository at this point in the history
  6. http2: support SetReadDeadline, SetWriteDeadline, FlushError

    Add support for ResponseController methods to set read/write deadlines
    and flush with an error return.
    
    Change-Id: I63059d13bef28dc32a4b8b75901eb1dd56176f32
    Reviewed-on: https://go-review.googlesource.com/c/net/+/446335
    Reviewed-by: Brad Fitzpatrick <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Bryan Mills <[email protected]>
    Run-TryBot: Damien Neil <[email protected]>
    neild committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    93ec86b View commit details
    Browse the repository at this point in the history
  7. http2: speed up TestTransportRetryHasLimit

    This test takes ~30s to execute with real timers, making it almost
    50% of the total execution time of the http2 tests. Use a fake
    timer in tests.
    
    Change-Id: I750237c7d3b8f7b87881b8a0a8aff2bf4a3cdd9f
    Reviewed-on: https://go-review.googlesource.com/c/net/+/446375
    Reviewed-by: Bryan Mills <[email protected]>
    Reviewed-by: Brad Fitzpatrick <[email protected]>
    Run-TryBot: Damien Neil <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    neild committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    15e1b25 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. go.mod: update golang.org/x dependencies

    Update golang.org/x dependencies to their latest tagged versions.
    Once this CL is submitted, and post-submit testing succeeds on all
    first-class ports across all supported Go versions, this repository
    will be tagged with its next minor version.
    
    Change-Id: I8ff185631699fc311311c2a8c199e8ff3621c4e9
    Reviewed-on: https://go-review.googlesource.com/c/net/+/448457
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Heschi Kreinick <[email protected]>
    Auto-Submit: Gopher Robot <[email protected]>
    Run-TryBot: Gopher Robot <[email protected]>
    Reviewed-by: Michael Knyszek <[email protected]>
    gopherbot committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    a2d827a View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2022

  1. http2: add SETTINGS_HEADER_TABLE_SIZE support

    Add support for handling of SETTINGS_HEADER_TABLESIZE in SETTINGS
    frames.
    
    Add http2.Transport.MaxDecoderHeaderTableSize to set the advertised
    table size for new client connections. Add
    http2.Transport.MaxEncoderHeaderTableSize to cap the accepted size for
    new client connections.
    
    Add http2.Server.MaxDecoderHeaderTableSize and MaxEncoderHeaderTableSize
    to do the same on the server.
    
    Fixes golang/go#29356
    Fixes golang/go#56054
    
    Change-Id: I16ae0f84b8527dc1e09dfce081e9f408fd514513
    Reviewed-on: https://go-review.googlesource.com/c/net/+/435899
    Reviewed-by: Damien Neil <[email protected]>
    Reviewed-by: Joedian Reid <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Run-TryBot: Damien Neil <[email protected]>
    elindsey authored and neild committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    0e478a2 View commit details
    Browse the repository at this point in the history
  2. http2: add Transport.MaxReadFrameSize configuration setting

    For golang/go#47840.
    Fixes golang/go#54850.
    
    Change-Id: I44efec8d1f223b3c2be82a2e11752fbbe8bf2cbf
    Reviewed-on: https://go-review.googlesource.com/c/net/+/362834
    Run-TryBot: Damien Neil <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Damien Neil <[email protected]>
    Reviewed-by: Roland Shoemaker <[email protected]>
    Auto-Submit: Damien Neil <[email protected]>
    Reviewed-by: Joedian Reid <[email protected]>
    robaho authored and gopherbot committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    2f8c3d1 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2022

  1. publicsuffix: update table to latest list from publicsuffix.org

    Update the list to revision e248cbc92a527a166454afe9914c4c1b4253893f
    (2022-11-15T18:02:38Z)
    
    Fixes golang/go#56656
    
    Change-Id: I55cf374150b96c67d65a707fe4ffba3e179002a0
    Reviewed-on: https://go-review.googlesource.com/c/net/+/450835
    Run-TryBot: Damien Neil <[email protected]>
    Reviewed-by: Nigel Tao <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Nigel Tao (INACTIVE; USE @golang.org INSTEAD) <[email protected]>
    neild committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    ecf091a View commit details
    Browse the repository at this point in the history
  2. publicsuffix: embed table data

    Use //go:embed to embed the public suffix tables,
    rather than generating .go files containing the data.
    
    Creating an empty git repo and generating commits for the
    last 20 updates to the public suffix list, the total size
    of the repository directory as measured by "du -sh" decreases
    from 2.2M to 668K when using embedding.
    
    For golang/go#15518.
    
    Change-Id: Id71759765831a7699e7a182937095b3820bb643b
    Reviewed-on: https://go-review.googlesource.com/c/net/+/450935
    Run-TryBot: Damien Neil <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Nigel Tao <[email protected]>
    Reviewed-by: Nigel Tao (INACTIVE; USE @golang.org INSTEAD) <[email protected]>
    neild committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    0833b63 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2022

  1. http2: deflake TestTransportMaxFrameReadSize

    Rewrite this test to examine the SETTINGS frame sent by the Transport
    directly, rather than poking around in the Server internals to find
    the sent value.
    
    Fixes golang/go#56806
    
    Change-Id: I47859352a14b7120ef88fce5bd000716b9abdad7
    Reviewed-on: https://go-review.googlesource.com/c/net/+/451775
    Reviewed-by: Bryan Mills <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Run-TryBot: Damien Neil <[email protected]>
    Auto-Submit: Damien Neil <[email protected]>
    neild authored and gopherbot committed Nov 17, 2022
    Configuration menu
    Copy the full SHA
    ecf7fda View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2022

  1. go.mod: update golang.org/x dependencies

    Update golang.org/x dependencies to their latest tagged versions.
    Once this CL is submitted, and post-submit testing succeeds on all
    first-class ports across all supported Go versions, this repository
    will be tagged with its next minor version.
    
    Change-Id: Iba6aa88dee87df78b5a7bad68482d94a76ebf0c8
    Reviewed-on: https://go-review.googlesource.com/c/net/+/455395
    Reviewed-by: Heschi Kreinick <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Run-TryBot: Gopher Robot <[email protected]>
    Auto-Submit: Gopher Robot <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    gopherbot committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    3247b5b View commit details
    Browse the repository at this point in the history
  2. http2: limit canonical header cache by bytes, not entries

    The canonical header cache is a per-connection cache mapping header
    keys to their canonicalized form. (For example, "foo-bar" => "Foo-Bar").
    We limit the number of entries in the cache to prevent an attacker
    from consuming unbounded amounts of memory by sending many unique
    keys, but a small number of very large keys can still consume an
    unreasonable amount of memory.
    
    Track the amount of memory consumed by the cache and limit it based
    on memory rather than number of entries.
    
    Thanks to Josselin Costanzi for reporting this issue.
    
    For golang/go#56350
    
    Change-Id: I41db4c9823ed5bf371a9881accddff1268489b16
    Reviewed-on: https://go-review.googlesource.com/c/net/+/455635
    Reviewed-by: Jenny Rakoczy <[email protected]>
    Run-TryBot: Damien Neil <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    neild committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    1e63c2f View commit details
    Browse the repository at this point in the history
Loading