Repository navigation
Commit a02ddfa
http/httpproxy: prioritize lowercase proxy environment variables
For HTTP_PROXY, HTTPS_PROXY, and NO_PROXY environment variables,
prioritize the lowercase version if both the uppercase and lowercase
versions are set. While there is not an official standard, prioritizing
the lowercase environment variables seem to be what most implementations
have converged on. Therefore, we might as well follow.
This change should be relatively safe. Users will only observe a
behavior difference should they be setting both an uppercase and
lowercase proxy environment variables with different values.
For golang/go#79656
Change-Id: Ife71d260bcc61c52617a05cf5c3d53fb6a6a6964
Reviewed-on: https://go-review.googlesource.com/c/net/+/801700
Reviewed-by: Damien Neil <[email protected]>
Reviewed-by: Nicholas Husin <[email protected]>
LUCI-TryBot-Result: [email protected] <[email protected]>
Auto-Submit: Nicholas Husin <[email protected]>1 parent 574e5eb commit a02ddfa
2 files changed
Lines changed: 38 additions & 19 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
83 | | - | |
84 | | - | |
85 | | - | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
86 | 87 | | |
87 | 88 | | |
88 | 89 | | |
89 | 90 | | |
90 | 91 | | |
91 | 92 | | |
92 | | - | |
93 | | - | |
94 | | - | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
95 | 96 | | |
96 | 97 | | |
97 | 98 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | 12 | | |
14 | 13 | | |
15 | 14 | | |
| |||
260 | 259 | | |
261 | 260 | | |
262 | 261 | | |
263 | | - | |
264 | | - | |
265 | | - | |
266 | | - | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
267 | 266 | | |
268 | 267 | | |
269 | 268 | | |
| |||
276 | 275 | | |
277 | 276 | | |
278 | 277 | | |
279 | | - | |
280 | | - | |
281 | | - | |
282 | | - | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
283 | 282 | | |
284 | 283 | | |
285 | 284 | | |
| |||
293 | 292 | | |
294 | 293 | | |
295 | 294 | | |
296 | | - | |
297 | | - | |
298 | | - | |
299 | | - | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
300 | 299 | | |
301 | 300 | | |
302 | 301 | | |
| |||
308 | 307 | | |
309 | 308 | | |
310 | 309 | | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
311 | 329 | | |
312 | 330 | | |
313 | 331 | | |
| |||
0 commit comments