Skip to content

Commit 7e56200

Browse files
neildgopherbot
authored andcommitted
quic: per-path connection ids
Associate a path with each remote (destination) connection ID. A connection ID should be strictly used on only one network path, to reduce an attacker's ability to associate packets sent on varying paths. DCID (destination connection ID) selection now uses the current path as an input. Peer-provided connection ID limit changed to 4, which is in line with other implementations. (Lots of variation, 4 is median-ish.) Change-Id: Ic34592c60b9f846e923c604bc0c77c826a6a6964 Reviewed-on: https://go-review.googlesource.com/c/net/+/832367 Auto-Submit: Damien Neil <[email protected]> LUCI-TryBot-Result: [email protected] <[email protected]> Reviewed-by: Nicholas Husin <[email protected]> Reviewed-by: Nicholas Husin <[email protected]>
1 parent c1d31df commit 7e56200

12 files changed

Lines changed: 485 additions & 100 deletions

‎quic/conn.go‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -121,16 +121,16 @@ func newConn(now time.Time, side connSide, cids newServerConnIDs, peerHostname s
121121
// initialConnID is the connection ID used to generate Initial packet protection keys.
122122
var initialConnID []byte
123123
if c.side == clientSide {
124-
if err := c.connIDState.initClient(c); err != nil {
124+
if err := c.connIDState.initClient(c, c.path); err != nil {
125125
return nil, err
126126
}
127-
initialConnID, _ = c.connIDState.dstConnID()
127+
initialConnID, _ = c.connIDState.dstConnIDForPath(c.path)
128128
} else {
129129
initialConnID = cids.originalDstConnID
130130
if cids.retrySrcConnID != nil {
131131
initialConnID = cids.retrySrcConnID
132132
}
133-
if err := c.connIDState.initServer(c, cids); err != nil {
133+
if err := c.connIDState.initServer(c, c.path, cids); err != nil {
134134
return nil, err
135135
}
136136
}

0 commit comments

Comments
 (0)