This repository was archived by the owner on Jun 27, 2023. It is now read-only.
fix parse array with the external const correctly#569
Merged
codyoss merged 2 commits intogolang:masterfrom Jun 11, 2021
Merged
Conversation
codyoss
suggested changes
Jun 10, 2021
Member
codyoss
left a comment
codyoss
left a comment
There was a problem hiding this comment.
Thanks for the contribution, just a couple of minor nits.
Contributor
Author
|
Thanks for the review 🌵 I've either fixed or replied to your comments. |
Member
|
@sryoya Thank you for your contribution! 🎆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #561 - Panic on array parsing if length is externally defined
It also fixes the following minor problems in
TestParseArrayWithConstLength, a test function related to this feature.mockgen.fileParser, even though they are initialized in the production code. (Actually, it caused an unnecessary test error by test data I added)