This repository was archived by the owner on Jun 27, 2023. It is now read-only.
sort methods on the mock implementation alphabetically#500
Merged
codyoss merged 1 commit intogolang:masterfrom Dec 10, 2020
marten-seemann:sort-mock-methods
Merged
sort methods on the mock implementation alphabetically#500codyoss merged 1 commit intogolang:masterfrom marten-seemann:sort-mock-methods
codyoss merged 1 commit intogolang:masterfrom
marten-seemann:sort-mock-methods
Conversation
marten-seemann
changed the title
Contributor
Author
|
@codyoss Any thoughts on this PR? |
codyoss
approved these changes
Dec 10, 2020
Member
codyoss
left a comment
codyoss
left a comment
There was a problem hiding this comment.
LGTM, thanks for the contribution!
This was referenced Mar 11, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #499.
Description
Sorting the methods by name will make sure that their order is consistent in source and reflect mode.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Updated the tests, but not sure how to test this without writing a parser for the generated mock files.
Reviewer Notes