net: filter GetAddr netlink requests by interface index#75076
Open
wjordan wants to merge 1 commit intogolang:masterfrom
Open
net: filter GetAddr netlink requests by interface index#75076wjordan wants to merge 1 commit intogolang:masterfrom
wjordan wants to merge 1 commit intogolang:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #53660.
This Linux-specific optimization adds filtering by network interface index to the
RTM_GETADDRnetlink dump request, by setting theNETLINK_GET_STRICT_CHKsocket option to enable strict checking and setting theIfAddrmsg.Indexfield to the requested interface index. This eliminates theO(n^2)behavior described in the issue, resulting in a significant performance improvement on systems with a large number (thousands) of network interfaces:This PR does not require any changes to the public API. In order to avoid changes to the (frozen)
syscall.NetlinkRIBAPI (which hard-codes its netlink requests to the olderRtGenmsgtype), this PR copies this logic into an unexportednetlinkRIBfunction with the necessary changes to send the new message type.