Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 9de1ac6
Choose a base ref
...
head repository: golang/go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6a70ee2
Choose a head ref
  • 12 commits
  • 33 files changed
  • 9 contributors

Commits on Jan 27, 2022

  1. [release-branch.go1.17] net/http/internal/testcert: use FIPS-complian…

    …t certificate
    
    Upgrade the test certificate from RSA 1024 (not FIPS-approved)
    to RSA 2048 (FIPS-approved), allowing tests to pass when
    the dev.boringcrypto branch FIPS-only mode is enabled.
    
    For #48674.
    Fixes #50586.
    
    Change-Id: I613d2f8d0207bf3683fd0df256bf0167604996c5
    Reviewed-on: https://go-review.googlesource.com/c/go/+/353869
    Trust: Damien Neil <[email protected]>
    Run-TryBot: Damien Neil <[email protected]>
    Reviewed-by: Filippo Valsorda <[email protected]>
    (cherry picked from commit 90860e0)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/380995
    Trust: Dmitri Shuralyov <[email protected]>
    Run-TryBot: Dmitri Shuralyov <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    neild authored and dmitshur committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    3a34273 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2022

  1. [release-branch.go1.17] math/big: prevent overflow in (*Rat).SetString

    Credit to rsc@ for the original patch.
    
    Thanks to the OSS-Fuzz project for discovering this
    issue and to Emmanuel Odeke (@odeke_et) for reporting it.
    
    Updates #50699
    Fixes #50701
    Fixes CVE-2022-23772
    
    Change-Id: I590395a3d55689625390cf1e58f5f40623b26ee5
    Reviewed-on: https://go-review.googlesource.com/c/go/+/379537
    Trust: Katie Hockman <[email protected]>
    Run-TryBot: Katie Hockman <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Emmanuel Odeke <[email protected]>
    Reviewed-by: Roland Shoemaker <[email protected]>
    Reviewed-by: Julie Qiu <[email protected]>
    (cherry picked from commit ad345c2)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/381336
    Reviewed-by: Filippo Valsorda <[email protected]>
    katiehockman committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    539d430 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2022

  1. [release-branch.go1.17] debug/pe,debug/macho: add support for DWARF5 …

    …sections
    
    Adds the same logic used in debug/elf to load DWARF5 sections.
    
    For #49590
    Fixes #50722
    
    Change-Id: Iee05b9927a6f521842b330eab8942ade3fc2bd86
    Reviewed-on: https://go-review.googlesource.com/c/go/+/363895
    Reviewed-by: Ian Lance Taylor <[email protected]>
    Trust: Than McIntosh <[email protected]>
    (cherry picked from commit 6c36c33)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/379914
    Trust: Ian Lance Taylor <[email protected]>
    Run-TryBot: Ian Lance Taylor <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Alessandro Arzilli <[email protected]>
    Reviewed-by: Emmanuel Odeke <[email protected]>
    aarzilli authored and ianlancetaylor committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    1b867ce View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2022

  1. [release-branch.go1.17] cmd/go: remove mercurial from bitbucket vcs o…

    …ptions
    
    Mercurial was deprecated as of July 1, 2020 as per https://bitbucket.org/blog/sunsetting-mercurial-support-in-bitbucket
    
    Fixes #50812.
    Updates #50810.
    
    Change-Id: I0d40f84aaa393905cae7c4bed8919b15de9a5f6d
    Reviewed-on: https://go-review.googlesource.com/c/go/+/371720
    Trust: Russ Cox <[email protected]>
    Reviewed-by: Bryan Mills <[email protected]>
    Trust: Bryan Mills <[email protected]>
    (cherry picked from commit 5b1b80b)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/380996
    Run-TryBot: Bryan Mills <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Ian Lance Taylor <[email protected]>
    aethanol authored and cherrymui committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    faa0409 View commit details
    Browse the repository at this point in the history
  2. [release-branch.go1.17] cmd/internal/obj/x86: modify the threshold of…

    … assert loop for span6
    
    Updates #49716.
    Fixes #50942.
    
    Change-Id: I7ed73f874c2ee1ee3f31c9c4428ed484167ca803
    Reviewed-on: https://go-review.googlesource.com/c/go/+/366094
    Reviewed-by: Cherry Mui <[email protected]>
    Trust: Heschi Kreinick <[email protected]>
    (cherry picked from commit 14f2b2a)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/383214
    Trust: Cherry Mui <[email protected]>
    Run-TryBot: Cherry Mui <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Alex Rakoczy <[email protected]>
    zhouguangyuan0718 authored and cherrymui committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    17e179e View commit details
    Browse the repository at this point in the history
  3. [release-branch.go1.17] cmd/compile: don't elide extension for LoadRe…

    …g to FP register on MIPS64
    
    For an extension operation like MOVWreg, if the operand is already
    extended, we optimize the second extension out. Usually a LoadReg
    of a proper type would come already extended, as a MOVW/MOVWU etc.
    instruction does. But for a LoadReg to a floating point register,
    the instruction does not do the extension. So we cannot elide the
    extension.
    
    Updates #50671.
    Fixes #50683.
    
    Change-Id: Id8991df78d5acdecd3fd6138c558428cbd5f6ba3
    Reviewed-on: https://go-review.googlesource.com/c/go/+/379236
    Trust: Cherry Mui <[email protected]>
    Run-TryBot: Cherry Mui <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: David Chase <[email protected]>
    (cherry picked from commit d93ff73)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/379514
    cherrymui committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    1651426 View commit details
    Browse the repository at this point in the history
  4. [release-branch.go1.17] cmd/compile: remove incorrect arm,arm64 CMP->…

    …CMN transformations
    
    These can go wrong when one of the operands is the minimum integer value.
    
    Fixes #50867.
    
    Change-Id: I238fe284f60c7ee5aeb9dc9a18e8b1578cdb77d0
    Reviewed-on: https://go-review.googlesource.com/c/go/+/381318
    Reviewed-by: Keith Randall <[email protected]>
    Reviewed-by: Cherry Mui <[email protected]>
    Trust: David Chase <[email protected]>
    Run-TryBot: David Chase <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    (cherry picked from commit b7b44b3)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/381474
    Run-TryBot: Cherry Mui <[email protected]>
    dr2chase authored and cherrymui committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    acb1ce5 View commit details
    Browse the repository at this point in the history
  5. [release-branch.go1.17] cmd/go/internal/modfetch: do not short-circui…

    …t canonical versions
    
    Since at least CL 121857, the conversion logic in
    (*modfetch).codeRepo.Stat has had a short-circuit to use the version
    requested by the caller if it successfully resolves and is already
    canonical.
    
    However, we should not use that version if it refers to a branch
    instead of a tag, because branches (unlike tags) usually do not refer
    to a single, stable release: a branch named "v1.0.0" may be for the
    development of the v1.0.0 release, or for the development of patches
    based on v1.0.0, but only one commit (perhaps at the end of that
    branch — but possibly not even written yet!) can be that specific
    version.
    
    We already have some logic to prefer tags that are semver-equivalent
    to the version requested by the caller. That more general case
    suffices for exact equality too — so we can eliminate the
    special-case, fixing the bug and (happily!) also somewhat simplifying
    the code.
    
    Updates #35671
    Fixes #50687
    Fixes CVE-2022-23773
    
    Change-Id: I2fd290190b8a99a580deec7e26d15659b58a50b0
    Reviewed-on: https://go-review.googlesource.com/c/go/+/378400
    Trust: Bryan Mills <[email protected]>
    Run-TryBot: Bryan Mills <[email protected]>
    Reviewed-by: Russ Cox <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    (cherry picked from commit fa4d9b8)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/382835
    Bryan C. Mills authored and cherrymui committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    fbcc30a View commit details
    Browse the repository at this point in the history
  6. [release-branch.go1.17] crypto/elliptic: make IsOnCurve return false …

    …for invalid field elements
    
    Updates #50974
    Fixes #50978
    Fixes CVE-2022-23806
    
    Change-Id: I0201c2c88f13dd82910985a495973f1683af9259
    Reviewed-on: https://go-review.googlesource.com/c/go/+/382854
    Trust: Filippo Valsorda <[email protected]>
    Run-TryBot: Filippo Valsorda <[email protected]>
    Reviewed-by: Katie Hockman <[email protected]>
    Trust: Katie Hockman <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    FiloSottile authored and cherrymui committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    e163319 View commit details
    Browse the repository at this point in the history
  7. [release-branch.go1.17] cmd/link: force eager binding when using plug…

    …ins on darwin
    
    When building/using plugins on darwin, we need to use flat
    namespace so the same symbol from the main executable and the
    plugin can be resolved to the same address. Apparently, when using
    flat namespace the dynamic linker can hang at forkExec when
    resolving a lazy binding. Work around it by forcing early bindings.
    
    Updates #38824.
    Fixes #50246.
    
    Change-Id: I983aa0a0960b15bf3f7871382e8231ee244655f4
    Reviewed-on: https://go-review.googlesource.com/c/go/+/372798
    Trust: Cherry Mui <[email protected]>
    Reviewed-by: Than McIntosh <[email protected]>
    Reviewed-by: Ian Lance Taylor <[email protected]>
    Run-TryBot: Cherry Mui <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    (cherry picked from commit c5fee93)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/373094
    cherrymui committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    4a31565 View commit details
    Browse the repository at this point in the history
  8. [release-branch.go1.17] runtime: set vdsoSP to caller's SP consistently

    m.vdsoSP should be set to the SP of the caller of nanotime1,
    instead of the SP of nanotime1 itself, which matches m.vdsoPC.
    Otherwise the unmatched vdsoPC and vdsoSP would make the stack
    trace look like recursive.
    
    We already do it correctly on AMD64, 386, and RISCV64. This CL
    fixes the rest.
    
    Also incorporate CL 352509, skipping a flaky test.
    
    Updates #47324, #50772.
    Fixes #50781.
    
    Change-Id: I98b6fcfbe9fc6bdd28b8fe2a1299b7c505371dd4
    Reviewed-on: https://go-review.googlesource.com/c/go/+/337590
    Trust: Cherry Mui <[email protected]>
    Trust: Josh Bleecher Snyder <[email protected]>
    Reviewed-by: Josh Bleecher Snyder <[email protected]>
    (cherry picked from commit 217507e)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/380715
    Run-TryBot: Cherry Mui <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Michael Knyszek <[email protected]>
    cherrymui committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    1952c65 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2022

  1. [release-branch.go1.17] go1.17.7

    Change-Id: I760af1114e06bf408715e094d8d5b66c5aeb3e16
    Reviewed-on: https://go-review.googlesource.com/c/go/+/384494
    Trust: Cherry Mui <[email protected]>
    Run-TryBot: Cherry Mui <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Alex Rakoczy <[email protected]>
    cherrymui committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    6a70ee2 View commit details
    Browse the repository at this point in the history
Loading