Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 9baddd3
Choose a base ref
...
head repository: golang/go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 04cd717
Choose a head ref
  • 8 commits
  • 19 files changed
  • 7 contributors

Commits on Apr 12, 2021

  1. [release-branch.go1.16] time: use offset and isDST when caching zone …

    …from extend string
    
    If the current time is computed from extend string
    and the zone file contains multiple zones with the
    same name, the lookup by name might find incorrect
    zone.
    
    This happens for example with the slim Europe/Dublin
    time zone file in the embedded zip. This zone file
    has last transition in 1996 and rest is covered by
    extend string.
    tzset returns IST as the zone name to use, but there
    are two records with IST name. Lookup by name finds
    the wrong one. We need to check offset and isDST too.
    
    In case we can't find an existing zone, we allocate
    a new zone so that we use correct offset and isDST.
    
    I have renamed zone variable to zones as it shadowed
    the zone type that we need to allocate the cached zone.
    
    Backport note: this change also incorporates portions of
    CL 264077.
    
    For #45370
    Fixes #45385
    
    Change-Id: If7a0cccc1908e27f0509bf422d824133133250fc
    Reviewed-on: https://go-review.googlesource.com/c/go/+/307211
    Trust: Ian Lance Taylor <[email protected]>
    Run-TryBot: Ian Lance Taylor <[email protected]>
    TryBot-Result: Go Bot <[email protected]>
    Reviewed-by: Emmanuel Odeke <[email protected]>
    ianlancetaylor committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    f12cf76 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2021

  1. [release-branch.go1.16] std: update golang.org/x/net to 2021042818330…

    …0-3f4a416c7d3b
    
    Steps:
      go get -d golang.org/x/[email protected]
      go mod tidy
      go mod vendor
    
    This http2 bundle does not need to be updated.
    
    Fixes #45712
    
    Change-Id: I7c86c31248e0cd250d17495c3f985671cfcf44a3
    Reviewed-on: https://go-review.googlesource.com/c/go/+/314789
    Trust: Katie Hockman <[email protected]>
    Run-TryBot: Katie Hockman <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    katiehockman committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    d4adea2 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2021

  1. [release-branch.go1.16] archive/zip: only return directory once via i…

    …o/fs.FS
    
    While we're here fix the ModTime value for directories.
    
    For #43872
    For #45345
    Fixes #45347
    
    Change-Id: I155e6517713ef6a9482b9431f1167a44337c6ad2
    Reviewed-on: https://go-review.googlesource.com/c/go/+/311530
    Trust: Ian Lance Taylor <[email protected]>
    Run-TryBot: Ian Lance Taylor <[email protected]>
    TryBot-Result: Go Bot <[email protected]>
    Reviewed-by: Jeremy Faller <[email protected]>
    (cherry picked from commit 87e4dcd)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/315249
    Trust: Jeremy Faller <[email protected]>
    ianlancetaylor committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    e67a58b View commit details
    Browse the repository at this point in the history

Commits on May 4, 2021

  1. [release-branch.go1.16] runtime: non-strict InlTreeIndex lookup in ex…

    …pandFinalInlineFrame
    
    This is a follow-up to golang.org/cl/301369, which made the same change
    in Frames.Next. The same logic applies here: a profile stack may have
    been truncated at an invalid PC provided by cgoTraceback.
    expandFinalInlineFrame will then try to lookup the inline tree and
    crash.
    
    The same fix applies as well: upon encountering a bad PC, simply leave
    it as-is and move on.
    
    For #44971
    For #45480
    Fixes #45482
    
    Change-Id: I2823c67a1f3425466b05384cc6d30f5fc8ee6ddc
    Reviewed-on: https://go-review.googlesource.com/c/go/+/309109
    Reviewed-by: Michael Knyszek <[email protected]>
    Trust: Michael Pratt <[email protected]>
    (cherry picked from commit aad13cb)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/309551
    Run-TryBot: Michael Pratt <[email protected]>
    Reviewed-by: Cherry Zhang <[email protected]>
    TryBot-Result: Go Bot <[email protected]>
    prattmic authored and cagedmantis committed May 4, 2021
    Configuration menu
    Copy the full SHA
    ea0537f View commit details
    Browse the repository at this point in the history
  2. [release-branch.go1.16] cmd/compile: fix ANDI/SRWI merge on ppc64

    The shift amount should be masked to avoid rotation values
    beyond the numer of bits. In this case, if the shift amount
    is 0, it should rotate 0, not 32.
    
    Fixes #45636
    
    Change-Id: I1e764497a39d0ec128e29af42352b70c70b2ecc5
    Reviewed-on: https://go-review.googlesource.com/c/go/+/310569
    Run-TryBot: Paul Murphy <[email protected]>
    TryBot-Result: Go Bot <[email protected]>
    Reviewed-by: Lynn Boger <[email protected]>
    Reviewed-by: Carlos Eduardo Seo <[email protected]>
    Trust: Carlos Eduardo Seo <[email protected]>
    (cherry picked from commit c8fb0ec)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/311378
    Reviewed-by: Keith Randall <[email protected]>
    Run-TryBot: Keith Randall <[email protected]>
    Trust: Lynn Boger <[email protected]>
    pmur authored and cagedmantis committed May 4, 2021
    Configuration menu
    Copy the full SHA
    7e70979 View commit details
    Browse the repository at this point in the history
  3. [release-branch.go1.16] syscall: syscall.AllThreadsSyscall signal han…

    …dling fixes
    
    The runtime support for syscall.AllThreadsSyscall() functions had
    some corner case deadlock issues when signal handling was in use.
    This was observed in at least 3 build test failures on ppc64 and
    amd64 architecture CGO_ENABLED=0 builds over the last few months.
    
    The fixes involve more controlled handling of signals while the
    AllThreads mechanism is being executed. Further details are
    discussed in bug #44193.
    
    The all-threads syscall support is new in go1.16, so earlier
    releases are not affected by this bug.
    
    Fixes #45307
    
    Change-Id: I01ba8508a6e1bb2d872751f50da86dd07911a41d
    Reviewed-on: https://go-review.googlesource.com/c/go/+/305149
    Reviewed-by: Michael Pratt <[email protected]>
    Trust: Michael Pratt <[email protected]>
    Trust: Ian Lance Taylor <[email protected]>
    Run-TryBot: Michael Pratt <[email protected]>
    TryBot-Result: Go Bot <[email protected]>
    (cherry picked from commit 7e97e4e)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/316869
    Run-TryBot: Ian Lance Taylor <[email protected]>
    AndrewGMorgan authored and ianlancetaylor committed May 4, 2021
    Configuration menu
    Copy the full SHA
    ce04f86 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2021

  1. [release-branch.go1.16] runtime/pprof: skip tests for AIX

    Most of the time, the pprof tests are passing, except
    for the builder. The reason is still unknown but I'd rather release
    the builder to avoid missing other more important bugs.
    
    Updates #45170
    
    Change-Id: I667543ee1ae309b7319c5b3676a0901b4d0ecf2e
    Reviewed-on: https://go-review.googlesource.com/c/go/+/306489
    Run-TryBot: Tobias Klauser <[email protected]>
    TryBot-Result: Go Bot <[email protected]>
    Reviewed-by: Cherry Zhang <[email protected]>
    Trust: Lynn Boger <[email protected]>
    (cherry picked from commit 7bfd681)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/317297
    Trust: Heschi Kreinick <[email protected]>
    Run-TryBot: Heschi Kreinick <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Helflym authored and heschi committed May 5, 2021
    Configuration menu
    Copy the full SHA
    87ffba3 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2021

  1. [release-branch.go1.16] go1.16.4

    Change-Id: I7fb3c30641332961819a79819c7567cf1dbe1ab1
    Reviewed-on: https://go-review.googlesource.com/c/go/+/317649
    Run-TryBot: Heschi Kreinick <[email protected]>
    TryBot-Result: Go Bot <[email protected]>
    Reviewed-by: Carlos Amedee <[email protected]>
    Trust: Carlos Amedee <[email protected]>
    Trust: Heschi Kreinick <[email protected]>
    heschi committed May 6, 2021
    Configuration menu
    Copy the full SHA
    04cd717 View commit details
    Browse the repository at this point in the history
Loading