Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 8a720da
Choose a base ref
...
head repository: golang/go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 694e20f
Choose a head ref
  • 8 commits
  • 8 files changed
  • 5 contributors

Commits on Dec 9, 2019

  1. [release-branch.go1.12] doc: add CherryPickApproved filter to Release…

    … History links
    
    Not all closed issues in a given minor milestone are included in that
    release, only the ones that have been labeled as CherryPickApproved are.
    
    Update the links to the GitHub issue tracker to include a filter on the
    CherryPickApproved label, so that the default view shows only the
    backports that were included in a given release. This should more useful
    to most people than seeing all backports (considered and approved).
    
    Do this only for Go 1.9.1 and newer releases, as that is when we started
    using the CherryPickCandidate and CherryPickApproved labels.
    
    Updates #35988
    Fixes #36002
    
    Change-Id: I51e07c1bc3ab9c4a5744e8f668c5470adf78bffe
    Reviewed-on: https://go-review.googlesource.com/c/go/+/210118
    Run-TryBot: Dmitri Shuralyov <[email protected]>
    Reviewed-by: Alexander Rakoczy <[email protected]>
    TryBot-Result: Gobot Gobot <[email protected]>
    dmitshur committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    741cb42 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2019

  1. [release-branch.go1.12] cmd/go/internal/modfetch: remove non-hermetic…

    … test
    
    The test for gopkg.in/yaml.v2@v2 assumes that there are
    no future upstream releases. That assumption empirically
    does not hold. Backporting fixes to this test is annoying,
    and other gopkg.in cases are already reasonably covered,
    so remove the problematic test.
    
    Updates #28856
    
    Change-Id: I6455baa1816ac69e02d1ad5d03b82a93e1481a17
    Reviewed-on: https://go-review.googlesource.com/c/go/+/205437
    Run-TryBot: Bryan C. Mills <[email protected]>
    Reviewed-by: Brad Fitzpatrick <[email protected]>
    (cherry picked from commit f0390ff)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/205439
    Reviewed-by: Alexander Rakoczy <[email protected]>
    TryBot-Result: Gobot Gobot <[email protected]>
    Bryan C. Mills committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    e4e29ee View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2020

  1. [release-branch.go1.12] runtime: monitor for suspend/resume to kick t…

    …imeouts
    
    Starting in Windows 8, the wait functions don't take into account
    suspend time, even though the monotonic counters do. This results in
    timer buckets stalling on resume. Therefore, this commit makes it so
    that on resume, we return from the wait functions and recalculate the
    amount of time left to wait.
    
    This is a cherry pick of CL 191957 and its cleanup, CL 198417.
    
    Updates #31528
    Fixes #36376
    
    Change-Id: I0db02cc72188cb620954e87a0180e0a3c83f4a56
    Reviewed-on: https://go-review.googlesource.com/c/go/+/193607
    Run-TryBot: Jason A. Donenfeld <[email protected]>
    TryBot-Result: Gobot Gobot <[email protected]>
    Reviewed-by: Austin Clements <[email protected]>
    Reviewed-on: https://go-review.googlesource.com/c/go/+/213197
    zx2c4 authored and dmitshur committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    93f0599 View commit details
    Browse the repository at this point in the history
  2. [release-branch.go1.12] runtime: do not use PowerRegisterSuspendResum…

    …eNotification on systems with "program time" timer
    
    Systems where PowerRegisterSuspendResumeNotification returns ERROR_
    FILE_NOT_FOUND are also systems where nanotime() is on "program time"
    rather than "real time".  The chain for this is:
    
    powrprof.dll!PowerRegisterSuspendResumeNotification ->
      umpdc.dll!PdcPortOpen ->
        ntdll.dll!ZwAlpcConnectPort("\\PdcPort") ->
          syscall -> ntoskrnl.exe!AlpcpConnectPort
    
    Opening \\.\PdcPort fails with STATUS_OBJECT_NAME_NOT_FOUND when pdc.sys
    hasn't been initialized. Pdc.sys also provides the various hooks for
    sleep resumption events, which means if it's not loaded, then our "real
    time" timer is actually on "program time". Finally STATUS_OBJECT_NAME_
    NOT_FOUND is passed through RtlNtStatusToDosError, which returns ERROR_
    FILE_NOT_FOUND. Therefore, in the case where the function returns ERROR_
    FILE_NOT_FOUND, we don't mind, since the timer we're using will
    correspond fine with the lack of sleep resumption notifications. This
    applies, for example, to Docker users.
    
    Updates #35447
    Updates #35482
    Fixes #36377
    
    Change-Id: I9e1ce5bbc54b9da55ff7a3918b5da28112647eee
    Reviewed-on: https://go-review.googlesource.com/c/go/+/208317
    Reviewed-by: Jason A. Donenfeld <[email protected]>
    Reviewed-by: Austin Clements <[email protected]>
    Run-TryBot: Jason A. Donenfeld <[email protected]>
    TryBot-Result: Gobot Gobot <[email protected]>
    Reviewed-on: https://go-review.googlesource.com/c/go/+/213198
    zx2c4 authored and dmitshur committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    e42221d View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2020

  1. [release-branch.go1.12] net/http: avoid writing to Transport.ProxyCon…

    …nectHeader
    
    Previously, we accidentally wrote the Proxy-Authorization header for
    the initial CONNECT request to the shared ProxyConnectHeader map when
    it was non-nil.
    
    Updates #36431
    Fixes #36433
    
    Change-Id: I5cb414f391dddf8c23d85427eb6973f14c949025
    Reviewed-on: https://go-review.googlesource.com/c/go/+/213638
    Run-TryBot: Bryan C. Mills <[email protected]>
    Reviewed-by: Brad Fitzpatrick <[email protected]>
    TryBot-Result: Gobot Gobot <[email protected]>
    (cherry picked from commit 249c85d)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/213677
    Bryan C. Mills committed Jan 7, 2020
    Configuration menu
    Copy the full SHA
    c5af2aa View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2020

  1. [release-branch.go1.12] runtime: ensure memmove write pointer atomica…

    …lly on ARM64
    
    If a pointer write is not atomic, if the GC is running
    concurrently, it may observe a partially updated pointer, which
    may point to unallocated or already dead memory. Most pointer
    writes, like the store instructions generated by the compiler,
    are already atomic. But we still need to be careful in places
    like memmove. In memmove, we don't know which bits are pointers
    (or too expensive to query), so we ensure that all aligned
    pointer-sized units are written atomically.
    
    Fixes #36367.
    Updates #36101.
    
    Change-Id: I1b3ca24c6b1ac8a8aaf9ee470115e9a89ec1b00b
    Reviewed-on: https://go-review.googlesource.com/c/go/+/212626
    Reviewed-by: Austin Clements <[email protected]>
    (cherry picked from commit ffbc027)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/213684
    Run-TryBot: Cherry Zhang <[email protected]>
    TryBot-Result: Gobot Gobot <[email protected]>
    cherrymui authored and toothrot committed Jan 8, 2020
    Configuration menu
    Copy the full SHA
    ae78084 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2020

  1. [release-branch.go1.12] doc: document Go 1.12.15

    Change-Id: I3b2c26d4818ca28a71a7fd6927a0c39c9253f06f
    Reviewed-on: https://go-review.googlesource.com/c/go/+/214079
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Reviewed-by: Alexander Rakoczy <[email protected]>
    Run-TryBot: Dmitri Shuralyov <[email protected]>
    Run-TryBot: Alexander Rakoczy <[email protected]>
    TryBot-Result: Gobot Gobot <[email protected]>
    cagedmantis committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    bc42c34 View commit details
    Browse the repository at this point in the history
  2. [release-branch.go1.12] go1.12.15

    Change-Id: I6e47da51c3687ae9590554d003d803270f50911e
    Reviewed-on: https://go-review.googlesource.com/c/go/+/214082
    Run-TryBot: Carlos Amedee <[email protected]>
    TryBot-Result: Gobot Gobot <[email protected]>
    Reviewed-by: Alexander Rakoczy <[email protected]>
    cagedmantis committed Jan 9, 2020
    Configuration menu
    Copy the full SHA
    694e20f View commit details
    Browse the repository at this point in the history
Loading