Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 28622c1
Choose a base ref
...
head repository: golang/go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: f2cd93a
Choose a head ref
  • 10 commits
  • 20 files changed
  • 5 contributors

Commits on Oct 17, 2025

  1. [release-branch.go1.25] net/url: allow IP-literals with IPv4-mapped I…

    …Pv6 addresses
    
    The security fix we applied in CL709857 was overly broad. It applied
    rules from RFC 2732, which disallowed IPv4-mapped IPv6 addresses, but
    these were later allowed in RFC 3986, which is the canonical URI syntax
    RFC.
    
    Revert the portion of CL709857 which restricted IPv4-mapped addresses,
    and update the related tests.
    
    Updates #75815
    Fixes #75832
    
    Change-Id: I3192f2275ad5c386f5c15006a6716bdb5282919d
    Reviewed-on: https://go-review.googlesource.com/c/go/+/710375
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: Ethan Lee <[email protected]>
    Auto-Submit: Roland Shoemaker <[email protected]>
    (cherry picked from commit 9db7e30)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/712240
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Auto-Submit: Dmitri Shuralyov <[email protected]>
    TryBot-Bypass: Dmitri Shuralyov <[email protected]>
    rolandshoemaker authored and gopherbot committed Oct 17, 2025
    Configuration menu
    Copy the full SHA
    f6db735 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2025

  1. [release-branch.go1.25] encoding/pem: properly decode strange PEM data

    When the passed byte slice has leading garbage, properly handle ignoring
    it and continuing to parse the slice until we find a valid block (or
    nothing).
    
    Fixes #75952
    
    Change-Id: I07e937d9c754fd71b028b99450b48f57b4464457
    Reviewed-on: https://go-review.googlesource.com/c/go/+/712140
    Reviewed-by: Damien Neil <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    (cherry picked from commit 0983090)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/712640
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    rolandshoemaker authored and dr2chase committed Oct 24, 2025
    Configuration menu
    Copy the full SHA
    7e049e5 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2025

  1. [release-branch.go1.25] cmd/compile: prevent shapifying of pointer sh…

    …ape type
    
    CL 641955 changes the Unified IR reader to not doing shapify when
    reading reshaping expression, prevent losing of the original type.
    
    This is an oversight, as the main problem isn't about shaping during the
    reshaping process itself, but about the specific case of shaping a
    pointer shape type. This bug occurs when instantiating a generic
    function within another generic function with a pointer shape type as
    type parameter, which will convert `*[]go.shape.T` to `*go.shape.uint8`,
    resulting in the loss of the original expression's type.
    
    This commit changes Unified IR reader to avoid pointer shaping for
    `*[]go.shape.T`, ensures that the original type is preserved when
    processing reshaping expressions.
    
    Fixes #75480
    
    Change-Id: Icede6b73247d0d367bb485619f2dafb60ad66806
    Reviewed-on: https://go-review.googlesource.com/c/go/+/704095
    Auto-Submit: Cuong Manh Le <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: David Chase <[email protected]>
    Reviewed-by: Junyang Shao <[email protected]>
    Reviewed-on: https://go-review.googlesource.com/c/go/+/706216
    Reviewed-by: Ed Schouten <[email protected]>
    Reviewed-by: Cherry Mui <[email protected]>
    cuonglm authored and mknyszek committed Oct 27, 2025
    Configuration menu
    Copy the full SHA
    bbb7627 View commit details
    Browse the repository at this point in the history
  2. [release-branch.go1.25] runtime: use one more address bit for tagged …

    …pointers
    
    We use one extra bit to placate systems which simulate amd64 binaries on
    an arm64 host. Allocated arm64 addresses could be as high as 1<<48-1,
    which would be invalid if we assumed 48-bit sign-extended addresses.
    
    (Note that this does not help the other way around, simluating arm64
    on amd64, but we don't have that problem at the moment.)
    
    For #69255.
    Fixes #75775.
    
    Change-Id: Iace17a5d41a65e34abf201d03d8b0ff6f7bf1150
    Reviewed-on: https://go-review.googlesource.com/c/go/+/700515
    Reviewed-by: Keith Randall <[email protected]>
    Auto-Submit: Keith Randall <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: Michael Knyszek <[email protected]>
    (cherry picked from commit 2a7f1d4)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/712800
    Reviewed-by: Keith Randall <[email protected]>
    Reviewed-by: David Chase <[email protected]>
    randall77 authored and mknyszek committed Oct 27, 2025
    Configuration menu
    Copy the full SHA
    bf95b76 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2025

  1. [release-branch.go1.25] Revert "crypto/internal/fips140/subtle: add a…

    …ssembly implementation of xorBytes for mipsx"
    
    This reverts commit 343e486.
    
    Reason for revert: doesn't handle unaligned accesses correctly.
    
    Update #75790
    
    Change-Id: I1d6210eeca9336f2ce311e99944cb270565563aa
    Reviewed-on: https://go-review.googlesource.com/c/go/+/709795
    Reviewed-by: Cherry Mui <[email protected]>
    Reviewed-by: Michael Knyszek <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: Keith Randall <[email protected]>
    (cherry picked from commit cb81270)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/709758
    Reviewed-by: David Chase <[email protected]>
    randall77 authored and mknyszek committed Oct 28, 2025
    Configuration menu
    Copy the full SHA
    cd21a7b View commit details
    Browse the repository at this point in the history
  2. [release-branch.go1.25] Revert "crypto/internal/fips140/subtle: add a…

    …ssembly implementation of xorBytes for mips64x"
    
    This reverts commit 49d6777.
    
    Reason for revert: doesn't handle unaligned accesses correctly
    
    Fixes #75790
    
    Change-Id: Ia272245a6a2a91b305d411207430bad660ee355b
    Reviewed-on: https://go-review.googlesource.com/c/go/+/709757
    Reviewed-by: Keith Randall <[email protected]>
    Reviewed-by: Cherry Mui <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    (cherry picked from commit a1661e7)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/709798
    Reviewed-by: Keith Randall <[email protected]>
    Reviewed-by: David Chase <[email protected]>
    Reviewed-by: Michael Knyszek <[email protected]>
    randall77 authored and mknyszek committed Oct 28, 2025
    Configuration menu
    Copy the full SHA
    4942c74 View commit details
    Browse the repository at this point in the history
  3. [release-branch.go1.25] os: support deleting read-only files in Remov…

    …eAll on older Windows versions
    
    The Windows implementation of RemoveAll supports deleting read-only
    files only on file systems that supports POSIX semantics and on
    newer Windows versions (Windows 10 RS5 and latter).
    
    For all the other cases, the read-only bit was not clearer before
    deleting read-only files, so they fail to delete.
    
    Note that this case was supported prior to CL 75922, which landed on
    Go 1.25.
    
    For #75922
    Fixes #75989
    
    Change-Id: Id6e6477f42e1952d08318ca3e4ab7c1648969f66
    Reviewed-on: https://go-review.googlesource.com/c/go/+/713480
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: David Chase <[email protected]>
    Reviewed-by: Damien Neil <[email protected]>
    Auto-Submit: Damien Neil <[email protected]>
    (cherry picked from commit b31dc77)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/715360
    Auto-Submit: Michael Knyszek <[email protected]>
    qmuntal authored and gopherbot committed Oct 28, 2025
    Configuration menu
    Copy the full SHA
    8097b19 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2025

  1. [release-branch.go1.25] cmd/compile: don't optimize away a panicing i…

    …nterface comparison
    
    We can't do direct pointer comparisons if the type is not a
    comparable type.
    
    Fixes #76010
    
    Change-Id: I1687acff21832d2c2e8f3b875e7b5ec125702ef3
    Reviewed-on: https://go-review.googlesource.com/c/go/+/713840
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: David Chase <[email protected]>
    Reviewed-by: Cuong Manh Le <[email protected]>
    Reviewed-by: Keith Randall <[email protected]>
    Reviewed-on: https://go-review.googlesource.com/c/go/+/715720
    Reviewed-by: Michael Knyszek <[email protected]>
    randall77 authored and dr2chase committed Oct 29, 2025
    Configuration menu
    Copy the full SHA
    5ba37a3 View commit details
    Browse the repository at this point in the history
  2. [release-branch.go1.25] encoding/pem: properly calculate end indexes

    When a block is missing the END line trailer, calculate the indexes of
    the end and end trailer _before_ continuing the loop, making the
    reslicing at the start of the loop work as expected.
    
    Fixes #76029
    
    Change-Id: If45c8cb473315623618f02cc7609f517a72d232d
    Reviewed-on: https://go-review.googlesource.com/c/go/+/714200
    Auto-Submit: Roland Shoemaker <[email protected]>
    Reviewed-by: Damien Neil <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    (cherry picked from commit 839da71)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/714661
    Reviewed-by: David Chase <[email protected]>
    rolandshoemaker authored and mknyszek committed Oct 29, 2025
    Configuration menu
    Copy the full SHA
    83885f3 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2025

  1. [release-branch.go1.25] go1.25.4

    Change-Id: Iddc4427830693f0b518cb9766d6b1b552b97b79e
    Reviewed-on: https://go-review.googlesource.com/c/go/+/718064
    Reviewed-by: Michael Knyszek <[email protected]>
    Reviewed-by: Michael Pratt <[email protected]>
    TryBot-Bypass: Gopher Robot <[email protected]>
    Auto-Submit: Gopher Robot <[email protected]>
    gopherbot committed Nov 5, 2025
    Configuration menu
    Copy the full SHA
    f2cd93a View commit details
    Browse the repository at this point in the history
Loading