Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: go1.21.8
Choose a base ref
...
head repository: golang/go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: go1.21.9
Choose a head ref
  • 7 commits
  • 12 files changed
  • 5 contributors

Commits on Mar 12, 2024

  1. [release-branch.go1.21] go/types, types2: don't do version checks for…

    … embedded types of imported interfaces
    
    Imported interfaces don't have position information for embedded types.
    When computing the type set of such interfaces, doing a version check
    may fail because it will rely on the Go version of the current package.
    
    We must not do a version check for features of types from imported
    packages - those types have already been typechecked and are "correct".
    The version check code does look at packages to avoid such incorrect
    version checks, but we don't have the package information available
    in an interface type (divorced from its object).
    
    Instead, for now rely on the fact that imported interfaces don't have
    position information for embedded types: if the position is unknown,
    don't do a version check.
    
    We may want to assert that positions are known in all other cases,
    but since this is an older release, don't add such additional changes
    to avoid introducing other bugs.
    
    Fixes #66064.
    
    Change-Id: I773d57e5410c3d4a911ab3e018b3233c2972b3c9
    Reviewed-on: https://go-review.googlesource.com/c/go/+/571075
    Reviewed-by: Robert Findley <[email protected]>
    Auto-Submit: Robert Griesemer <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: Robert Griesemer <[email protected]>
    griesemer authored and gopherbot committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    6d22988 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. [release-branch.go1.21] Revert "go/types, types2: don't do version ch…

    …ecks for embedded types of imported interfaces"
    
    This reverts CL 571075.
    
    Reason for revert: We might want to do a security-only minor release. Back off the release branch to a clean state from the previous minor release. Sorry for the inconvenience.
    
    Change-Id: Ifc8c7e00e6faea3aa547b883eed44180ddb447de
    Reviewed-on: https://go-review.googlesource.com/c/go/+/571355
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: Robert Findley <[email protected]>
    cherrymui committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    140b37d View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. [release-branch.go1.21] cmd/internal/obj/ppc64: don't modify runtime.…

    …elf_* symbols
    
    The runtime.elf_* symbols are assembly functions which are used
    to support the gcc/llvm -Os option when used with cgo.
    
    When compiling Go for shared code, we attempt to strip out the
    TOC regenation code added by the go assembler for these symbols.
    
    This causes the symbol to no longer appear as an assembly
    function which causes problems later on when handling other
    implicit symbols.
    
    Avoid adding a TOC regeneration prologue to these functions
    to avoid this issue.
    
    Fixes #66411
    
    Change-Id: Icbf8e4438d177082a57bb228e39b232e7a0d7ada
    Reviewed-on: https://go-review.googlesource.com/c/go/+/571835
    Reviewed-by: Than McIntosh <[email protected]>
    Run-TryBot: Paul Murphy <[email protected]>
    Reviewed-by: Cherry Mui <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: Lynn Boger <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-on: https://go-review.googlesource.com/c/go/+/572876
    pmur authored and thanm committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    0bd1a22 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. [release-branch.go1.21] go/types, types2: don't do version checks for…

    … embedded types of imported interfaces
    
    [This is a re-apply of CL 571075]
    
    Imported interfaces don't have position information for embedded types.
    When computing the type set of such interfaces, doing a version check
    may fail because it will rely on the Go version of the current package.
    
    We must not do a version check for features of types from imported
    packages - those types have already been typechecked and are "correct".
    The version check code does look at packages to avoid such incorrect
    version checks, but we don't have the package information available
    in an interface type (divorced from its object).
    
    Instead, for now rely on the fact that imported interfaces don't have
    position information for embedded types: if the position is unknown,
    don't do a version check.
    
    We may want to assert that positions are known in all other cases,
    but since this is an older release, don't add such additional changes
    to avoid introducing other bugs.
    
    Fixes #66326.
    Updates #66064.
    
    Change-Id: I158cf51aa382f85d612ab958ba4b591de1c5fdb2
    Reviewed-on: https://go-review.googlesource.com/c/go/+/574736
    Reviewed-by: Cherry Mui <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    griesemer authored and thanm committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    efb7cc4 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. [release-branch.go1.21] all: update golang.org/x/net

    Pulls in one HTTP/2 fix:
    
    	0b0455d2c9 http2: reject DATA frames after 1xx and before final headers
    
    For #65927
    Fixes #66254
    
    Change-Id: I257b2634f63e8c6039c44dea24c345043c23c8d2
    Reviewed-on: https://go-review.googlesource.com/c/go/+/574916
    Reviewed-by: Than McIntosh <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    neild authored and thanm committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    30d8550 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. [release-branch.go1.21] net/http: update bundled golang.org/x/net/http2

    Disable cmd/internal/moddeps test, since this update includes PRIVATE
    track fixes.
    
    Fixes CVE-2023-45288
    For #65051
    Fixes #65387
    
    Change-Id: I17da6da2fe0dd70062b49f94377875acb34829a1
    Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/2197267
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Run-TryBot: Damien Neil <[email protected]>
    Reviewed-by: Tatiana Bradley <[email protected]>
    Reviewed-on: https://go-review.googlesource.com/c/go/+/576075
    TryBot-Bypass: Dmitri Shuralyov <[email protected]>
    Commit-Queue: Dmitri Shuralyov <[email protected]>
    Auto-Submit: Dmitri Shuralyov <[email protected]>
    Reviewed-by: Than McIntosh <[email protected]>
    neild authored and gopherbot committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    ae59133 View commit details
    Browse the repository at this point in the history
  2. [release-branch.go1.21] go1.21.9

    Change-Id: I6c69376d434dcf310336a0344051037bf58a4cf7
    Reviewed-on: https://go-review.googlesource.com/c/go/+/576117
    Commit-Queue: Gopher Robot <[email protected]>
    Reviewed-by: Than McIntosh <[email protected]>
    TryBot-Bypass: Dmitri Shuralyov <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Auto-Submit: Gopher Robot <[email protected]>
    gopherbot committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    d8392e6 View commit details
    Browse the repository at this point in the history
Loading