Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: go1.21.11
Choose a base ref
...
head repository: golang/go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: go1.21.12
Choose a head ref
  • 9 commits
  • 22 files changed
  • 7 contributors

Commits on Jun 12, 2024

  1. [release-branch.go1.21] go/internal/gccgoimporter: recognize "any" as…

    … a builtin type
    
    In CL 536715 we're changing the gofrontend export data to report
    "any" as a builtin type. This permits us to distinguish the builtin
    type from some other package-level type "any". That requires an update
    to this code.
    
    Fixes #67849
    
    Change-Id: I91d75a056a155fa9892c4b25ab396cb4d39cc8e4
    Reviewed-on: https://go-review.googlesource.com/c/go/+/537195
    Reviewed-by: Than McIntosh <[email protected]>
    Reviewed-by: David Chase <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: Cherry Mui <[email protected]>
    (cherry picked from commit b8ac61e)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/592216
    Auto-Submit: Ian Lance Taylor <[email protected]>
    Reviewed-by: Ian Lance Taylor <[email protected]>
    ianlancetaylor authored and gopherbot committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    7e563a0 View commit details
    Browse the repository at this point in the history
  2. [release-branch.go1.21] net: add GODEBUG=netedns0=0 to disable sendin…

    …g EDNS0 header
    
    It reportedly breaks the DNS server on some modems.
    
    For #6464
    For #21160
    For #44135
    For #51127
    For #51153
    For #67925
    Fixes #67933
    
    Change-Id: I54a11906159f00246d08a54cc8be7327e9ebfd2c
    Reviewed-on: https://go-review.googlesource.com/c/go/+/591995
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Auto-Submit: Ian Lance Taylor <[email protected]>
    Reviewed-by: Damien Neil <[email protected]>
    Reviewed-by: Ian Lance Taylor <[email protected]>
    (cherry picked from commit ee4a42b)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/592235
    Commit-Queue: Ian Lance Taylor <[email protected]>
    ianlancetaylor authored and gopherbot committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    74ac37e View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. [release-branch.go1.21] cmd/go: fix go list -u -m all with too new re…

    …tractions dependency
    
    Previously, go would not report retractions of dependencies that have a
    newer version of Go. With this change, we will still display retractions despite a version difference when go list -u -m is used.
    
    For: #66403
    Fixes: #68051
    
    Change-Id: I6406680235e294269836ae4cbe3d5680ca10eea0
    Reviewed-on: https://go-review.googlesource.com/c/go/+/588775
    Auto-Submit: Sam Thanawalla <[email protected]>
    Reviewed-by: Michael Matloob <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    (cherry picked from commit e44fa1c)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/593375
    samthanawalla authored and joedian committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    e65014d View commit details
    Browse the repository at this point in the history
  2. [release-branch.go1.21] cmd/link: put runtime.end in the last section…

    … of data segment
    
    Currently the runtime.end symbol is put into the noptrbss section,
    which is usually the last section, except that when fuzzing is
    enabled, the last section is actually .go.fuzzcntrs. The
    runtime.end symbol has the value pointing to the end of the data
    segment, so if it is not in the last section, the value will not
    actually be in the range of the section. This causes an assertion
    failure in the new Apple linker. This CL fixes this by putting it
    in the last section.
    
    Updates #65169.
    Fixes #67944.
    
    Change-Id: I5c991c46a0483a96e5f6e0255a3b444953676026
    Reviewed-on: https://go-review.googlesource.com/c/go/+/592095
    Reviewed-by: Than McIntosh <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    (cherry picked from commit b589478)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/592477
    cherrymui authored and joedian committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    dfb0067 View commit details
    Browse the repository at this point in the history
  3. [release-branch.go1.21] cmd/cgo/internal/swig: force use of lld for L…

    …TO tests on the builders
    
    For whatever reason, on the builders, when using /usr/bin/ld (the
    default linker) with -flto we end up with problems. Specifically, the
    linker seems to require LLVMgold.so and can't find it. I'm not really
    sure why, but what definitely seems to work is forcing use of lld, which
    ships with our clang installation on the builders.
    
    Just enforce this on the builders for now; I've actually had very few
    problems running this locally (and I think I'm also mixing and matching
    linkers and toolchains too...), so it may be related to the version of
    clang we're testing with.
    
    For #67698.
    For #67714.
    
    Change-Id: I3bfbcd609e7d0fd70e52ac7e2a0817db95664f20
    Cq-Include-Trybots: luci.golang.try:go1.21-linux-amd64-clang15,go1.21-linux-386-clang15
    Reviewed-on: https://go-review.googlesource.com/c/go/+/589296
    Auto-Submit: Dmitri Shuralyov <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Reviewed-on: https://go-review.googlesource.com/c/go/+/591377
    mknyszek authored and joedian committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    537ec6f View commit details
    Browse the repository at this point in the history
  4. [release-branch.go1.21] cmd/cgo/internal/testsanitizers: make the lib…

    …fuzzer tests all short
    
    CL 589295 only made one of the two tests short, because the other one
    seemed to be passing consistently in short mode. On the builders, it
    seems to still fail maybe 30% of the time by taking too long. Disable
    these tests in short mode.
    
    This CL was merged with CL 589295 before cherry-picking.
    
    For #67698.
    Fixes #67714.
    
    Change-Id: I9fd047f834f7493b608dd1fee5b9b6dfabbea03d
    Cq-Include-Trybots: luci.golang.try:go1.21-linux-amd64-clang15,go1.21-linux-386-clang15
    Reviewed-on: https://go-review.googlesource.com/c/go/+/589495
    Auto-Submit: Michael Knyszek <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Commit-Queue: Michael Knyszek <[email protected]>
    Reviewed-on: https://go-review.googlesource.com/c/go/+/591378
    mknyszek authored and joedian committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    29d378a View commit details
    Browse the repository at this point in the history
  5. [release-branch.go1.21] runtime: always update stack bounds on cgocal…

    …lback
    
    callbackUpdateSystemStack contains a fast path to exit early without
    update if SP is already within the g0.stack bounds.
    
    This is not safe, as a subsequent call may have new stack bounds that
    only partially overlap the old stack bounds. In this case it is possible
    to see an SP that is in the old stack bounds, but very close to the
    bottom of the bounds due to the partial overlap. In that case we're very
    likely to "run out" of space on the system stack.
    
    We only need to do this on extra Ms, as normal Ms have precise bounds
    defined when we allocated the stack.
    
    TSAN annotations are added to x_cgo_getstackbounds because bounds is a
    pointer into the Go stack. The stack can be reused when an old thread
    exits and a new thread starts, but TSAN can't see the synchronization
    there. This isn't a new case, but we are now calling more often.
    
    For #62440.
    Fixes #67297.
    
    Cq-Include-Trybots: luci.golang.try:go1.21-linux-amd64-longtest
    Change-Id: I5389050494987b7668d0b317fb92f85e61d798ac
    Reviewed-on: https://go-review.googlesource.com/c/go/+/584597
    Reviewed-by: Cherry Mui <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    (cherry picked from commit 1ffc296)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/585337
    prattmic authored and joedian committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    ac14d4d View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. [release-branch.go1.21] net/http: send body or close connection on ex…

    …pect-100-continue requests
    
    When sending a request with an "Expect: 100-continue" header,
    we must send the request body before sending any further requests
    on the connection.
    
    When receiving a non-1xx response to an "Expect: 100-continue" request,
    send the request body if the connection isn't being closed after
    processing the response. In other words, if either the request
    or response contains a "Connection: close" header, then skip sending
    the request body (because the connection will not be used for
    further requests), but otherwise send it.
    
    Correct a comment on the server-side Expect: 100-continue handling
    that implied sending the request body is optional. It isn't.
    
    For #67555
    Fixes #68199
    
    Change-Id: Ia2f12091bee697771087f32ac347509ec5922d54
    Reviewed-on: https://go-review.googlesource.com/c/go/+/591255
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: Jonathan Amsterdam <[email protected]>
    (cherry picked from commit cf501e0)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/595096
    Reviewed-by: Joedian Reid <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    neild authored and joedian committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    c9be6ae View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. [release-branch.go1.21] go1.21.12

    Change-Id: I5d0af46471907bc3d28f18348bb208689e4d9949
    Reviewed-on: https://go-review.googlesource.com/c/go/+/596256
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: David Chase <[email protected]>
    Reviewed-by: Than McIntosh <[email protected]>
    Auto-Submit: Gopher Robot <[email protected]>
    gopherbot committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    12e9b96 View commit details
    Browse the repository at this point in the history
Loading