Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: go1.20.8
Choose a base ref
...
head repository: golang/go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: go1.20.9
Choose a head ref
  • 5 commits
  • 6 files changed
  • 3 contributors

Commits on Sep 21, 2023

  1. [release-branch.go1.20] cmd/link: force old Apple linker in plugin mode

    There are some bugs in Apple's new linker that probably will not
    be fixed when Xcode 15 is released (some time soon). We fix/work
    around them but it is too much to backport them all. Force old
    Apple linker to work around.
    
    Updates #61229.
    For #62597.
    
    Change-Id: Ia5941918e882b22b4dbc41c74764d19d413d0b56
    Reviewed-on: https://go-review.googlesource.com/c/go/+/527818
    Run-TryBot: Cherry Mui <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Than McIntosh <[email protected]>
    cherrymui committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    071f03a View commit details
    Browse the repository at this point in the history
  2. [release-branch.go1.20] cmd/link: disable DWARF by default in c-share…

    …d mode on darwin
    
    [This is a (manual) backport of CL 527415 to Go 1.20.]
    
    Currently, linking a Go c-shared object with C code using Apple's
    new linker, it fails with
    
    % cc a.c go.so
    ld: segment '__DWARF' filesize exceeds vmsize in 'go.so'
    
    Apple's new linker has more checks for unmapped segments. It is
    very hard to make it accept a Mach-O shared object with an
    additional DWARF segment.
    
    We may want to stop combinding DWARF into the shared object (see
    also #62577). For now, disable DWARF by default in c-shared mode
    on darwin.
    
    Updates #61229.
    For #62597.
    
    Change-Id: I313349f71296d6d7025db28469593825ce9f1866
    Reviewed-on: https://go-review.googlesource.com/c/go/+/527819
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Than McIntosh <[email protected]>
    Run-TryBot: Cherry Mui <[email protected]>
    cherrymui committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    08c544d View commit details
    Browse the repository at this point in the history
  3. [release-branch.go1.20] cmd/link: suppress -bind_at_load deprecation …

    …warning for ld-prime
    
    ld-prime emits a deprecation warning for -bind_at_load. The flag
    is needed for plugins to not deadlock (#38824) when linking with
    older darwin linker. It is supposedly not needed with newer linker
    when chained fixups are used. For now, we always pass it, and
    suppress the warning.
    
    Updates #61229.
    For #62597.
    
    Change-Id: I4b8a6f864a460c40dc38adbb533f664f7fd5343c
    Reviewed-on: https://go-review.googlesource.com/c/go/+/508696
    Reviewed-by: Than McIntosh <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Run-TryBot: Cherry Mui <[email protected]>
    (cherry picked from commit 040dbf9)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/527798
    cherrymui committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    83dce45 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. [release-branch.go1.20] cmd/compile: use absolute file name in isCgo …

    …check
    
    For #23672
    Updates #63211
    Fixes #63213
    Fixes CVE-2023-39323
    
    Change-Id: I4586a69e1b2560036afec29d53e53cf25e6c7352
    Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/2032884
    Reviewed-by: Matthew Dempsky <[email protected]>
    Reviewed-by: Roland Shoemaker <[email protected]>
    (cherry picked from commit 9b19e751918dd218035811b1ef83a8c2693b864a)
    Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/2037629
    Reviewed-by: Tatiana Bradley <[email protected]>
    Run-TryBot: Roland Shoemaker <[email protected]>
    Reviewed-by: Damien Neil <[email protected]>
    Reviewed-on: https://go-review.googlesource.com/c/go/+/533195
    Auto-Submit: Michael Pratt <[email protected]>
    Reviewed-by: Ian Lance Taylor <[email protected]>
    TryBot-Bypass: Michael Pratt <[email protected]>
    Reviewed-by: Than McIntosh <[email protected]>
    ianlancetaylor authored and prattmic committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    31d5b60 View commit details
    Browse the repository at this point in the history
  2. [release-branch.go1.20] go1.20.9

    Change-Id: Ic4eedc3dc193c335784b5a86214ea2e655e631a7
    Reviewed-on: https://go-review.googlesource.com/c/go/+/533237
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Reviewed-by: Michael Pratt <[email protected]>
    TryBot-Bypass: Michael Pratt <[email protected]>
    Auto-Submit: Gopher Robot <[email protected]>
    Reviewed-by: Than McIntosh <[email protected]>
    gopherbot committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    68f9a6e View commit details
    Browse the repository at this point in the history
Loading