Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: go1.18.8
Choose a base ref
...
head repository: golang/go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: go1.18.9
Choose a head ref
  • 12 commits
  • 30 files changed
  • 8 contributors

Commits on Nov 8, 2022

  1. [release-branch.go1.18] crypto/x509: respect GODEBUG changes for allo…

    …wing SHA1 certificates
    
    This allows programs that want SHA1 support to call os.Setenv at startup
    instead of insisting that users set the environment variable themselves.
    
    For #41682.
    Fixes #56436.
    Fixes #56437.
    
    Change-Id: Idcb96212a1d8c560e1dd8eaf7c80b6266f16431e
    Reviewed-on: https://go-review.googlesource.com/c/go/+/445496
    Reviewed-by: David Chase <[email protected]>
    Run-TryBot: Russ Cox <[email protected]>
    Reviewed-by: Roland Shoemaker <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Auto-Submit: Russ Cox <[email protected]>
    Reviewed-on: https://go-review.googlesource.com/c/go/+/445656
    rsc committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    db5cb5f View commit details
    Browse the repository at this point in the history
  2. [release-branch.go1.18] runtime: fix usleep on linux/PPC64

    The existing implementation fails to convert the remainder
    microseconds to nanoseconds. This causes sysmon to consume
    much more cpu, and generate lots of context switches.
    
    We can also do a little better here to avoid division by a
    constant. I used go to determine the magic numbers.
    
    Fixes #56396
    
    Change-Id: I2e37ec218b9027efab6db4634eed1504c0c1b3c8
    Reviewed-on: https://go-review.googlesource.com/c/go/+/444735
    Reviewed-by: Lynn Boger <[email protected]>
    Run-TryBot: Paul Murphy <[email protected]>
    Reviewed-by: David Chase <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Bryan Mills <[email protected]>
    Reviewed-on: https://go-review.googlesource.com/c/go/+/445156
    pmur authored and mknyszek committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    e54e808 View commit details
    Browse the repository at this point in the history
  3. [release-branch.go1.18] cmd/compile: copy blank parameter node when s…

    …ubstituting function type
    
    When a function type is copied (e.g. for substituting type
    parameters), we make copies of its parameter ir.Name nodes, so
    they are not shared with the old function type. But currently a
    blank (_) identifier is not copied but shared. The parameter
    node's frame offset is assigned (in ABI analysis) and then used in
    the concurrent backend. Shared node can cause a data race. Make a
    new blank parameter node to avoid sharing. (Unified IR does already
    not have this problem. This fixes non-unified-IR mode.)
    
    Updates #55357.
    Fixes #56359.
    
    Change-Id: Ie27f08e5589ac7d5d3f0d0d5de1a21e4fd2765c9
    Reviewed-on: https://go-review.googlesource.com/c/go/+/443158
    Reviewed-by: Keith Randall <[email protected]>
    Run-TryBot: Cherry Mui <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Keith Randall <[email protected]>
    (cherry picked from commit 4725c71)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/445177
    cherrymui authored and mknyszek committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    d9c62ce View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2022

  1. [release-branch.go1.18] os/exec: allow NUL in environment variables o…

    …n Plan 9
    
    Plan 9 uses NUL as os.PathListSeparator, so it's almost always going
    to appear in the environment variable list. Exempt GOOS=plan9 from the
    check for NUL in environment variables.
    
    For #56284.
    For #56544.
    Fixes #56550.
    
    Change-Id: I23df233cdf20c0a9a606fd9253e15a9b5482575a
    Reviewed-on: https://go-review.googlesource.com/c/go/+/447715
    Reviewed-by: David du Colombier <[email protected]>
    Run-TryBot: Matthew Dempsky <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Damien Neil <[email protected]>
    Reviewed-on: https://go-review.googlesource.com/c/go/+/447875
    Run-TryBot: David du Colombier <[email protected]>
    mdempsky authored and mknyszek committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    ca57180 View commit details
    Browse the repository at this point in the history
  2. [release-branch.go1.18] cmd/compile: allow ineffectual //go:linkname …

    …in -lang=go1.17 and older
    
    Prior to Go 1.18, ineffectual //go:linkname directives (i.e.,
    directives referring to an undeclared name, or to a declared type or
    constant) were treated as noops. In Go 1.18, we changed this into a
    compiler error to mitigate accidental misuse.
    
    However, the x/sys repo contained ineffectual //go:linkname directives
    up until go.dev/cl/274573, which has caused a lot of user confusion.
    
    It seems a bit late to worry about now, but to at least prevent
    further user pain, this CL changes the error message to only apply to
    modules using "go 1.18" or newer. (The x/sys repo declared "go 1.12"
    at the time go.dev/cl/274573 was submitted.)
    
    For #55889.
    Fixes #56556.
    
    Change-Id: Id762fff96fd13ba0f1e696929a9e276dfcba2620
    Reviewed-on: https://go-review.googlesource.com/c/go/+/447755
    TryBot-Result: Gopher Robot <[email protected]>
    Run-TryBot: Matthew Dempsky <[email protected]>
    Reviewed-by: Bryan Mills <[email protected]>
    Reviewed-on: https://go-review.googlesource.com/c/go/+/447815
    mdempsky authored and mknyszek committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    d2a7a18 View commit details
    Browse the repository at this point in the history
  3. [release-branch.go1.18] runtime: don't jump stack if at entry of syst…

    …emstack
    
    The traceback code has special "jump stack" logic, to trace back
    stack switches through systemstack. If we're at the entry of
    systemstack, the stack switch hasn't happened, so don't jump to
    user stack.
    
    The jump stack logic is only used if we're on the g0 stack. It can
    happen that we're at the entry of a recursive systemstack call on
    the g0 stack. In we jump stack here, there will be two problems:
    1. There are frames between entering the g0 stack and this
       recursive systemstack call. Those frames will be lost.
    2. Worse, we switched frame.sp but frame.fp calculation will use
       the entry SP delta (0), which will be wrong, which in turn
       leads wrong frame.lr and things will go off.
    
    For now, don't jump stack if we're at entry of systemstack (SP
    delta is 0).
    
    Using a per-PC SPWRITE marker may be a better fix. If we haven't
    written the SP, we haven't switched the stack so we can just
    unwind like a normal function.
    
    Updates #55851.
    Fixes #56635.
    
    Change-Id: I2b624c8c086b235b34d9c7d3cebd4a37264f00f8
    Reviewed-on: https://go-review.googlesource.com/c/go/+/437299
    TryBot-Result: Gopher Robot <[email protected]>
    Run-TryBot: Cherry Mui <[email protected]>
    Reviewed-by: Michael Pratt <[email protected]>
    (cherry picked from commit 500bc6b)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/448517
    cherrymui authored and mknyszek committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    a3dce12 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2022

  1. [release-branch.go1.18] net: disable TestLookupDotsWithRemoteSource a…

    …nd TestLookupGoogleSRV
    
    These tests fail consistently due to a DNS change causing widespread
    trybot outages.
    
    For #56707.
    Fixes #56709.
    
    Change-Id: Iebdf91254a922a48880021198f0f12f6bc16b6e7
    Reviewed-on: https://go-review.googlesource.com/c/go/+/449640
    Reviewed-by: Carlos Amedee <[email protected]>
    Reviewed-by: Bryan Mills <[email protected]>
    Run-TryBot: Michael Knyszek <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Damien Neil <[email protected]>
    (cherry picked from commit 9776524)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/449505
    Reviewed-by: Ian Lance Taylor <[email protected]>
    mknyszek committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    d96e584 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2022

  1. [release-branch.go1.18] runtime: make GC see object as allocated afte…

    …r it is initialized
    
    When the GC is scanning some memory (possibly conservatively),
    finding a pointer, while concurrently another goroutine is
    allocating an object at the same address as the found pointer, the
    GC may see the pointer before the object and/or the heap bits are
    initialized. This may cause the GC to see bad pointers and
    possibly crash.
    
    To prevent this, we make it that the scanner can only see the
    object as allocated after the object and the heap bits are
    initialized. Currently the allocator uses freeindex to find the
    next available slot, and that code is coupled with updating the
    free index to a new slot past it. The scanner also uses the
    freeindex to determine if an object is allocated. This is somewhat
    racy. This CL makes the scanner use a different field, which is
    only updated after the object initialization (and a memory
    barrier).
    
    Updates #54596.
    Fixes #56751.
    
    Change-Id: I2a57a226369926e7192c253dd0d21d3faf22297c
    Reviewed-on: https://go-review.googlesource.com/c/go/+/449017
    Reviewed-by: Austin Clements <[email protected]>
    Reviewed-by: Michael Knyszek <[email protected]>
    Run-TryBot: Cherry Mui <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    (cherry picked from commit febe7b8)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/453255
    cherrymui committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    3115ed2 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2022

  1. [release-branch.go1.18] cmd/cgo: recognize clang 14 DWARF type names

    Fixes #57028
    Updates #53013
    
    Change-Id: I169d4eb2420a6da52cc9abe17da98c3092a91be6
    Reviewed-on: https://go-review.googlesource.com/c/go/+/407514
    Auto-Submit: Ian Lance Taylor <[email protected]>
    Reviewed-by: Cherry Mui <[email protected]>
    Reviewed-by: Ian Lance Taylor <[email protected]>
    Run-TryBot: Ian Lance Taylor <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    (cherry picked from commit 2cfbef4)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/454415
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Run-TryBot: Heschi Kreinick <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    dmgk authored and heschi committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    e727f41 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2022

  1. [release-branch.go1.18] os, net/http: avoid escapes from os.DirFS and…

    … http.Dir on Windows
    
    Do not permit access to Windows reserved device names (NUL, COM1, etc.)
    via os.DirFS and http.Dir filesystems.
    
    Avoid escapes from os.DirFS(`\`) on Windows. DirFS would join the
    the root to the relative path with a path separator, making
    os.DirFS(`\`).Open(`/foo/bar`) open the path `\\foo\bar`, which is
    a UNC name. Not only does this not open the intended file, but permits
    reference to any file on the system rather than only files on the
    current drive.
    
    Make os.DirFS("") invalid, with all file access failing. Previously,
    a root of "" was interpreted as "/", which is surprising and probably
    unintentional.
    
    Fixes CVE-2022-41720.
    Fixes #56694.
    
    Change-Id: I275b5fa391e6ad7404309ea98ccc97405942e0f0
    Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/1663832
    Reviewed-by: Julie Qiu <[email protected]>
    Reviewed-by: Tatiana Bradley <[email protected]>
    Reviewed-on: https://go-review.googlesource.com/c/go/+/455360
    Reviewed-by: Michael Pratt <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    Run-TryBot: Jenny Rakoczy <[email protected]>
    neild authored and toothrot committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    7013a4f View commit details
    Browse the repository at this point in the history
  2. [release-branch.go1.18] net/http: update bundled golang.org/x/net/http2

    Disable cmd/internal/moddeps test, since this update includes PRIVATE
    track fixes.
    
    For #56350
    For #57008
    Fixes CVE-2022-41717
    
    Change-Id: I31ebd2b9ae190ef6f7646187103ea1c8a713ff2e
    Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/1663833
    Reviewed-by: Tatiana Bradley <[email protected]>
    Reviewed-by: Julie Qiu <[email protected]>
    Reviewed-on: https://go-review.googlesource.com/c/go/+/455361
    Run-TryBot: Jenny Rakoczy <[email protected]>
    Reviewed-by: Michael Pratt <[email protected]>
    TryBot-Result: Gopher Robot <[email protected]>
    neild authored and toothrot committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    76cad4e View commit details
    Browse the repository at this point in the history
  3. [release-branch.go1.18] go1.18.9

    Change-Id: Ida61e740fc342357f54e523c0044cf6d83e0baec
    Reviewed-on: https://go-review.googlesource.com/c/go/+/455597
    TryBot-Result: Gopher Robot <[email protected]>
    Reviewed-by: Michael Pratt <[email protected]>
    Reviewed-by: Jenny Rakoczy <[email protected]>
    Run-TryBot: Gopher Robot <[email protected]>
    Auto-Submit: Gopher Robot <[email protected]>
    gopherbot authored and toothrot committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    0d8a92b View commit details
    Browse the repository at this point in the history
Loading