Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: go1.12.8
Choose a base ref
...
head repository: golang/go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: go1.12.9
Choose a head ref
  • 9 commits
  • 12 files changed
  • 6 contributors

Commits on Jul 15, 2019

  1. [release-branch.go1.12] crypto/tls: remove TestVerifyHostnameResumed

    Session resumption is not a reliable TLS behavior: the server can decide
    to reject a session ticket for a number of reasons, or no reason at all.
    This makes this non-hermetic test extremely brittle.
    
    It's currently broken on the builders for both TLS 1.2 and TLS 1.3, and
    I could reproduce the issue for TLS 1.3 only. As I was debugging it, it
    started passing entirely on my machine.
    
    In practice, it doesn't get us any coverage as resumption is already
    tested with the recorded exchange tests, and TestVerifyHostname still
    provides a smoke test checking that we can in fact talk TLS.
    
    Updates #32978
    
    Change-Id: I63505e22ff7704f25ad700d46e4ff14850ba5d3c
    Reviewed-on: https://go-review.googlesource.com/c/go/+/186239
    Run-TryBot: Filippo Valsorda <[email protected]>
    Reviewed-by: Bryan C. Mills <[email protected]>
    (cherry-picked from 20e4540)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/186277
    TryBot-Result: Gobot Gobot <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    FiloSottile committed Jul 15, 2019
    Configuration menu
    Copy the full SHA
    8759b53 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2019

  1. [release-branch.go1.12] cmd/link: put shlib ".type" functions in inte…

    …rnal ABI
    
    These functions are compiler generated, and as such are only available
    in the internal ABI. Doing this avoids generating an alias symbol.
    Doing that avoids confusion between unmangled and mangled type symbols.
    
    Updates #30768
    Fixes #33040
    
    Change-Id: I8aba3934ffa994b1a19fc442cfe3e05642792a25
    Reviewed-on: https://go-review.googlesource.com/c/go/+/186278
    Run-TryBot: Ian Lance Taylor <[email protected]>
    TryBot-Result: Gobot Gobot <[email protected]>
    Reviewed-by: Austin Clements <[email protected]>
    ianlancetaylor committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    f194c9f View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2019

  1. Configuration menu
    Copy the full SHA
    3c97797 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2019

  1. [release-branch.go1.12] os: enable the close-on-exec flag for openFdAt

    There's a race here with fork/exec, enable the close-on-exec flag
    for the new file descriptor.
    
    Updates #33405
    Fixes #33424
    
    Change-Id: Ib1e405c3b48b11c867f183fd13eff8b73d95e3b4
    Reviewed-on: https://go-review.googlesource.com/c/go/+/188537
    Run-TryBot: Baokun Lee <[email protected]>
    TryBot-Result: Gobot Gobot <[email protected]>
    Reviewed-by: Ian Lance Taylor <[email protected]>
    (cherry picked from commit 2d6ee6e)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/188538
    Run-TryBot: Ian Lance Taylor <[email protected]>
    oiooj authored and ianlancetaylor committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    047a326 View commit details
    Browse the repository at this point in the history
  2. [release-branch.go1.12] math/big: fix the bug in assembly implementat…

    …ion of shlVU on arm64
    
    For the case where the addresses of parameter z and x of the function
    shlVU overlap and the address of z is greater than x, x (input value)
    can be polluted during the calculation when the high words of x are
    overlapped with the low words of z (output value).
    
    Updates #31084
    Fixes #32940
    
    Change-Id: I9bb0266a1d7856b8faa9a9b1975d6f57dece0479
    Reviewed-on: https://go-review.googlesource.com/c/go/+/169780
    Run-TryBot: Cherry Zhang <[email protected]>
    TryBot-Result: Gobot Gobot <[email protected]>
    Reviewed-by: Cherry Zhang <[email protected]>
    (cherry picked from commit 503e6cc)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/185041
    Run-TryBot: Dmitri Shuralyov <[email protected]>
    erifan01 authored and ianlancetaylor committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    2da8ca4 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2019

  1. [release-branch.go1.12] cmd/link: increase the function call limit in…

    … stkcheck
    
    There is real (albeit generated) code that exceeds the limit.
    
    Updates #33555
    Fixes #33557
    
    Change-Id: I668e85825d3d2a471970e869abe63f3492213cc1
    Reviewed-on: https://go-review.googlesource.com/c/go/+/189697
    Run-TryBot: Ian Lance Taylor <[email protected]>
    TryBot-Result: Gobot Gobot <[email protected]>
    Reviewed-by: Cherry Zhang <[email protected]>
    (cherry picked from commit 951143c)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/189717
    ianlancetaylor committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    4e15604 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2019

  1. [release-branch.go1.12] all: merge release-branch.go1.12-security int…

    …o release-branch.go1.12
    
    Change-Id: I29801b98d975da0bbc092b16dc9771564a39a10a
    FiloSottile committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    07d3f57 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2019

  1. Configuration menu
    Copy the full SHA
    8e7eb2f View commit details
    Browse the repository at this point in the history
  2. [release-branch.go1.12] go1.12.9

    Change-Id: I70dc0e2accd83d9c974b95075f9e83a82d89563d
    Reviewed-on: https://go-review.googlesource.com/c/go/+/190407
    Run-TryBot: Dmitri Shuralyov <[email protected]>
    TryBot-Result: Gobot Gobot <[email protected]>
    Reviewed-by: Alexander Rakoczy <[email protected]>
    dmitshur committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    06472b9 View commit details
    Browse the repository at this point in the history
Loading